Page MenuHomePhabricator
Create Task
Maniphest T10049

Differential highlight reticle persists after focusing an inline comment, then hiding it
Closed, ResolvedPublic
Actions

Description

I apologize because I'm not entirely sure how to reproduce this as I'm not sure how I got into this state. Looking at the screenshot below you can see that the keyboard-focus-focus-reticle div (colored yellow) is slightly too wide and looks odd.

D29416.png (776×1 px, 386 KB)

Revisions and Commits

rP Phabricator
D17903rP665ff4fdf6e7 Redraw the Differential keyboard reticle after collapsing/un-collapsing an…

Related Objects
Search...

Event Timeline

joshuaspence created this task.Dec 23 2015, 8:56 PM
chad closed this task as Invalid.Dec 23 2015, 8:58 PM
chad claimed this task.
chad added a comment.Dec 23 2015, 9:00 PM

Reproduction steps are required for bug reports, please.

joshuaspence added a comment.Dec 23 2015, 9:05 PM

Ah, I figured it out by just pressing each letter of the keyboard sequentially.

  1. With an inline comment box open, continuously press j until the comment box is selected.
  2. Hide the inline comment.
  3. The highlight persists even after the comment is hidden.
chad reopened this task as Open.Dec 23 2015, 9:06 PM
chad triaged this task as Wishlist priority.
chad added a comment.Dec 23 2015, 9:13 PM

epriestley renamed this task from `keyboard-focus-focus-reticle` div is too wide to Differential highlight reticle persists after focusing an inline comment, then hiding it.Dec 24 2015, 11:04 AM
epriestley removed chad as the assignee of this task.
epriestley added a subscriber: chad.
cspeckmim added a subscriber: cspeckmim.Dec 26 2015, 4:13 PM

Possibly related to T9270?

epriestley mentioned this in T8909: Provide ability to hide all inline or done comments.Jun 17 2016, 4:23 PM
epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:29 PM
Herald added a subscriber: eadler. · View Herald TranscriptDec 29 2016, 4:29 PM
epriestley added a project: Inline Comments.Apr 21 2017, 12:20 PM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:23 PM
epriestley moved this task from Glitches to Reticle on the Inline Comments board.Apr 24 2017, 10:25 AM
epriestley added a parent task: T12634: Keyboard focus reticle is generally oblivious to the world around it.
epriestley added a revision: D17903: Redraw the Differential keyboard reticle after collapsing/un-collapsing an inline.May 16 2017, 2:05 PM
epriestley added a subscriber: epriestley.May 16 2017, 2:07 PM

I've marked D17903 as fixing this. We still keep the comment focused, but comments no longer collapse en-masse after changes in T12616. Current state of the world is:

Screen Shot 2017-05-16 at 7.03.18 AM.png (828×1 px, 155 KB)

I expect to add a keyboard shortcut for hide/un-hide so this state will make some kind of sense after that.

epriestley closed this task as Resolved by committing rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an….May 16 2017, 3:22 PM
epriestley added a commit: rP665ff4fdf6e7: Redraw the Differential keyboard reticle after collapsing/un-collapsing an….
Phabricator · Built by Phacility