Page MenuHomePhabricator

When clicking an image in the comment edit modal, the image modal gets under the edit modal
Open, WishlistPublic

Description

Steps to reproduce:

  • make a comment in a diff
  • edit that comment
  • in the modal paste an image
  • click on the image in the preview mode
  • see image appears behind the modal

Version: I'm not an admin so I don't know my version

Image to prove I'm not crazy:

Event Timeline

chad added a subscriber: chad.Jun 17 2016, 2:14 PM

looks like an awesome feature to me

We might have had some kind of dialog action from lightboxes in the past (or planned to have one -- like image inline comments?), but didn't have a lightbox action from dialogs until inline previews.

I think we could currently just give the Lightbox a bigger z-index since I believe there are no cases where we put a dialog over a lightbox legitimately today, but that could change in the future. At some point, we may need a better concept of UI "layers" so you can stack a bunch of dialogs and lightboxes on top of each other or whatever (e.g., click an image, add a comment with an image inside it, preview the comment, click the image in the comment, add a comment on that image, ad infinitum).

There was some discussion of introducing a "sheets" UI for pulling tasks up on workboards, which would also require this, but I don't know if that made it to a task.

T8200 describes a somewhat-similar issue.

epriestley triaged this task as Wishlist priority.Dec 29 2016, 6:09 PM

Kicking this out of Differential because this is reproducible in every application that allows you to edit comments.

This has been "fixed" -- we no longer lightbox -- but we just take you off the page now instead of lightboxing, which is probably not ideal. At a minimum, opening the image in a new window might be cleaner? Or just not letting you click the image at all?

But I suspect the long-term fix is introducing managed layers/sheets so you can lightbox, edit a comment in the lightbox, preview that, click an image, add a comment to that, edit that comment, etc., and then wind all the layers back one by one when you're done editing your comment on an image in a comment in a lightbox on a task on a workboard on a search result.