Page MenuHomePhabricator
Create Task
Maniphest T9270

Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset
Closed, ResolvedPublic
Actions

Description

This requires the user setting for enabling the File Browser is turned on.

  1. Ensure the file browser on the left is not showing
  2. Click a line to begin adding inline comment
  3. Focus outside the editor of the comment editor
  4. Hit 'F' to toggle the file browser to appear
  5. The line highlight gets offplaced

Screen Shot 2015-08-26 at 11.59.56 AM.png (932×1 px, 70 KB)

Revisions and Commits

rP Phabricator
D17919rP0ca49fbeb951 Move "hover over an inline to see the affected lines" code to the new class tree
D17902rP3c0da8161967 When the Differential filetree is toggled, resize the keyboard reticle properly

Related Objects
Search...

Event Timeline

cspeckmim created this task.Aug 26 2015, 4:02 PM
cspeckmim updated the task description. (Show Details)
cspeckmim added a project: Differential.
cspeckmim added a subscriber: cspeckmim.
joshuaspence added a subscriber: joshuaspence.Aug 26 2015, 8:37 PM
cspeckmim mentioned this in T10049: Differential highlight reticle persists after focusing an inline comment, then hiding it.Dec 26 2015, 4:13 PM
epriestley mentioned this in T8909: Provide ability to hide all inline or done comments.Jun 17 2016, 4:23 PM
epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:28 PM
Herald added a subscriber: eadler. · View Herald TranscriptDec 29 2016, 4:28 PM
epriestley added a project: Inline Comments.Apr 21 2017, 12:20 PM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:23 PM
epriestley renamed this task from Toggling File Browser on Differential while creating inline comment causes line highlight to offset to Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset.Apr 24 2017, 10:25 AM
epriestley moved this task from Glitches to Reticle on the Inline Comments board.
epriestley added a parent task: T12634: Keyboard focus reticle is generally oblivious to the world around it.Apr 24 2017, 10:27 AM
epriestley added a subscriber: epriestley.May 16 2017, 1:59 PM

This discusses the hover/edit reticle, but the keyboard reticle has the same bug.

epriestley added a revision: D17902: When the Differential filetree is toggled, resize the keyboard reticle properly.May 16 2017, 2:01 PM
epriestley added a commit: rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly.May 16 2017, 3:22 PM
epriestley mentioned this in T12634: Keyboard focus reticle is generally oblivious to the world around it.May 16 2017, 4:45 PM
epriestley renamed this task from Toggling File Browser on Differential while creating inline comment causes keyboard focus reticle to offset to Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset.May 16 2017, 4:49 PM
epriestley added a revision: D17919: Move "hover over an inline to see the affected lines" code to the new class tree.May 16 2017, 11:06 PM
epriestley added a comment.May 16 2017, 11:10 PM

I've marked D17919 as fixing this although it only fixes the "hover with your mouse" half. A followup change will fix the "drag-to-select-a-range" half.

epriestley closed this task as Resolved by committing rP0ca49fbeb951: Move "hover over an inline to see the affected lines" code to the new class tree.May 17 2017, 12:37 AM
epriestley added a commit: rP0ca49fbeb951: Move "hover over an inline to see the affected lines" code to the new class tree.
Phabricator · Built by Phacility