Page MenuHomePhabricator
Create Task
Maniphest T9648

Diffs do not use extended policies, so object policies evaluate in the wrong context
Closed, ResolvedPublic
Actions

Description

On our install, I was added as a reviewer to a differential revision. The diff had a very restrictive view policy of "Subscribers only". I could see the differential revision on the /differential/ page, but upon clicking on it I hit an exception:

FireShot Capture 150 - (9) Unhandled Exception (_Except_ - https___phabricator.freelancer.com_D27030.png (971×1 px, 64 KB)

Revisions and Commits

rP Phabricator
D17123rP65c1c758ed26 Use extended policies in Differential diffs

Event Timeline

joshuaspence created this task.Oct 27 2015, 9:33 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.

I received an email regarding the revision:

REDACTED changed the visibility from "All Users" to "Subscribers".
REDACTED changed the edit policy from "All Users" to "Subscribers".
joshuaspence added a comment.Oct 27 2015, 9:34 PM

OK, I have asked the author to add me as a subscriber... but I still can't load the page.

joshuaspence added a project: Differential.Oct 27 2015, 9:34 PM
joshuaspence updated the task description. (Show Details)
joshuaspence added a comment.Oct 27 2015, 9:42 PM
mysql> SELECT id, phid, status, authorPHID, lastReviewerPHID, dateCreated, dateModified, attached, viewPolicy, editPolicy, repositoryPHID FROM phabricator_differential.differential_revision WHERE id = 27030;
+-------+--------------------------------+--------+--------------------------------+------------------+-------------+--------------+----------+-------------------------------+-------------------------------+--------------------------------+
| id    | phid                           | status | authorPHID                     | lastReviewerPHID | dateCreated | dateModified | attached | viewPolicy                    | editPolicy                    | repositoryPHID                 |
+-------+--------------------------------+--------+--------------------------------+------------------+-------------+--------------+----------+-------------------------------+-------------------------------+--------------------------------+
| 27030 | PHID-DREV-bdeb6h6c4yj32nqfnz7y | 0      | PHID-USER-hfenohlvucsbthy2su73 | NULL             |  1445973949 |   1445982060 | []       | obj.subscriptions.subscribers | obj.subscriptions.subscribers | PHID-REPO-rgnn364lembo2emt5622 |
+-------+--------------------------------+--------+--------------------------------+------------------+-------------+--------------+----------+-------------------------------+-------------------------------+--------------------------------+
1 row in set (0.00 sec)

mysql> SELECT id, phid, revisionID, authorPHID, repositoryPHID, dateCreated, dateModified, viewPolicy FROM phabricator_differential.differential_diff WHERE revisionID = 27030;
+--------+--------------------------------+------------+--------------------------------+--------------------------------+-------------+--------------+------------+
| id     | phid                           | revisionID | authorPHID                     | repositoryPHID                 | dateCreated | dateModified | viewPolicy |
+--------+--------------------------------+------------+--------------------------------+--------------------------------+-------------+--------------+------------+
| 579426 | PHID-DIFF-czvpmjpj23wtl2th2h6a |      27030 | PHID-USER-hfenohlvucsbthy2su73 | PHID-REPO-rgnn364lembo2emt5622 |  1445973947 |   1445973949 | users      |
+--------+--------------------------------+------------+--------------------------------+--------------------------------+-------------+--------------+------------+
1 row in set (0.00 sec)
joshuaspence added a comment.EditedOct 27 2015, 9:43 PM
mysql> SELECT * FROM phabricator_differential.edge WHERE src IN ('PHID-DREV-bdeb6h6c4yj32nqfnz7y', 'PHID-DIFF-czvpmjpj23wtl2th2h6a');
+--------------------------------+------+--------------------------------+-------------+-----+--------+
| src                            | type | dst                            | dateCreated | seq | dataID |
+--------------------------------+------+--------------------------------+-------------+-----+--------+
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   12 | PHID-TASK-shfyd2sba6htlrzybqp5 |  1445973949 |   0 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   21 | PHID-USER-abzwhc667osh5mwd4gk7 |  1445981511 |   2 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   21 | PHID-USER-inwz7rtaiuxgmjduhmmq |  1445981511 |   1 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   21 | PHID-USER-mw6ockgrrgytq3d3yywa |  1445981511 |   0 |   NULL |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   35 | PHID-USER-abzwhc667osh5mwd4gk7 |  1445973949 |   2 | 104425 |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   35 | PHID-USER-inwz7rtaiuxgmjduhmmq |  1445973949 |   1 | 104424 |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   35 | PHID-USER-mw6ockgrrgytq3d3yywa |  1445973949 |   0 | 104423 |
| PHID-DREV-bdeb6h6c4yj32nqfnz7y |   51 | PHID-TASK-shfyd2sba6htlrzybqp5 |  1445974513 |   0 |   NULL |
+--------------------------------+------+--------------------------------+-------------+-----+--------+
epriestley added a subscriber: epriestley.Oct 27 2015, 9:47 PM

Can you see the repository? (PHID-REPO-rgnn364lembo2emt5622)?

joshuaspence added a comment.Oct 27 2015, 10:01 PM
In T9648#142020, @epriestley wrote:

Can you see the repository? (PHID-REPO-rgnn364lembo2emt5622)?

Yeah, I can.

joshuaspence added a comment.Oct 27 2015, 10:01 PM

For now, I just asked him to change the policy to a custom policy consisting of users X, Y, Z.

epriestley moved this task from Backlog to v3 (Infrastructure) on the Differential board.Dec 29 2016, 4:35 PM
Herald added a subscriber: eadler. · View Herald TranscriptDec 29 2016, 4:35 PM
epriestley renamed this task from This revision has no diffs. Something has gone quite wrong. to Diffs do not use extended policies, so object policies evaluate in the wrong context.Jan 1 2017, 4:38 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Policy.
epriestley added a revision: D17123: Use extended policies in Differential diffs.Jan 1 2017, 4:42 PM
epriestley closed this task as Resolved by committing rP65c1c758ed26: Use extended policies in Differential diffs.Jan 1 2017, 5:56 PM
epriestley added a commit: rP65c1c758ed26: Use extended policies in Differential diffs.
Phabricator · Built by Phacility