Page MenuHomePhabricator
Feed All Stories

Jan 3 2017

chad added a comment to T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed.

GitHub returns no results as well, which aligns with my expectation. Do you have an example piece of software that does work like this?

Jan 3 2017, 3:07 PM · Bug Report
urzds added a comment to T11907: `arc feature D123` does not checkout branch for revision D123.

Somewhat related to T4706.

Jan 3 2017, 12:16 PM · Restricted Project, Arcanist, Bug Report
urzds created T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed.
Jan 3 2017, 12:04 PM · Bug Report
urzds added a comment to T10308: Bring back links to task lists on project pages; List name of assignee in workboard cards.

I think I could just build this as an extension? (I've never built one, so I'm a little interested in building one for practice)

Yes:

Jan 3 2017, 11:54 AM · Projects (v3), Feature Request
remusvrm updated Q546: Why repository importing status never reach 100%? from to Why repository importing status never reach 100%? .
Jan 3 2017, 11:41 AM
HuMMeL621 added a comment to Phabricator Gold.

Thank you :)

Jan 3 2017, 10:29 AM

Jan 2 2017

epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 2 2017, 7:47 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 2 2017, 7:22 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T9640: Make Phabricator compatible with PHP7.

See Planning for more information on understanding timelines and priorities, which also answers your question. Thanks!

Jan 2 2017, 7:16 PM · Prioritized, Restricted Project, Infrastructure
andrewshadura added a comment to T9640: Make Phabricator compatible with PHP7.

Speaking of which, was there any progress on this? Debian release is very close, and I have to make phabricator package uninstallable (keeping only Arcanist and libphutil in).

Jan 2 2017, 7:06 PM · Prioritized, Restricted Project, Infrastructure
andrewshadura added a comment to T9640: Make Phabricator compatible with PHP7.

@reet- If you are using ppa:ondrej/php they tend to be of higher quality then the official php packages maintained on ubuntus ppa in most cases. You have to trust someone however and in this case it's ondrej instead of canonical.

Jan 2 2017, 7:05 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 2 2017, 6:56 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks as Resolved by committing Restricted Diffusion Commit.
Jan 2 2017, 6:00 PM · Policy, Differential, Daemons
chad edited this Badge.
Jan 2 2017, 5:56 PM
chad merged T12055: Passphrase uses "edit" permission to decide who can see the secret, not the "visible" permission into T4721: Improve user-facing documentation for Passphrase.
Jan 2 2017, 5:38 PM · Documentation, Passphrase
chad merged task T12055: Passphrase uses "edit" permission to decide who can see the secret, not the "visible" permission into T4721: Improve user-facing documentation for Passphrase.
Jan 2 2017, 5:38 PM · Bug Report
allixsenos created T12055: Passphrase uses "edit" permission to decide who can see the secret, not the "visible" permission.
Jan 2 2017, 5:26 PM · Bug Report
joshuaspence added projects to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward): Diffusion, Herald.
Jan 2 2017, 10:26 AM · Diffusion, Herald, Bug Report
HuMMeL621 backed I2 Donate to Phacility with $20.00 USD.
Jan 2 2017, 9:56 AM · Phacility
wo0d added a comment to Q261: Cannot clone repo hosted on Phabricator via HTTP.

My webserver is apache, first i have same problem, when i disable SELinux, i clone the repo, 500 error is gone, but always "not found"……

Jan 2 2017, 5:04 AM
chad added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

I think we'd have to build another Remarkup rendering target to accomplish that (sending sanitized text-only emails, for example). I also believe we do no policy checks in Remarkup (which is cached).

Jan 2 2017, 3:46 AM · Prioritized, Restricted Project, Arcanist, Bug Report
joshuaspence added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

You're watching #twitter.

Jan 2 2017, 1:42 AM · Prioritized, Restricted Project, Arcanist, Bug Report

Jan 1 2017

DemiMarie added a comment to T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].

libcurl supports SMTP (see https://curl.haxx.se/libcurl/c/smtp-mail.html) and can be used instead, provided that the relevant functions are exposed to PHP. This avoids needing to shell out to an external executable.

Jan 1 2017, 7:50 PM · Mail, Security
johnny-bit added a comment to Q545: Projects query - have subprojects/are subprojects (Answer 493).

That would help me a bit though ;)

Jan 1 2017, 7:19 PM
epriestley added a revision to T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks: Unknown Object (Differential Revision).
Jan 1 2017, 7:10 PM · Policy, Differential, Daemons
epriestley closed T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley closed T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Policy, Differential
epriestley closed T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley closed T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y" as Resolved by committing Restricted Diffusion Commit.
Jan 1 2017, 5:56 PM · Restricted Project, Differential, FreeBSD
epriestley moved T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks from Backlog to v3 (Infrastructure) on the Differential board.
Jan 1 2017, 5:49 PM · Policy, Differential, Daemons
epriestley renamed T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks from PhabricatorApplicationTransactionPublishWorker failures to PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks.
Jan 1 2017, 5:48 PM · Policy, Differential, Daemons
epriestley added a comment to T9058: PhabricatorPolicyFilter::hasCapability() does not apply application-level "Can Use Application" policy checks.

I think the desired behavior is to silently drop the notifications, yes. Specifically, they should be dropped in PhabricatorMailReplyHandler->filterRecipientUsers().

Jan 1 2017, 5:48 PM · Policy, Differential, Daemons
epriestley closed T8591: Undefined index in changeset parser as Invalid.

No clue how to reproduce this.

Jan 1 2017, 5:35 PM · Differential
epriestley closed T7483: Invalid argument supplied for foreach as Invalid.

This recently got rewritten in connection with T11114 and I didn't come up with a way to reproduce it. Not sure if it's still an issue, but we need better reproduction steps if it is.

Jan 1 2017, 5:34 PM · Differential
epriestley moved T6008: Editing files and contributing changes via web from Backlog to Far Future Work on the Differential board.
Jan 1 2017, 5:31 PM · Restricted Project, Wikimedia, Diffusion, Differential
epriestley moved T1554: "create new diff" doesn't handle arcbundles from Backlog to Far Future Work on the Differential board.
Jan 1 2017, 5:30 PM · Differential
epriestley merged T6483: Diffusion doesn't recognize commit landing w/ `Signed-off-by:` line into T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y".
Jan 1 2017, 5:29 PM · Restricted Project, Differential, FreeBSD
epriestley merged task T6483: Diffusion doesn't recognize commit landing w/ `Signed-off-by:` line into T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y".
Jan 1 2017, 5:29 PM · Haskell.org, Diffusion
epriestley closed T1234: differential.query by commitHash only searches the latest commit hashes as Invalid.

This is older than time itself and does not meet the modern standards for a feature request. In particular, I have no idea what problem it was intended to resolve and nothing that has been linked here in the last couple of years gives me much of an idea. There are likely better approaches in a modern context (T5873, T3875 + T11355, maybe?). If you want this for some purpose, feel free to file a new request describing your problem in better detail. T11355 is probably the most relevant?

Jan 1 2017, 5:27 PM · Differential
epriestley moved T1083: Update revisions with merge/rebase diffs so incremental changes can be shown from Backlog to Far Future Work on the Differential board.
Jan 1 2017, 5:23 PM · Differential, Arcanist
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 1 2017, 5:20 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T8800: Inline comments on a diff cause subscribe event instead of comment event as Resolved.

I can't reproduce this at HEAD. I suspect D14853 resolved it.

Jan 1 2017, 5:19 PM · Restricted Project, Differential
epriestley added a comment to T7657: Reviewer changes across `arc diff --update` and web UI are not merged constructively.

T11114 has fixed the web-originated-edit versions of this, where your "Edit Revision" or "Change Reviewers" action spans another edit.

Jan 1 2017, 5:11 PM · Restricted Project, Differential, Arcanist
epriestley renamed T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there from differential.parsecommitmessage error parsing restricted projects to Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there.
Jan 1 2017, 5:07 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley added a revision to T11344: Differential commit message parser immediately rejects objects the user can't see, but Herald can put them there: Unknown Object (Differential Revision).
Jan 1 2017, 5:05 PM · Restricted Project, Differential, Arcanist, Bug Report
epriestley closed T6050: Improve error message / UX when fields are specified twice in revision information as Resolved.

Isn't the right answer to make the web interface reject things that would choke the parser?

Jan 1 2017, 4:54 PM · Differential
epriestley added a revision to T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context: Unknown Object (Differential Revision).
Jan 1 2017, 4:42 PM · Policy, Differential
epriestley renamed T9648: Diffs do not use extended policies, so object policies evaluate in the wrong context from This revision has no diffs. Something has gone quite wrong. to Diffs do not use extended policies, so object policies evaluate in the wrong context.
Jan 1 2017, 4:38 PM · Policy, Differential
epriestley added a revision to T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:": Unknown Object (Differential Revision).
Jan 1 2017, 4:30 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley renamed T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y" from differential commit field parser should be more lenient to Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y".
Jan 1 2017, 4:21 PM · Restricted Project, Differential, FreeBSD
epriestley added a comment to T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y".

The underlying issue here is that fields may, in the general case, contain multiple paragraphs, colons, things that look like field headers, and may be line-wrapped. We must parse this as two fields:

Jan 1 2017, 4:19 PM · Restricted Project, Differential, FreeBSD
epriestley moved T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw from Backlog to v3 on the Diffusion board.
Jan 1 2017, 4:11 PM · Diffusion (v3)
epriestley added a revision to T8360: Differential commit message field parser does not recover from "Differential Revision: X\nAd-Hoc-Custom-Field: Y": Unknown Object (Differential Revision).
Jan 1 2017, 4:11 PM · Restricted Project, Differential, FreeBSD
FauxFaux added a comment to T9640: Make Phabricator compatible with PHP7.

T9235: Add a warning about "always_populate_raw_post_data" being misconfigured is irrelevant on php7, as the setting has been removed. Trying to set it in php.ini appears to silently do nothing.

Jan 1 2017, 3:20 PM · Prioritized, Restricted Project, Infrastructure
epriestley removed a project from T12054: Test: Phacility High Command.
Jan 1 2017, 1:55 PM
epriestley closed T12054: Test as Invalid.
Jan 1 2017, 1:55 PM
• DonDyabla created T12054: Test.
Jan 1 2017, 10:07 AM
joshuaspence added a comment to T10038: Plan the mid-term pathway for unit-test/linter bindings.

Do you see there being a "Blessed" foo-linter (maybe as a repo on this instance?), or will there be multiple foo-tributes fending themselves in the wilds of github?

This is all still pretty early, but I imagine this instance mostly just collecting packages into a directory for now. The actual source might be on GitHub, but you'd be able to search this instance to find all foo-linter extensions by authors who had bothered to register their packages.

In some cases, we'd likely pull linters out of arc and turn them into Phacility-Published extensions (secure.phabricator.com/phacility/foo-linter) which we'd sign. These would be "blessed", as long as you continue trusting our signing keys.

In some cases, I'd like to "soft-bless" extensions as "safe, but don't come to us for support" with some sort of "Community Badge of Quality" key. For example, you might publish a secure.phabricator.com/cburroughs/foo-linter) which we'd sign in an advisory way which mean "we looked at the code, it seems fine, but we aren't taking bug reports for it". The UI and arc install would show users that someone they trust also trusts this code.

In some cases, untamed wilds, but collected in one place and searchable, with signing and a consistent toolset.

If nothing is blessed, you may have to make a decision like this yourself:

$ arc install foo-lint
Query "foo-lint" matches multiple packages:

  secure.phabricator.com/alice/foo-lint
  secure.phabricator.com/bob/foo-lint

None of these packages or vendors are signed by anything you trust.

Which package do you want to install?

But I think that should be OK. And we can do some level of positive and negative curation (advisory signing on good packages, disabling bad packages)..

You'll also be able to have an internal package directory for your company's stuff, so you can just publish internal things to it and then everyone can use standard tools to manage extensions.

Some day far in the future I could imagine the package directory integrating with other applications (e.g., giving each package its own repositories and tasks, like GitHub) but that's definitely far in the future. I expect most extensions (like linter bindings) to be small so they wouldn't get much benefit (e.g., 100 lines of code updated a couple times a year) and large extensions (eventually, third-party applications) to probably want to self-host on their own Phabricator instances in most cases.

The immediate goal is just fixing the problem that distributing extensions is a huge pain and all solutions have major downsides, with "convince the upstream to accept the extension" being the best option for everyone but us. The new distribution mechanism would be:

$ arc lint
Okay, automatically installing all the extensions this project needs.

(...prompts if you need to trust new stuff...)

Done!
...
nice lint output

Which fixes distribution. In the long run, there's a lot we can do to build stronger ecosystem tools, but I'm less worried about tackling that stuff today than I am about moving distribution to a broadly reasonable mechanism.

Jan 1 2017, 3:22 AM · Lint, Arcanist
eadler added a project to T12029: Analysis workflows for Unit Tests information: Restricted Project.
Jan 1 2017, 3:15 AM · Restricted Project, Harbormaster, Feature Request

Dec 31 2016

epriestley moved T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker from Backlog to v3 (Infrastructure) on the Differential board.
Dec 31 2016, 6:13 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T10323: "Action With No Effect" when marking inline comments as done as Resolved by committing Restricted Diffusion Commit.
Dec 31 2016, 6:12 PM · Restricted Project, Restricted Project, Bug Report, Differential
epriestley added a comment to T11114: Move Differential to EditEngine.

I'm going to dump everything into master now because I believe any disastrous brokenness should be reasonably easy to fix at this point.

Dec 31 2016, 6:06 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T10323: "Action With No Effect" when marking inline comments as done: Unknown Object (Differential Revision).
Dec 31 2016, 5:59 PM · Restricted Project, Restricted Project, Bug Report, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 31 2016, 5:59 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 31 2016, 5:34 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 31 2016, 5:24 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 31 2016, 5:01 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed Q543: Projects/subprojects "general" view as resolved.
Dec 31 2016, 12:34 PM
epriestley added Q543: Projects/subprojects "general" view (Answer 494).
Dec 31 2016, 12:34 PM
epriestley closed Q545: Projects query - have subprojects/are subprojects as resolved.
Dec 31 2016, 12:34 PM · Projects
epriestley added Q545: Projects query - have subprojects/are subprojects (Answer 493).
Dec 31 2016, 12:34 PM
johnny-bit updated Q545: Projects query - have subprojects/are subprojects from to Projects query - have subprojects/are subprojects.
Dec 31 2016, 9:15 AM · Projects
chad added a comment to T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.

Maybe similar to T10312 as well... If we see a test plan, skip the next one?

Dec 31 2016, 4:32 AM · Arcanist, Bug Report
chad merged task T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field into T6050: Improve error message / UX when fields are specified twice in revision information.
Dec 31 2016, 4:30 AM · Arcanist, Bug Report
chad merged T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field into T6050: Improve error message / UX when fields are specified twice in revision information.
Dec 31 2016, 4:30 AM · Differential
chad added a comment to T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.

Expected, though it's going to take me a while to find the dupe.

Dec 31 2016, 4:27 AM · Arcanist, Bug Report
dereckson renamed T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field from Arcanist tries to parse phpunit output in the test plan as to Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:30 AM · Arcanist, Bug Report
dereckson updated the task description for T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:30 AM · Arcanist, Bug Report
dereckson updated the task description for T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:29 AM · Arcanist, Bug Report
dereckson updated the task description for T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:29 AM · Arcanist, Bug Report
dereckson created T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.
Dec 31 2016, 3:27 AM · Arcanist, Bug Report
chad edited projects for T12052: Dependent revision stack UI showing endpoints incorrectly, added: Bug Report (Needs Information); removed Bug Report.

We still require steps to reproduce and version information on bug reports. See Contributing Bug Reports for more details.

Dec 31 2016, 2:46 AM · Bug Report (Needs Information)
nipunn created T12052: Dependent revision stack UI showing endpoints incorrectly.
Dec 31 2016, 2:10 AM · Bug Report (Needs Information)

Dec 30 2016

epriestley edited the content of Changelog.
Dec 30 2016, 10:52 PM
epriestley created 2016 Week 53 (End of Year).
Dec 30 2016, 10:52 PM
epriestley renamed 2016 Week 52 (Very Late December) from 2016 Week 52 (End of Year) to 2016 Week 52 (Very Late December).
Dec 30 2016, 10:52 PM
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 30 2016, 10:09 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
OCram edited the content of Community Resources.
Dec 30 2016, 8:11 AM

Dec 29 2016

patrickc91 edited the content of Organizations Using Phabricator.
Dec 29 2016, 11:18 PM
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 29 2016, 9:44 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 29 2016, 9:20 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12049: Give EditEngine universal support for "Haunted Mode", a subtask of T11114: Move Differential to EditEngine, as Resolved.
Dec 29 2016, 8:49 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T12049: Give EditEngine universal support for "Haunted Mode" as Resolved by committing Restricted Diffusion Commit.
Dec 29 2016, 8:49 PM · EditEngine, Differential
epriestley added a revision to T11050: Allow resigning from a review you are not directly responsible for: Unknown Object (Differential Revision).
Dec 29 2016, 6:53 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 29 2016, 6:53 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T5853: Hint to blocking reviewers that they're blocking in earlier acceptance emails from Backlog to Reviewer Rules on the Differential board.
Dec 29 2016, 6:12 PM · Restricted Project, Differential
epriestley moved T5030: Improve behavior when jumping to inline comments from v2 (UI/Mobile) to Inline Infra on the Differential board.
Dec 29 2016, 6:11 PM · Inline Comments, Restricted Project, Differential
epriestley moved T1026: Request: ability to select line range for comment via touchscreen from v2 (UI/Mobile) to Inline Infra on the Differential board.
Dec 29 2016, 6:11 PM · Inline Comments, Differential
epriestley moved T802: "43 ↗" etc comments should link to the comment on the left side of the screen. from v2 (UI/Mobile) to Inline Infra on the Differential board.
Dec 29 2016, 6:11 PM · Inline Comments, Differential
epriestley moved T10050: Differential-to-Asana integration, like with JIRA from Backlog to Far Future Work on the Differential board.
Dec 29 2016, 6:10 PM · Doorkeeper, Differential, Asana, Feature Request