| cspeckmim | |
| Sep 16 2016, 3:41 AM |
| F4921726: Screen Shot 2017-04-24 at 2.57.46 AM.png | |
| Apr 24 2017, 10:03 AM |
| F1832993: Screen Shot 2016-09-15 at 11.16.04 PM.png | |
| Sep 16 2016, 3:41 AM |
For example see D16561#inline-52688:
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | epriestley | T12634 Keyboard focus reticle is generally oblivious to the world around it | ||
| Resolved | None | T11648 Jumping to an reply inline comment via URL anchor should highlight the comment node accurately |
There are three different highlights at play here, visible in this screenshot:
I think the positioning on Highlight 3 here isn't totally unreasonable -- it's "correct" in some sense -- but we should probably listen for this event, intercept it, and instead pretend that the user pressed n to select the inline with the keyboard focus instead of using the default highlight behavior.
Oh, the highlight itself actually is a little off if the reply is threaded. We move the comment up a little bit to make it visually thread a little more cleanly, but the highlight doesn't get a corresponding offset.
I'm inclined not to actually pursue the autofocus approach I was considering before, at least until we get a better read on whether click-to-select is a good behavior or not. Instead, I'm just going to fiddle with the UI a bit to fix the alignment issue. The new hidden inline state has some similar alignment issues.