Page MenuHomePhabricator

Provide a keyboard shortcut to focus the comment textarea in Differential
Closed, ResolvedPublic

Description

While navigating a code review with keyboard shortcuts, it would be nice to be able to start an inline comment with a keyboard shortcut :)

Also, it would be nice for there to be a keyboard shortcut to jump into input box of the haunted comment panel.

Event Timeline

markjen raised the priority of this task from to Needs Triage.
markjen updated the task description. (Show Details)
markjen added a subscriber: markjen.

I don't understand how the keyboard could be used to truly do an inline comment because inline comments are tied to specific line numbers? How did you envision this working? Note you can already edit + reply to existing inline comments (and cycle through existing inline comments) using the keyboard.

Haunted panel piece I grok. :D

epriestley renamed this task from Differential keyboard shortcut to start inline comment to Provide a keyboard shortcut to focus the comment textarea in Differential.Apr 24 2014, 12:59 PM
epriestley triaged this task as Wishlist priority.

Is there any reason haunted shouldn't automatically focus the textbox when you bring it up?

Pressing the button several times in a row would no longer toggle modes.

A keyboard shortcut to focus the comment box in maniphest would also be useful.

epriestley claimed this task.

After D17105 (Maniphest) and D17106 (Differential), comment forms can be pinned on screen in any modern application by pressing Z. This also focuses the comment area. This pinned mode no longer has multiple different modal toggles (they're somewhat obsoleted by inline preview, and by scrolling improvements) so focusing the comment area no longer conflicts with pressing the key multiple times to cycle modes.

This isn't actually available yet (it will likely hit master on Saturday), but I'm going to mark this as resolved now to limit bookkeeping since this is connected to T12010 via T11114. Feel free to file followups if there are issues with the new stuff once it hits.