Using the Z shortcut to show the comment panel haunter causes the end of the revision to not be totally visible. This is more noticeable on larger revisions. When using the first haunt mode (single Z), the height seems to be off by ~15px, as the cutoff seems to happen midway between the last line in diff (in the screenshots, line 893 is the last line of the displayed context).
Using the second haunt mode Z+Z the height seems to be off by the height of the comment panel itself.
I am unable to reproduce this on this install (secure.phabricator.com) using the same browsers/systems - the height behavior here seems to work properly. I've tried setting up a new instance on Phacility however was unable to get a test repository working to where I could push to it. I will continue to try and get this setup on a test phacility instance.
I've seen this for several weeks now (since I learned of comment haunter). I recently upgraded over the weekend and verified that I'm still seeing this issue.
Environment
| libphutil | fc84916a1a31865f8b48d99d98766b2a1c29ef3a |
| arcanist | 10e5194752901959507223c01e0878e6b8312cc5 |
| phabricator | c8281bc339277290ce76c5679881c1da8f1a2df2 |
I can check on Windows systems if need be
| Browser | OS |
|---|---|
| Firefox 48.0.1 | OSX 10.10.5, 10.11.5 |
| Safari 9.1.3 | OSX 10.10.5, 10.11.5 |
| Chrome 53 | OSX 10.10.5, 10.11.5 |
The following are the configs I would think might affect this behavior, but the majority of them are using the default.
| Config | Value |
|---|---|
| ui.header-color | "green" |
| ui.logo | None |
| ui.footer-items | None |
| User Config | Value |
| Show Unified Diffs | Default (On Small Screens) |
| Show Older Inlines | Default (Enabled) |
| Show Filetree | Default (Enable Filetree) |
| Accessibility | Use High Contrast Colors |