Page MenuHomePhabricator
Create Task
Maniphest T6273

Inline comments do not support editing (Pholio, Differential, Diffusion)
Closed, DuplicatePublic
Actions

Description

The comment text is removed, but the inlines still exist.

Related Objects

Event Timeline

chad created this task.Oct 8 2014, 5:51 PM
chad raised the priority of this task from to Normal.
chad updated the task description. (Show Details)
chad added projects: Pholio, Transactions.
chad added a subscriber: chad.
epriestley added a subscriber: epriestley.Oct 8 2014, 8:09 PM

This is expected -- in theory, each inline should be individually editable (with viewable history), removable, quotable, and show raw-able. There's just no UI for this (and not much of a clear place to put it in some cases). The underlying requests likely work correctly today, since inlines and normal comments are identical from the backend's perspective.

chad renamed this task from Removing a comment in Pholio with Inlines does not hide inlines to Unable to edit/delete inline comments in Pholio.Oct 8 2014, 8:13 PM
chad merged a task: T7211: Test by Milo.Feb 8 2015, 3:31 PM
chad added subscribers: Moosh-be, milo.
witrin awarded a token.Apr 8 2015, 11:49 AM
witrin added a subscriber: witrin.
chad mentioned this in T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.May 25 2015, 2:02 AM
epriestley renamed this task from Unable to edit/delete inline comments in Pholio to Inline comments do not support editing (Pholio, Differential, Diffusion).Mar 25 2016, 5:29 PM
epriestley merged a task: T10669: Can't edit inline comments on diff.
epriestley added projects: Differential, Diffusion.
epriestley added a subscriber: getaaron.
Herald added a subscriber: eadler. · View Herald TranscriptMar 25 2016, 5:30 PM
• ersanagirman added a mock: M1454: ss.Mar 28 2016, 4:08 PM
chad removed a mock: M1454: ss.Mar 28 2016, 4:09 PM
janitorial added a subscriber: janitorial.May 31 2016, 12:50 PM
eadler added a project: Restricted Project.Jul 7 2016, 5:00 PM
epriestley added a comment.Jul 31 2016, 7:08 PM

See also T11401, although this started life as a Pholio task and that's now a code-specific UI task so I don't know if they're actually the same.

epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:30 PM
epriestley added a project: Audit.Jan 10 2017, 5:16 PM
epriestley moved this task from Backlog to Inlines on the Audit board.Jan 10 2017, 5:20 PM
epriestley added a comment.Apr 21 2017, 12:04 PM

I'm just going to merge this into T11401, at least for the moment. That may eventually split out into application-specific tasks when it gets underway.

epriestley closed this task as a duplicate of T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.Apr 21 2017, 12:04 PM
Phabricator · Built by Phacility