Page MenuHomePhabricator
Feed Advanced Search

May 21 2019

amckinley accepted D20529: Support timeouts in OAuth1Future.
May 21 2019, 5:44 PM
amckinley accepted D20525: Fix an issue where handles could load with the incorrect viewer when building mail about changes to related objects.
May 21 2019, 5:43 PM
amckinley accepted D20527: When an object is referenced by URI, treat it like a mention.
May 21 2019, 5:30 PM
amckinley updated the summary of D20537: Support "none()" in Differential to find revisions with no (un-resigned) reviewers.
May 21 2019, 5:07 PM
amckinley accepted D20536: To improve wrapping behavior of rendered README files, don't use "PHUIDocumentView" in Diffusion.
May 21 2019, 5:05 PM

May 17 2019

amckinley accepted D20454: Separate the "configuration" and "evaluation" phases of chart functions.
May 17 2019, 4:07 PM
amckinley accepted D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully.
May 17 2019, 3:56 PM

May 16 2019

amckinley accepted D20522: Improve the performance of large remarkup documents with many complex rules.

I've been staring at this long enough that I can plausibly claim to understand how it works. Put this on the pile of "terrible interview questions that I'm sure someone somewhere is getting asked".

May 16 2019, 5:49 PM
amckinley accepted D20520: Add a "Published document changed" rule to Herald for Phriction documents.
May 16 2019, 4:22 PM
amckinley accepted D20495: Add a "Reports" menu item to Projects.
May 16 2019, 4:00 PM
amckinley accepted D20519: When using the Herald test console on a transactional object, guess a reasonable set of transactions to simulate.
May 16 2019, 1:12 PM
amckinley accepted D20493: Make branch status more clear on Diffusion branches view.
May 16 2019, 1:05 PM
amckinley updated the summary of D20493: Make branch status more clear on Diffusion branches view.
May 16 2019, 1:03 PM
amckinley accepted D20492: Add support for custom "Wait for Approval" instructions.
May 16 2019, 1:01 PM
amckinley accepted D20507: Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search".
May 16 2019, 12:59 PM
amckinley accepted D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.

I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.

May 16 2019, 12:57 PM
amckinley accepted D20477: Improve the performance of tab replacement in common cases.
May 16 2019, 12:53 PM

May 15 2019

amckinley accepted D20518: In Herald, save applied transaction PHIDs in the transcript and display them in the UI.
May 15 2019, 5:37 PM
amckinley accepted D20517: When viewing a workboard, only link to parent workboards in crumbs if parents have workboards.
May 15 2019, 2:03 PM
amckinley accepted D20498: Roughly support stacked area charts.
May 15 2019, 2:03 PM

May 14 2019

amckinley accepted D20497: Update D3 to the current version.
May 14 2019, 2:52 PM
amckinley accepted D20513: Don't mark subscribes/mentions as "Lock Overridden".
May 14 2019, 2:50 PM
amckinley accepted D20521: Remove WePay support from Phortune, and Restful/Httpful dependencies.

burnittotheground

May 14 2019, 2:48 PM
amckinley accepted D20508: Expose subscribers transaction data via Conduit "transaction.search".
May 14 2019, 2:38 PM
amckinley accepted D20494: Fix a potential double-prompt in "arc land" when landing with ongoing builds.
May 14 2019, 2:38 PM
amckinley accepted D20516: Fix a fatal when navigating to a Workboard after removing the Workboard menu item.
May 14 2019, 2:37 PM
amckinley accepted D20491: Hide the "added a commit/revision" stories from feed and mail.
May 14 2019, 2:37 PM

May 2 2019

amckinley accepted D20490: Fix the direction of the commit/revision edge.
May 2 2019, 12:50 PM

May 1 2019

amckinley accepted D20475: Add "Move Left" and "Move Right" to dashboard tab panels.
May 1 2019, 2:37 PM
amckinley accepted D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.
May 1 2019, 2:36 PM
amckinley accepted D20484: Remove obsolete Dashboard panel methods with no callsites.
May 1 2019, 2:32 PM
amckinley accepted D20476: Really fix movable panels inside tab panels by changing the JX.Request serializer.
May 1 2019, 2:31 PM
amckinley accepted D20472: Restore "Limit" to dashboard Query panels.
May 1 2019, 2:29 PM
amckinley retitled D20472: Restore "Limit" to dashboard Query panels from Resore "Limit" to dashboard Query panels to Restore "Limit" to dashboard Query panels.
May 1 2019, 2:29 PM
amckinley accepted D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).
May 1 2019, 2:28 PM
amckinley accepted D20469: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions.
May 1 2019, 2:26 PM
amckinley accepted D20487: Remove the legacy chart behavior from Maniphest.
May 1 2019, 2:01 PM
amckinley accepted D20488: Fix handling of "null" domain values in Charts.

If you min(1, 2, null), you get null.

May 1 2019, 2:00 PM
amckinley accepted D20468: Consolidate readers of "differential.revisionID" property.
May 1 2019, 1:58 PM
amckinley accepted D20489: Start the fact daemon in "bin/phd start".
May 1 2019, 1:48 PM

Apr 29 2019

amckinley accepted D20479: Make very minor generality improvements to the scope selector.
Apr 29 2019, 8:00 PM
amckinley accepted D20473: Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel.
Apr 29 2019, 7:57 PM
amckinley accepted D20480: Update Quickstart SQL.

I have reviewed this exhaustively and can confirm that it's a big file full of SQL ๐Ÿ‘€

Apr 29 2019, 7:56 PM
amckinley accepted D20478: When building a synthetic diff in Differential, adjust diff properties correctly.
Apr 29 2019, 7:53 PM
amckinley updated the summary of D20478: When building a synthetic diff in Differential, adjust diff properties correctly.
Apr 29 2019, 7:52 PM
amckinley accepted D20471: Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button.
Apr 29 2019, 7:52 PM

Apr 24 2019

amckinley accepted D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Apr 24 2019, 4:10 AM
amckinley accepted D20466: Show "hold reasons" on commit page, not on "Edit" page.
Apr 24 2019, 1:01 AM
amckinley accepted D20465: Remove nearly all remaining references to "Autoclose".
Apr 24 2019, 12:47 AM
amckinley accepted D20464: Remove "--force-autoclose" from "bin/repository reparse".
Apr 24 2019, 12:32 AM
amckinley accepted D20463: Move "update related object after commit" to a separate worker in the task queue.
Apr 24 2019, 12:32 AM

Apr 23 2019

amckinley accepted D20462: When applying transactions, acquire a read lock sooner.
Apr 23 2019, 8:03 PM
amckinley accepted D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Apr 23 2019, 5:49 PM
amckinley accepted D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Apr 23 2019, 5:48 PM
amckinley accepted D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Apr 23 2019, 5:19 PM
amckinley added inline comments to D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Apr 23 2019, 5:18 PM
amckinley accepted D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Apr 23 2019, 5:14 PM
amckinley accepted D20457: Move BlameController away from ancient "TABLE_COMMIT".
Apr 23 2019, 4:30 PM
amckinley accepted D20456: Fix "before/after" cursor paging for API call "feed.query".
Apr 23 2019, 4:29 PM
amckinley accepted D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Apr 23 2019, 4:28 PM

Apr 19 2019

remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM
amckinley committed rPde743326394b: Improve timeline rendering for old macros (authored by amckinley).
Improve timeline rendering for old macros
Apr 19 2019, 1:25 AM
amckinley closed D20453: Improve timeline rendering for old macros.
Apr 19 2019, 1:25 AM
amckinley accepted D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Apr 19 2019, 12:26 AM
amckinley requested review of D20453: Improve timeline rendering for old macros.
Apr 19 2019, 12:19 AM
amckinley accepted D20446: Simplify implementation of "pure" Chart functions.
Apr 19 2019, 12:07 AM

Apr 18 2019

amckinley added inline comments to D20442: Select the domain (X-axis range) for charts before pulling data.
Apr 18 2019, 11:42 PM
amckinley created Image Macro "gimli".
Apr 18 2019, 11:41 PM
amckinley accepted D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
Apr 18 2019, 11:37 PM
amckinley accepted D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Apr 18 2019, 11:27 PM
amckinley accepted D20448: Don't warn that workboard columns need a name when editing milestone columns.
Apr 18 2019, 4:40 PM
amckinley accepted D20447: Don't warn about a locked database value after users run "bin/auth lock".
Apr 18 2019, 2:18 AM

Apr 17 2019

amckinley added a comment to D20441: Separate chart functions into a class tree.

we can cache datasets by chart key very near the display layer

Apr 17 2019, 11:29 PM
amckinley added a comment to D20446: Simplify implementation of "pure" Chart functions.

That screenshot produces quite the intense optical effect. I thought I was looking at moirรฉ effect from a cellphone camera.

Apr 17 2019, 11:20 PM
amckinley accepted D20444: Add a "sin()" function to charts.
Apr 17 2019, 11:18 PM
amckinley accepted D20443: Add chart functions "x()" and "constant(3)".
Apr 17 2019, 11:16 PM
amckinley accepted D20442: Select the domain (X-axis range) for charts before pulling data.
Apr 17 2019, 11:01 PM
amckinley accepted D20441: Separate chart functions into a class tree.
Apr 17 2019, 10:50 PM
amckinley accepted D20440: Fetch chart data via async request and redraw charts when the window is resized.

howneatisthat

Apr 17 2019, 10:20 PM
amckinley accepted D20439: Support drawing multiple functions on the same chart.
Apr 17 2019, 10:15 PM
amckinley accepted D20438: Fix negative chart values, add storage for charts.
Apr 17 2019, 9:54 PM
amckinley added a comment to D20437: Hide revision dependency stories from feed/notifications.

A half-step might be to just silence "added a commit to" in all cases?

Apr 17 2019, 9:40 PM
amckinley added a comment to D20437: Hide revision dependency stories from feed/notifications.

All the same underlying action:

Screen Shot 2019-04-17 at 2.30.42 PM.png (465ร—406 px, 76 KB)

Apr 17 2019, 9:31 PM
amckinley accepted D20437: Hide revision dependency stories from feed/notifications.

I feel kinda similarly about getting a flurry of "added commit to TXXX" notifications that fire in addition to the "bob closed DXXX" notifications. We don't have the infrastructure to say stuff like "only hide this notification if the same action already generated a separate notification of type foo, do we?

Apr 17 2019, 9:30 PM
amckinley awarded D20437: Hide revision dependency stories from feed/notifications a Baby Tequila token.
Apr 17 2019, 9:27 PM
amckinley accepted D20436: Make the "git upload-pack" proxy more robust.
Apr 17 2019, 9:26 PM
amckinley accepted D20435: In Git repositories, use "git symbolic-ref HEAD ..." to select the default branch.
Apr 17 2019, 9:17 PM
amckinley accepted D20434: Update "Autoclose" documentation to focus on "Permanent Refs" instead.
Apr 17 2019, 8:46 PM
amckinley accepted D20433: Deprecate "Track Only" in the Diffusion UI.
Apr 17 2019, 8:24 PM
amckinley accepted D20432: Rename some internal "Autoclose" mentions to "Permanent Refs".
Apr 17 2019, 8:11 PM
amckinley accepted D20429: When an invalid "constraints" parameter is provided to a "*.search" method, raise a more tailored error.
Apr 17 2019, 8:10 PM
amckinley accepted D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.
Apr 17 2019, 8:09 PM
amckinley accepted D20427: Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field.

I guess it's not worth cleaning this up and removing the class + DB rows since it's just a no-op now and shouldn't bother anyone.

Apr 17 2019, 8:08 PM
amckinley accepted D20426: Expose repository ref rules via "diffusion.repository.search".
Apr 17 2019, 8:06 PM
amckinley accepted D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.
Apr 17 2019, 7:58 PM
amckinley accepted D20424: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off".
Apr 17 2019, 7:48 PM
amckinley added inline comments to D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.
Apr 17 2019, 7:45 PM
amckinley accepted D20423: Rename most user-facing "Autoclose" strings to "Permanent Refs".
Apr 17 2019, 7:43 PM
amckinley accepted D20422: Add "Fetch Rules" to observed Git repositories.
Apr 17 2019, 7:13 PM
amckinley accepted D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.
Apr 17 2019, 6:56 PM