Page MenuHomePhabricator
Differential D20490

Fix the direction of the commit/revision edge
ClosedPublic
Actions

Authored by epriestley on May 1 2019, 3:47 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Summary

Ref T13276. This edge is pointed the wrong way. Point it the right way.

Test Plan

Will verify production works better.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 1 2019, 3:47 PM
epriestley requested review of this revision.May 1 2019, 3:49 PM
amckinley accepted this revision.May 2 2019, 12:50 PM
This revision is now accepted and ready to land.May 2 2019, 12:50 PM
Closed by commit rP5dc4e76eb9f8: Fix the direction of the commit/revision edge (authored by epriestley). · Explain WhyMay 2 2019, 2:28 PM
This revision was automatically updated to reflect the committed changes.
epriestley added an edge: rP5dc4e76eb9f8: Fix the direction of the commit/revision edge.

Revision Contents
Changeset List

Diff 48882

View Options

src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php

Loading...
Phabricator · Built by Phacility