Page MenuHomePhabricator

Really fix movable panels inside tab panels by changing the JX.Request serializer
ClosedPublic

Authored by epriestley on Apr 25 2019, 7:04 PM.
Tags
None
Referenced Files
F15442778: D20476.id48881.diff
Thu, Mar 27, 12:23 AM
F15438538: D20476.id.diff
Wed, Mar 26, 1:19 AM
F15429692: D20476.diff
Mon, Mar 24, 3:39 AM
F15427706: D20476.id48881.diff
Sun, Mar 23, 3:43 PM
F15413516: D20476.id48881.diff
Wed, Mar 19, 7:25 PM
F15403084: D20476.id48881.diff
Tue, Mar 18, 1:51 AM
F15369290: D20476.id48881.diff
Wed, Mar 12, 6:02 AM
F15293576: D20476.id48881.diff
Mar 5 2025, 4:28 AM
Subscribers
None

Details

Summary

Depends on D20475. Ref T13272. Currently, if you JX.Request with data like {x: null}, we submit that as ?x=null, i.e. as though null was the string "null".

This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.

It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.

Test Plan

Tried to drag a panel inside a tab panel, it really truly didn't work.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable