Page MenuHomePhabricator

Really fix movable panels inside tab panels by changing the JX.Request serializer

Authored by epriestley on Apr 25 2019, 7:04 PM.



Depends on D20475. Ref T13272. Currently, if you JX.Request with data like {x: null}, we submit that as ?x=null, i.e. as though null was the string "null".

This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.

It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.

Test Plan

Tried to drag a panel inside a tab panel, it really truly didn't work.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 25 2019, 7:04 PM
epriestley requested review of this revision.Apr 25 2019, 7:06 PM
amckinley accepted this revision.May 1 2019, 2:31 PM
This revision is now accepted and ready to land.May 1 2019, 2:31 PM