Page MenuHomePhabricator

Really fix movable panels inside tab panels by changing the JX.Request serializer
ClosedPublic

Authored by epriestley on Apr 25 2019, 7:04 PM.
Tags
None
Referenced Files
F19082982: D20476.id48881.diff
Dec 2 2025, 12:28 PM
F19073459: D20476.id.diff
Dec 1 2025, 2:02 AM
F19051775: D20476.diff
Nov 28 2025, 2:05 AM
F19044714: D20476.id48881.diff
Nov 27 2025, 4:09 AM
F18985099: D20476.id48848.diff
Nov 17 2025, 12:53 PM
F18855849: D20476.diff
Nov 1 2025, 6:59 AM
F18839435: D20476.id48881.diff
Oct 27 2025, 4:20 PM
F18837277: D20476.id48881.diff
Oct 27 2025, 4:46 AM
Subscribers
None

Details

Summary

Depends on D20475. Ref T13272. Currently, if you JX.Request with data like {x: null}, we submit that as ?x=null, i.e. as though null was the string "null".

This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.

It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.

Test Plan

Tried to drag a panel inside a tab panel, it really truly didn't work.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable