Page MenuHomePhabricator

Really fix movable panels inside tab panels by changing the JX.Request serializer
ClosedPublic

Authored by epriestley on Apr 25 2019, 7:04 PM.
Tags
None
Referenced Files
F15544793: D20476.id48881.diff
Sat, Apr 26, 7:02 AM
F15543557: D20476.id.diff
Fri, Apr 25, 11:05 PM
F15534879: D20476.diff
Thu, Apr 24, 2:31 AM
F15484189: D20476.diff
Wed, Apr 9, 4:56 PM
F15442778: D20476.id48881.diff
Mar 27 2025, 12:23 AM
F15438538: D20476.id.diff
Mar 26 2025, 1:19 AM
F15429692: D20476.diff
Mar 24 2025, 3:39 AM
F15427706: D20476.id48881.diff
Mar 23 2025, 3:43 PM
Subscribers
None

Details

Summary

Depends on D20475. Ref T13272. Currently, if you JX.Request with data like {x: null}, we submit that as ?x=null, i.e. as though null was the string "null".

This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.

It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.

Test Plan

Tried to drag a panel inside a tab panel, it really truly didn't work.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable