Page MenuHomePhabricator

Remove nearly all remaining references to "Autoclose"
ClosedPublic

Authored by epriestley on Apr 23 2019, 12:12 AM.

Details

Summary

Depends on D20464. Ref T13277. Broadly:

  • Move all the "should publish X" and "why aren't we publishing X" stuff to a separate class (PhabricatorRepositoryPublisher).
  • Rename things to be more consistent with modern terminology ("Publish", "Permanent Refs").
Test Plan

This could use some trial-by-fire on secure, but:

  • Grepped for all symbols.
  • Viewed various commits.
  • Reparsed commits.
  • Here's a commit with an explanation:

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 23 2019, 12:12 AM
epriestley requested review of this revision.Apr 23 2019, 12:14 AM
amckinley accepted this revision.Apr 24 2019, 12:47 AM
This revision is now accepted and ready to land.Apr 24 2019, 12:47 AM
This revision was automatically updated to reflect the committed changes.