Page MenuHomePhabricator

Remove nearly all remaining references to "Autoclose"
ClosedPublic

Authored by epriestley on Apr 23 2019, 12:12 AM.
Tags
None
Referenced Files
F15471096: D20465.diff
Sat, Apr 5, 3:14 AM
F15449089: D20465.id48819.diff
Fri, Mar 28, 8:25 AM
F15423254: D20465.id48839.diff
Sat, Mar 22, 2:17 PM
F15420132: D20465.id.diff
Fri, Mar 21, 11:35 AM
F15420091: D20465.id48819.diff
Fri, Mar 21, 11:15 AM
F15410341: D20465.diff
Wed, Mar 19, 7:06 AM
F15360841: D20465.diff
Tue, Mar 11, 10:40 AM
F15351028: D20465.diff
Mon, Mar 10, 3:30 PM
Subscribers
None

Details

Summary

Depends on D20464. Ref T13277. Broadly:

  • Move all the "should publish X" and "why aren't we publishing X" stuff to a separate class (PhabricatorRepositoryPublisher).
  • Rename things to be more consistent with modern terminology ("Publish", "Permanent Refs").
Test Plan

This could use some trial-by-fire on secure, but:

  • Grepped for all symbols.
  • Viewed various commits.
  • Reparsed commits.
  • Here's a commit with an explanation:

Screen Shot 2019-04-22 at 5.08.48 PM.png (106×501 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable