Page MenuHomePhabricator

Remove nearly all remaining references to "Autoclose"
ClosedPublic

Authored by epriestley on Apr 23 2019, 12:12 AM.
Tags
None
Referenced Files
F19062905: D20465.id.diff
Sat, Nov 29, 4:57 PM
F19062628: D20465.diff
Sat, Nov 29, 4:18 PM
F19053854: D20465.id.diff
Fri, Nov 28, 10:07 AM
F18831010: D20465.id.diff
Oct 25 2025, 10:09 AM
F18826776: D20465.diff
Oct 24 2025, 5:43 AM
F18807277: D20465.id48819.diff
Oct 19 2025, 12:18 AM
F18736218: D20465.id48819.diff
Oct 1 2025, 5:08 AM
F18736179: D20465.id48839.diff
Oct 1 2025, 5:05 AM
Subscribers
None

Details

Summary

Depends on D20464. Ref T13277. Broadly:

  • Move all the "should publish X" and "why aren't we publishing X" stuff to a separate class (PhabricatorRepositoryPublisher).
  • Rename things to be more consistent with modern terminology ("Publish", "Permanent Refs").
Test Plan

This could use some trial-by-fire on secure, but:

  • Grepped for all symbols.
  • Viewed various commits.
  • Reparsed commits.
  • Here's a commit with an explanation:

Screen Shot 2019-04-22 at 5.08.48 PM.png (106×501 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable