Page MenuHomePhabricator

Remove nearly all remaining references to "Autoclose"
ClosedPublic

Authored by epriestley on Apr 23 2019, 12:12 AM.
Tags
None
Referenced Files
F18653734: D20465.diff
Sun, Sep 21, 3:54 PM
F18653481: D20465.diff
Sun, Sep 21, 1:54 PM
F18644979: D20465.diff
Fri, Sep 19, 6:37 AM
F18569952: D20465.id48839.diff
Wed, Sep 10, 3:01 AM
F18569951: D20465.id48819.diff
Wed, Sep 10, 3:01 AM
F18519116: D20465.diff
Fri, Sep 5, 3:55 PM
F18388464: D20465.id48819.diff
Aug 29 2025, 4:28 AM
F18361658: D20465.id48819.diff
Aug 27 2025, 12:28 PM
Subscribers
None

Details

Summary

Depends on D20464. Ref T13277. Broadly:

  • Move all the "should publish X" and "why aren't we publishing X" stuff to a separate class (PhabricatorRepositoryPublisher).
  • Rename things to be more consistent with modern terminology ("Publish", "Permanent Refs").
Test Plan

This could use some trial-by-fire on secure, but:

  • Grepped for all symbols.
  • Viewed various commits.
  • Reparsed commits.
  • Here's a commit with an explanation:

Screen Shot 2019-04-22 at 5.08.48 PM.png (106×501 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable