Page MenuHomePhabricator

Remove nearly all remaining references to "Autoclose"
ClosedPublic

Authored by epriestley on Apr 23 2019, 12:12 AM.
Tags
None
Referenced Files
F18361658: D20465.id48819.diff
Wed, Aug 27, 12:28 PM
F18361484: D20465.id.diff
Wed, Aug 27, 12:11 PM
F18264147: D20465.id.diff
Fri, Aug 22, 10:25 AM
F18243880: D20465.diff
Thu, Aug 21, 5:58 AM
F18100462: D20465.id.diff
Sat, Aug 9, 11:54 AM
F18090230: D20465.diff
Wed, Aug 6, 2:55 PM
F17724465: D20465.diff
Jul 18 2025, 12:47 PM
Unknown Object (File)
Jun 16 2025, 5:13 PM
Subscribers
None

Details

Summary

Depends on D20464. Ref T13277. Broadly:

  • Move all the "should publish X" and "why aren't we publishing X" stuff to a separate class (PhabricatorRepositoryPublisher).
  • Rename things to be more consistent with modern terminology ("Publish", "Permanent Refs").
Test Plan

This could use some trial-by-fire on secure, but:

  • Grepped for all symbols.
  • Viewed various commits.
  • Reparsed commits.
  • Here's a commit with an explanation:

Screen Shot 2019-04-22 at 5.08.48 PM.png (106×501 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable