Page MenuHomePhabricator

When viewing a workboard, only link to parent workboards in crumbs if parents have workboards
ClosedPublic

Authored by epriestley on May 13 2019, 2:22 PM.
Tags
None
Referenced Files
F18021628: D20517.id.diff
Aug 2 2025, 8:15 PM
F17978372: D20517.diff
Aug 1 2025, 6:01 PM
F17911055: D20517.id.diff
Jul 29 2025, 3:18 PM
F17899755: D20517.diff
Jul 29 2025, 8:45 AM
F17897360: D20517.id48910.diff
Jul 29 2025, 7:32 AM
F17842253: D20517.id48928.diff
Jul 26 2025, 11:24 PM
Unknown Object (File)
Jun 27 2025, 5:46 PM
Unknown Object (File)
May 28 2025, 5:57 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

Depends on D20516. See PHI1247. In D20331, I made the crumbs on workboards point at ancestor workboards.

However, this isn't a great destination if an ancestor doesn't actually have a workboard. In this case, point at the normal profile URI instead.

Test Plan
  • Viewed a milestone workboard with a parent that had no workboard. Saw a profile link instead of a workboard link (new behavior).
  • Viewed a milestone workboard with a parent that also had a workboard. Saw a workboard link (existing old behavior still works).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable