Page MenuHomePhabricator

When viewing a workboard, only link to parent workboards in crumbs if parents have workboards
ClosedPublic

Authored by epriestley on May 13 2019, 2:22 PM.

Details

Reviewers
amckinley
Summary

Depends on D20516. See PHI1247. In D20331, I made the crumbs on workboards point at ancestor workboards.

However, this isn't a great destination if an ancestor doesn't actually have a workboard. In this case, point at the normal profile URI instead.

Test Plan
  • Viewed a milestone workboard with a parent that had no workboard. Saw a profile link instead of a workboard link (new behavior).
  • Viewed a milestone workboard with a parent that also had a workboard. Saw a workboard link (existing old behavior still works).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 13 2019, 2:22 PM
epriestley requested review of this revision.May 13 2019, 2:23 PM
amckinley accepted this revision.May 15 2019, 2:03 PM
This revision is now accepted and ready to land.May 15 2019, 2:03 PM