Page MenuHomePhabricator

Fix handling of "null" domain values in Charts
ClosedPublic

Authored by epriestley on Tue, Apr 30, 4:43 PM.

Details

Summary

Depends on D20487. If you min(1, 2, null), you get null. We want 1.

Test Plan

Viewed a "burnup for project X" chart where one dataseries had no datapoints. Saw a sensible domain selected automatically.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Apr 30, 4:43 PM
epriestley requested review of this revision.Tue, Apr 30, 4:45 PM
amckinley accepted this revision.Wed, May 1, 2:00 PM

If you min(1, 2, null), you get null.

frowncat

This revision is now accepted and ready to land.Wed, May 1, 2:00 PM

For PHP, that's pretty good!

$ php -r 'echo min(array("mouse", "cat", "dog", "aardvark", "zebra"));'
aardvark