Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel
ClosedPublic
Actions

Authored by epriestley on Apr 25 2019, 5:38 PM.

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Summary

Depends on D20472. Ref T13272. Currently, when you edit a panel from a dashboard, we try to add the panel to the dashboard. This always works since dashboards no longer enforce panel uniqueness, and you can end up with duplicate panels.

Instead, only add panels if we're creating them.

Test Plan

Edited an existing panel, no duplication.
Created a new panel, saw it added to the dashboard.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 25 2019, 5:38 PM

Harbormaster completed remote builds in B22720: Diff 48845.Apr 25 2019, 5:40 PM

epriestley requested review of this revision.Apr 25 2019, 5:40 PM

epriestley added a child revision: D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.Apr 25 2019, 6:05 PM

amckinley accepted this revision.Apr 29 2019, 7:57 PM

This revision is now accepted and ready to land.Apr 29 2019, 7:57 PM

Closed by commit rPdfbc4c1cd338: Fix an issue where editing a dashboard panel from a dashboard could duplicate… (authored by epriestley). · Explain WhyApr 30 2019, 3:27 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rPdfbc4c1cd338: Fix an issue where editing a dashboard panel from a dashboard could duplicate….

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

editor/

PhabricatorDashboardPanelEditEngine.php

6 lines

Diff 48864

View Options

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Fix an issue where editing a dashboard panel from a dashboard could duplicate the panelClosedPublicActions