Page MenuHomePhabricator

Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel
ClosedPublic

Authored by epriestley on Apr 25 2019, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 7:17 PM
Unknown Object (File)
Tue, Jan 21, 3:36 PM
Unknown Object (File)
Tue, Jan 21, 10:19 AM
Unknown Object (File)
Dec 20 2024, 11:51 PM
Unknown Object (File)
Dec 17 2024, 5:43 PM
Unknown Object (File)
Dec 5 2024, 10:13 AM
Unknown Object (File)
Dec 2 2024, 5:53 PM
Unknown Object (File)
Nov 28 2024, 1:40 PM
Subscribers
None

Details

Summary

Depends on D20472. Ref T13272. Currently, when you edit a panel from a dashboard, we try to add the panel to the dashboard. This always works since dashboards no longer enforce panel uniqueness, and you can end up with duplicate panels.

Instead, only add panels if we're creating them.

Test Plan
  • Edited an existing panel, no duplication.
  • Created a new panel, saw it added to the dashboard.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable