Page MenuHomePhabricator

Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel
ClosedPublic

Authored by epriestley on Apr 25 2019, 5:38 PM.
Tags
None
Referenced Files
F18733956: D20473.id.diff
Tue, Sep 30, 10:45 PM
F18619948: D20473.id48864.diff
Mon, Sep 15, 3:49 AM
F18597696: D20473.diff
Sat, Sep 13, 3:28 AM
F18569990: D20473.id48864.diff
Wed, Sep 10, 3:03 AM
F18569988: D20473.id48845.diff
Wed, Sep 10, 3:03 AM
F18519169: D20473.diff
Fri, Sep 5, 3:58 PM
F18341619: D20473.diff
Aug 26 2025, 12:41 AM
F18100468: D20473.diff
Aug 9 2025, 11:54 AM
Subscribers
None

Details

Summary

Depends on D20472. Ref T13272. Currently, when you edit a panel from a dashboard, we try to add the panel to the dashboard. This always works since dashboards no longer enforce panel uniqueness, and you can end up with duplicate panels.

Instead, only add panels if we're creating them.

Test Plan
  • Edited an existing panel, no duplication.
  • Created a new panel, saw it added to the dashboard.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable