Page MenuHomePhabricator

Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel
ClosedPublic

Authored by epriestley on Thu, Apr 25, 5:38 PM.

Details

Summary

Depends on D20472. Ref T13272. Currently, when you edit a panel from a dashboard, we try to add the panel to the dashboard. This always works since dashboards no longer enforce panel uniqueness, and you can end up with duplicate panels.

Instead, only add panels if we're creating them.

Test Plan
  • Edited an existing panel, no duplication.
  • Created a new panel, saw it added to the dashboard.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.