Page MenuHomePhabricator
Differential D20461

Remove all remaining readers and writers for TABLE_COMMIT
ClosedPublic
Actions

Authored by epriestley on Apr 22 2019, 7:51 PM.
Tags
None
Referenced Files
F18579332: D20461.id48815.diff
Thu, Sep 11, 12:19 AM
F18569944: D20461.id48835.diff
Wed, Sep 10, 3:00 AM
F18569941: D20461.id48815.diff
Wed, Sep 10, 3:00 AM
F18519110: D20461.diff
Fri, Sep 5, 3:54 PM
F18408482: D20461.id48815.diff
Aug 30 2025, 2:45 AM
F18363216: D20461.id.diff
Aug 27 2025, 4:05 PM
F18363197: D20461.id48815.diff
Aug 27 2025, 4:02 PM
F18362551: D20461.id48835.diff
Aug 27 2025, 2:18 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Commits
rP42c02557e4e3: Remove all remaining readers and writers for TABLE_COMMIT
Summary

Depends on D20459. Ref T13276. I'll file a followup to actually destroy the table.

Test Plan
  • Grepped for TABLE_COMMIT.
  • Ran bin/storage upgrade -f, got a clean bill of health.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 22 2019, 7:51 PM
Harbormaster completed remote builds in B22687: Diff 48815.Apr 22 2019, 7:53 PM
epriestley requested review of this revision.Apr 22 2019, 7:53 PM
epriestley added inline comments.Apr 22 2019, 8:31 PM
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
210–216

This change moots this comment too, but it gets nuked in the next change.

epriestley added a child revision: D20462: When applying transactions, acquire a read lock sooner.Apr 22 2019, 10:26 PM
amckinley accepted this revision.Apr 23 2019, 5:49 PM
This revision is now accepted and ready to land.Apr 23 2019, 5:49 PM
Closed by commit rP42c02557e4e3: Remove all remaining readers and writers for TABLE_COMMIT (authored by epriestley). · Explain WhyApr 24 2019, 12:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
8 lines
5 lines
repository/
worker/
commitmessageparser/
7 lines

Diff 48835

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/storage/DifferentialSchemaSpec.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility