Page MenuHomePhabricator

To improve wrapping behavior of rendered README files, don't use "PHUIDocumentView" in Diffusion

Authored by epriestley on May 21 2019, 1:35 PM.



See PHI1268. We currently do some weird width handling when rendering Diffusion readmes in a document directory view.

I think this came from D12330, which used PHUIDocumentViewPro to change the font, but we later reverted the font and were left with the DocumentView. Other changes after that modified DocumentView to have fixed-width behavior, but it doesn't make much sense here since the content panel is clearly rendered full-width.

Today, the DocumentView is a more structural element with methods like setCurtain(). Just get rid of it to simplify things, at least as a first step.

Test Plan



Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 21 2019, 1:35 PM
epriestley requested review of this revision.May 21 2019, 1:36 PM
amckinley accepted this revision.May 21 2019, 5:05 PM
This revision is now accepted and ready to land.May 21 2019, 5:05 PM