Page MenuHomePhabricator

To improve wrapping behavior of rendered README files, don't use "PHUIDocumentView" in Diffusion
ClosedPublic

Authored by epriestley on May 21 2019, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 3:11 PM
Unknown Object (File)
Sun, Mar 31, 11:21 AM
Unknown Object (File)
Fri, Mar 29, 6:50 PM
Unknown Object (File)
Fri, Mar 29, 3:26 AM
Unknown Object (File)
Mar 10 2024, 12:35 AM
Unknown Object (File)
Feb 6 2024, 9:17 PM
Unknown Object (File)
Jan 1 2024, 5:02 PM
Unknown Object (File)
Dec 28 2023, 4:44 PM
Subscribers
None

Details

Summary

See PHI1268. We currently do some weird width handling when rendering Diffusion readmes in a document directory view.

I think this came from D12330, which used PHUIDocumentViewPro to change the font, but we later reverted the font and were left with the DocumentView. Other changes after that modified DocumentView to have fixed-width behavior, but it doesn't make much sense here since the content panel is clearly rendered full-width.

Today, the DocumentView is a more structural element with methods like setCurtain(). Just get rid of it to simplify things, at least as a first step.

Test Plan

Before:

Screen Shot 2019-05-21 at 6.25.59 AM.png (890×1 px, 194 KB)

After:

Screen Shot 2019-05-21 at 6.30.04 AM.png (777×2 px, 239 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable