Page MenuHomePhabricator

Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class
ClosedPublic

Authored by epriestley on May 9 2019, 6:14 PM.

Details

Summary

Ref T5378. This class was renamed more than a year ago, in D19087. Remove the leftover compatiblity layer.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 9 2019, 6:14 PM
epriestley requested review of this revision.May 9 2019, 6:15 PM
amckinley accepted this revision.May 16 2019, 12:57 PM

I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.

This revision is now accepted and ready to land.May 16 2019, 12:57 PM

Oh, the relevance is that PhabricatorDatasourceEngineExtension now handles "doing magic stuff when you type things into the global search bar" (like jumping to a task when you type T123), and the next change was making "type a URI" mean "navigate to that uri" -- which got a mention in T5378, although it isn't the primary focus of that task.