Page MenuHomePhabricator

Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class
ClosedPublic

Authored by epriestley on May 9 2019, 6:14 PM.
Tags
None
Referenced Files
F18042669: D20509.id48938.diff
Sun, Aug 3, 5:07 AM
Unknown Object (File)
Jun 28 2025, 9:13 PM
Unknown Object (File)
Jun 5 2025, 4:23 PM
Unknown Object (File)
May 27 2025, 4:15 AM
Unknown Object (File)
May 8 2025, 10:51 AM
Unknown Object (File)
May 4 2025, 11:12 AM
Unknown Object (File)
Apr 27 2025, 1:04 AM
Unknown Object (File)
Apr 23 2025, 12:28 PM
Subscribers
None

Details

Summary

Ref T5378. This class was renamed more than a year ago, in D19087. Remove the leftover compatiblity layer.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.

This revision is now accepted and ready to land.May 16 2019, 12:57 PM

Oh, the relevance is that PhabricatorDatasourceEngineExtension now handles "doing magic stuff when you type things into the global search bar" (like jumping to a task when you type T123), and the next change was making "type a URI" mean "navigate to that uri" -- which got a mention in T5378, although it isn't the primary focus of that task.