Paths

Table of Contentst

Differential D20509

Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class
ClosedPublic
Actions

Authored by epriestley on May 9 2019, 6:14 PM.

Tags

None

Referenced Files

	F14075355: D20509.diff
	Thu, Nov 21, 10:48 AM

	Unknown Object (File)
	Sun, Nov 17, 7:11 AM

	Unknown Object (File)
	Mon, Oct 28, 6:51 PM

	Unknown Object (File)
	Wed, Oct 23, 8:32 PM

	Unknown Object (File)
	Oct 18 2024, 3:10 AM

	Unknown Object (File)
	Oct 9 2024, 12:20 PM

	Unknown Object (File)
	Sep 6 2024, 6:23 AM

	Unknown Object (File)
	Sep 4 2024, 11:04 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does)

Summary

Ref T5378. This class was renamed more than a year ago, in D19087. Remove the leftover compatiblity layer.

Test Plan

grep

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 9 2019, 6:14 PM

Harbormaster completed remote builds in B22775: Diff 48902.May 9 2019, 6:15 PM

epriestley requested review of this revision.May 9 2019, 6:15 PM

epriestley edited the summary of this revision. (Show Details)May 9 2019, 6:21 PM

epriestley added a task: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

epriestley added a child revision: D20510: When a user pastes a Phabricator URI into the search box, redirect to the URI.May 9 2019, 6:23 PM

I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.

This revision is now accepted and ready to land.May 16 2019, 12:57 PM

Oh, the relevance is that PhabricatorDatasourceEngineExtension now handles "doing magic stuff when you type things into the global search bar" (like jumping to a task when you type T123), and the next change was making "type a URI" mean "navigate to that uri" -- which got a mention in T5378, although it isn't the primary focus of that task.

Closed by commit rPf2feb0378f54: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class (authored by epriestley). · Explain WhyMay 16 2019, 6:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rPf2feb0378f54: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

search/

engineextension/

PhabricatorQuickSearchEngineExtension.php

Diff 48938

src/__phutil_library_map__.php

Loading...

src/applications/search/engineextension/PhabricatorQuickSearchEngineExtension.php

Loading...