Page MenuHomePhabricator

Add a "sin()" function to charts
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:28 PM.
Tags
None
Referenced Files
F15447527: D20444.id48751.diff
Fri, Mar 28, 12:26 AM
F15445292: D20444.id.diff
Thu, Mar 27, 1:18 PM
F15444019: D20444.id48802.diff
Thu, Mar 27, 7:21 AM
F15443522: D20444.diff
Thu, Mar 27, 4:49 AM
F15437770: D20444.diff
Tue, Mar 25, 9:21 PM
F15425102: D20444.id48802.diff
Sun, Mar 23, 2:29 AM
F15422620: D20444.id.diff
Sat, Mar 22, 9:50 AM
F15420940: D20444.id48751.diff
Fri, Mar 21, 7:16 PM
Subscribers

Details

Summary

Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable