Page MenuHomePhabricator

Add a "sin()" function to charts
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:28 PM.
Tags
None
Referenced Files
F18849775: D20444.id48802.diff
Thu, Oct 30, 12:13 PM
F18829071: D20444.diff
Fri, Oct 24, 7:37 PM
F18765391: D20444.id.diff
Tue, Oct 7, 11:10 AM
F18763237: D20444.diff
Mon, Oct 6, 11:22 PM
F18694196: D20444.id48751.diff
Sep 27 2025, 2:45 AM
F18682295: D20444.diff
Sep 26 2025, 5:40 AM
F18669339: D20444.diff
Sep 24 2025, 8:07 PM
F18626251: D20444.diff
Sep 16 2025, 12:51 AM
Subscribers

Details

Summary

Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable