Page MenuHomePhabricator

Add a "sin()" function to charts
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 2:36 PM
Unknown Object (File)
Mon, May 19, 11:17 AM
Unknown Object (File)
Sun, May 18, 6:59 PM
Unknown Object (File)
Thu, May 8, 5:49 AM
Unknown Object (File)
Wed, May 7, 12:53 AM
Unknown Object (File)
Apr 15 2025, 3:47 PM
Unknown Object (File)
Apr 6 2025, 12:59 PM
Unknown Object (File)
Mar 28 2025, 12:26 AM
Subscribers

Details

Summary

Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable