Page MenuHomePhabricator

Add a "sin()" function to charts
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:28 PM.
Tags
None
Referenced Files
F15584755: D20444.diff
Thu, May 8, 5:49 AM
F15579649: D20444.diff
Wed, May 7, 12:53 AM
F15507012: D20444.id48751.diff
Tue, Apr 15, 3:47 PM
F15474849: D20444.diff
Apr 6 2025, 12:59 PM
F15447527: D20444.id48751.diff
Mar 28 2025, 12:26 AM
F15445292: D20444.id.diff
Mar 27 2025, 1:18 PM
F15444019: D20444.id48802.diff
Mar 27 2025, 7:21 AM
F15443522: D20444.diff
Mar 27 2025, 4:49 AM
Subscribers

Details

Summary

Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable