Page MenuHomePhabricator

Fix an issue where internal paging of notifications could fail if some notifications are not visible
ClosedPublic

Authored by epriestley on Apr 22 2019, 2:27 PM.
Tags
None
Referenced Files
F19511477: D20455.diff
Mon, Jan 12, 3:23 AM
F19511472: D20455.diff
Mon, Jan 12, 3:17 AM
F19511468: D20455.diff
Mon, Jan 12, 3:10 AM
F19455110: D20455.id48825.diff
Wed, Dec 31, 6:39 AM
F19453487: D20455.id48825.diff
Tue, Dec 30, 6:54 PM
F19439501: D20455.diff
Sun, Dec 28, 6:35 PM
F19339993: D20455.diff
Thu, Dec 25, 10:26 PM
F19303893: D20455.diff
Wed, Dec 24, 6:13 AM
Subscribers

Details

Summary

Ref T13266. See https://discourse.phabricator-community.org/t/notification-page-throws-unrecoverable-fatal-error/2651/.

The "notifications" query currently uses offset paging for no apparent reason (just a legacy issue?), so some of the paging code is only reachable internally.

  • Stop it from using offset paging, since modern cursor paging is fine here (and Feed has used cursor paging for a long time).
  • Fix the non-offset paging to work like Feed.

Also:

  • Remove a couple of stub methods with no callsites after cursor refactoring.
Test Plan
  • Set things up so I had more than 100 notifications and some in the first 100 were policy filtered, to reproduce the issue (I just made FeedStory return NO_ONE as a visibility policy).
  • Applied the patch, notifications now page cleanly.
  • Verified that "Next Page" took me to the right place in the result list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable