Page MenuHomePhabricator

Fix an issue where internal paging of notifications could fail if some notifications are not visible
ClosedPublic

Authored by epriestley on Apr 22 2019, 2:27 PM.
Tags
None
Referenced Files
F15461536: D20455.diff
Tue, Apr 1, 9:03 AM
F15456021: D20455.id48809.diff
Sun, Mar 30, 6:28 AM
F15455024: D20455.id48825.diff
Sat, Mar 29, 9:55 PM
F15446110: D20455.diff
Thu, Mar 27, 5:15 PM
F15438346: D20455.diff
Wed, Mar 26, 12:15 AM
F15395910: D20455.id.diff
Sun, Mar 16, 10:41 AM
F15393177: D20455.id48825.diff
Sat, Mar 15, 8:12 PM
F15382326: D20455.diff
Fri, Mar 14, 11:51 AM
Subscribers

Details

Summary

Ref T13266. See https://discourse.phabricator-community.org/t/notification-page-throws-unrecoverable-fatal-error/2651/.

The "notifications" query currently uses offset paging for no apparent reason (just a legacy issue?), so some of the paging code is only reachable internally.

  • Stop it from using offset paging, since modern cursor paging is fine here (and Feed has used cursor paging for a long time).
  • Fix the non-offset paging to work like Feed.

Also:

  • Remove a couple of stub methods with no callsites after cursor refactoring.
Test Plan
  • Set things up so I had more than 100 notifications and some in the first 100 were policy filtered, to reproduce the issue (I just made FeedStory return NO_ONE as a visibility policy).
  • Applied the patch, notifications now page cleanly.
  • Verified that "Next Page" took me to the right place in the result list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable