Differential D20469

Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions
ClosedPublic
Actions

Authored by epriestley on Apr 23 2019, 6:05 PM.

Details

Reviewers

Maniphest Tasks

T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time

Summary

Depends on D20468. Ref T13276. See PHI1008.

When a commit or revision "reverts <hash>", and that's the hash of a commit which has a revision, also write a "reverts" edge to the revision.

Test Plan

Created "reverts X" objects for:

a revision;
a commit;
a commit with a revision (both got marked properly).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 23 2019, 6:05 PM

Harbormaster completed remote builds in B22695: Diff 48823.Apr 23 2019, 6:07 PM

epriestley requested review of this revision.Apr 23 2019, 6:07 PM

epriestley added a child revision: D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).Apr 23 2019, 6:35 PM

amckinley accepted this revision.May 1 2019, 2:25 PM

This revision is now accepted and ready to land.May 1 2019, 2:25 PM

Closed by commit rPa78f141b3fa8: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>"… (authored by epriestley). · Explain WhyMay 1 2019, 4:47 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rPa78f141b3fa8: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>"….

epriestley mentioned this in D12634: Extend revert edges.May 19 2019, 7:43 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

29 lines

differential/

editor/

DifferentialTransactionEditor.php

18 lines

diffusion/

query/

DiffusionCommitRevisionQuery.php

70 lines

Diff 48876

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

View Options

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php

Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48876

src/applications/audit/editor/PhabricatorAuditEditor.php

src/applications/differential/editor/DifferentialTransactionEditor.php

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php

Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions
ClosedPublic
Actions

Revision Contents
Changeset List