Page MenuHomePhabricator
Differential D20469

Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions
ClosedPublic
Actions

Authored by epriestley on Apr 23 2019, 6:05 PM.
Tags
None
Referenced Files
F18226172: D20469.diff
Wed, Aug 20, 3:31 AM
F18100465: D20469.id.diff
Sat, Aug 9, 11:54 AM
F18047071: D20469.id48823.diff
Sun, Aug 3, 11:19 AM
Unknown Object (File)
Jun 18 2025, 2:46 PM
Unknown Object (File)
Jun 17 2025, 3:51 AM
Unknown Object (File)
Jun 16 2025, 12:20 AM
Unknown Object (File)
Jun 15 2025, 10:40 PM
Unknown Object (File)
Jun 5 2025, 4:21 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time
Summary

Depends on D20468. Ref T13276. See PHI1008.

When a commit or revision "reverts <hash>", and that's the hash of a commit which has a revision, also write a "reverts" edge to the revision.

Test Plan

Created "reverts X" objects for:

  • a revision;
  • a commit;
  • a commit with a revision (both got marked properly).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
29 lines
differential/
editor/
18 lines
diffusion/
query/
70 lines

Diff 48876

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitRevisionQuery.php

Loading...
Phabricator · Built by Phacility