Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
F15566699: D20440.id48795.diff
Thu, May 1, 10:17 PM
F15517434: D20440.id48745.diff
Sat, Apr 19, 3:11 AM
F15517431: D20440.id48795.diff
Sat, Apr 19, 3:10 AM
F15517430: D20440.id.diff
Sat, Apr 19, 3:10 AM
F15506676: D20440.diff
Tue, Apr 15, 1:17 PM
F15474221: D20440.id48745.diff
Sun, Apr 6, 6:42 AM
F15463432: D20440.id48745.diff
Apr 1 2025, 11:20 PM
F15461542: D20440.id.diff
Apr 1 2025, 9:08 AM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable