Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 2:47 PM
Unknown Object (File)
Wed, May 28, 2:33 PM
Unknown Object (File)
Tue, May 20, 12:29 PM
Unknown Object (File)
Mon, May 19, 3:30 PM
Unknown Object (File)
Fri, May 9, 5:39 PM
Unknown Object (File)
Fri, May 9, 7:08 AM
Unknown Object (File)
Wed, May 7, 3:11 PM
Unknown Object (File)
Wed, May 7, 3:11 PM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable