Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 15 2026, 8:35 AM
Unknown Object (File)
Apr 4 2026, 8:28 PM
Unknown Object (File)
Mar 23 2026, 11:37 AM
Unknown Object (File)
Mar 22 2026, 10:40 PM
Unknown Object (File)
Mar 9 2026, 6:12 PM
Unknown Object (File)
Jan 21 2026, 4:19 PM
Unknown Object (File)
Jan 19 2026, 7:55 PM
Unknown Object (File)
Jan 16 2026, 12:37 PM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable