Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
F18759931: D20440.id48745.diff
Mon, Oct 6, 6:53 AM
F18702705: D20440.id48795.diff
Sun, Sep 28, 1:05 AM
F18673865: D20440.id.diff
Thu, Sep 25, 12:22 PM
F18631632: D20440.diff
Tue, Sep 16, 3:58 PM
F18623985: D20440.diff
Mon, Sep 15, 6:21 PM
F18507403: D20440.id48795.diff
Sep 5 2025, 2:10 AM
F18264838: D20440.id.diff
Aug 22 2025, 11:25 AM
F18250451: D20440.diff
Aug 21 2025, 4:11 PM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable