Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
F18829161: D20440.diff
Oct 24 2025, 8:17 PM
F18824464: D20440.id.diff
Oct 23 2025, 3:51 PM
F18821688: D20440.diff
Oct 23 2025, 1:17 AM
F18759931: D20440.id48745.diff
Oct 6 2025, 6:53 AM
F18702705: D20440.id48795.diff
Sep 28 2025, 1:05 AM
F18673865: D20440.id.diff
Sep 25 2025, 12:22 PM
F18631632: D20440.diff
Sep 16 2025, 3:58 PM
F18623985: D20440.diff
Sep 15 2025, 6:21 PM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable