Page MenuHomePhabricator

Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button
ClosedPublic

Authored by epriestley on Thu, Apr 25, 3:11 PM.

Details

Reviewers
amckinley
Summary

If you edit an auth message in Auth > Customize Messages, then click "Show Details" in the transaction record, the resulting dialog uses the object's handle's URI to generate a "cancel" button.

Since these handles currently have no URI, the dialog currently has no cancel/done button to close it.

Test Plan

Edited an auth message, clicked "Show Details", was now able to click "Done" to close the dialog.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Apr 25, 3:11 PM
epriestley requested review of this revision.Thu, Apr 25, 3:13 PM
amckinley accepted this revision.Mon, Apr 29, 7:52 PM
This revision is now accepted and ready to land.Mon, Apr 29, 7:52 PM