Page MenuHomePhabricator
Feed Advanced Search

Yesterday

amckinley accepted D20202: Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them.
Wed, Feb 20, 11:00 PM
amckinley closed T5401: Record total time in queue for tasks as Resolved.
Wed, Feb 20, 10:56 PM · Daemons
amckinley committed rPabc26aa96f4c: Track total time from task creation to task archival (authored by amckinley).
Track total time from task creation to task archival
Wed, Feb 20, 10:44 PM
amckinley added a commit to T5401: Record total time in queue for tasks: rPabc26aa96f4c: Track total time from task creation to task archival.
Wed, Feb 20, 10:44 PM · Daemons
amckinley closed D20200: Track total time from task creation to task archival.
Wed, Feb 20, 10:44 PM
amckinley added inline comments to D20200: Track total time from task creation to task archival.
Wed, Feb 20, 10:42 PM
amckinley committed rPHUc6bd8315c188: Add milliseconds and microseconds to phutil_units (authored by amckinley).
Add milliseconds and microseconds to phutil_units
Wed, Feb 20, 10:40 PM
amckinley closed D20201: Add milliseconds and microseconds to phutil_units.
Wed, Feb 20, 10:40 PM
amckinley requested review of D20201: Add milliseconds and microseconds to phutil_units.
Wed, Feb 20, 10:37 PM
amckinley updated the summary of D20200: Track total time from task creation to task archival.
Wed, Feb 20, 10:37 PM
amckinley requested review of D20200: Track total time from task creation to task archival.

Can you take a quick look at this with the added UI changes?

Wed, Feb 20, 10:25 PM
amckinley updated the summary of D20200: Track total time from task creation to task archival.
Wed, Feb 20, 10:23 PM
amckinley updated the diff for D20200: Track total time from task creation to task archival.

Update unarchive, add code to daemon console to use this new data.

Wed, Feb 20, 10:21 PM
amckinley added inline comments to D20200: Track total time from task creation to task archival.
Wed, Feb 20, 10:10 PM
amckinley added inline comments to D20200: Track total time from task creation to task archival.
Wed, Feb 20, 10:03 PM
amckinley created P2114 (An Untitled Masterwork).
Wed, Feb 20, 9:03 PM
amckinley requested review of D20200: Track total time from task creation to task archival.
Wed, Feb 20, 7:20 PM
amckinley added a revision to T5401: Record total time in queue for tasks: D20200: Track total time from task creation to task archival.
Wed, Feb 20, 7:18 PM · Daemons
amckinley accepted D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context.
Wed, Feb 20, 6:11 PM
amckinley accepted D20197: In Differential, give the "moved/copied from" gutter a more clear visual look.
Wed, Feb 20, 6:09 PM
amckinley accepted D20196: Remove an old Differential selection behavior.
Wed, Feb 20, 6:08 PM
amckinley accepted D20199: Remove some ancient daemon log code.
Wed, Feb 20, 5:51 PM

Tue, Feb 19

amckinley accepted D20195: Tweak some display behaviors for indent indicators.
Tue, Feb 19, 11:33 PM
amckinley accepted D20194: Display some invisible/nonprintable characters in diffs by default.
Tue, Feb 19, 11:11 PM
amckinley accepted D20192: Correct various minor diff copy behaviors.
Tue, Feb 19, 10:50 PM
amckinley accepted D20191: Behold! Copy text from either side of a diff!.
Tue, Feb 19, 10:29 PM
amckinley awarded D20191: Behold! Copy text from either side of a diff! a Mountain of Wealth token.
Tue, Feb 19, 10:09 PM
amckinley accepted D20190: Disable the JSHint "function called before it is defined" and "unused parameter" warnings.
Tue, Feb 19, 9:27 PM
amckinley accepted D20189: Remove hidden zero-width spaces affecting copy behavior.
Tue, Feb 19, 9:26 PM
amckinley accepted D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers.
Tue, Feb 19, 9:19 PM
amckinley accepted D20187: Put some whitespace behaviors back, but only for "diff alignment", not display.
Tue, Feb 19, 9:06 PM
amckinley accepted D20185: Remove all whitespace options/configuration everywhere.
Tue, Feb 19, 8:21 PM
amckinley accepted D20182: Add Arcanist support for highlighting indent change intraline diffs.
Tue, Feb 19, 8:09 PM
amckinley added a comment to D20181: Render indent depth changes more clearly.

The "whitespace added" side of your screenshot looks a little weird. It would be nice to give the chevron the same amount of green background padding on both sides.

Tue, Feb 19, 8:03 PM
amckinley accepted D20181: Render indent depth changes more clearly.
Tue, Feb 19, 7:52 PM
amckinley accepted D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Tue, Feb 19, 7:13 PM
amckinley accepted D20178: Don't report search indexing errors to the daemon log except from "bin/search index".
Tue, Feb 19, 7:08 PM
amckinley accepted D20174: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT".
Tue, Feb 19, 6:41 PM
amckinley accepted D20173: Show user availability dots (red = away, orange = busy) in typeaheads, tokenizer tokens, and autocompletes.
Tue, Feb 19, 6:34 PM
amckinley accepted D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on.
Tue, Feb 19, 6:19 PM

Sat, Feb 16

amckinley accepted D20183: Clean up a couple of %Q issues in "Has Parents" task queries.
Sat, Feb 16, 4:29 PM

Fri, Feb 15

amckinley accepted D20170: When users follow an email login link but an install does not use passwords, try to get them to link an account.
Fri, Feb 15, 10:04 PM
amckinley accepted D20184: Clean up a couple more URI alter() calls.
Fri, Feb 15, 10:01 PM
amckinley accepted D20179: Give HarbormasterBuildUnitMessage a real Query class.
Fri, Feb 15, 9:12 PM
amckinley added a comment to D20180: Allow unit tests to have arbitrarily long names (>255 characters).

Can't wait for unit tests like

Fri, Feb 15, 9:02 PM
amckinley accepted D20172: In "arc diff", warn when some reviewers are away even if not everyone is away.

This is clearly the smallest possible change that fixes PHI810, but what would be cooler would be detecting "this revision is unapprovable because of the combination of current away statuses and review requirements" so we only show this message when it's definitely a problem. Don't we have most of that code server-side already for deciding when a revision has reached the "approved" status?

Fri, Feb 15, 9:00 PM
amckinley accepted D20175: Correct schema irregularities (including weird keys) with worker task tables.
Fri, Feb 15, 5:08 PM
amckinley accepted D20169: When users confirm Duo MFA in the mobile app, live-update the UI.
Fri, Feb 15, 4:59 PM
amckinley accepted D20177: Queue search indexing tasks at a new PRIORITY_INDEX, not PRIORITY_IMPORT.
Fri, Feb 15, 4:38 PM
amckinley accepted D20176: Fix a URI construction in remarkup macro/meme rules.
Fri, Feb 15, 4:37 PM
amckinley accepted D20165: Allow task statuses to specify that either "comments" or "edits" are "locked".
Fri, Feb 15, 4:37 PM
amckinley accepted D20164: Add a standalone view for the Maniphest task graph.
Fri, Feb 15, 3:23 PM

Thu, Feb 14

amckinley accepted D20163: Fix Content-Security-Policy headers on "Email Login" page.
Thu, Feb 14, 8:22 PM
amckinley accepted D20161: Add basic, rough support for changing field behavior based on object subtype.
Thu, Feb 14, 8:21 PM
amckinley accepted D20167: Allow a DAO object storage namespace to be forced to a particular value.
Thu, Feb 14, 7:48 PM
amckinley accepted D20155: Update "setQueryParam[s]()" calls in libphutil.
Thu, Feb 14, 7:45 PM
amckinley accepted D20154: Replace all "setQueryParam()" calls with "remove/replaceQueryParam()".
Thu, Feb 14, 7:42 PM
amckinley accepted D20153: Clean up final `setQueryParams()` callsites.
Thu, Feb 14, 7:32 PM
amckinley accepted D20151: Replace "URI->setQueryParams()" after initialization with a constructor argument.
Thu, Feb 14, 7:30 PM
amckinley accepted D20149: Introduce new PhutilURI API methods to move away from the ambiguity of the "set" operation.
Thu, Feb 14, 7:24 PM

Wed, Feb 13

amckinley accepted D20156: Don't try to publish build results to bare diffs.
Wed, Feb 13, 6:47 PM
amckinley accepted D20157: Fix specifications of some "Visual Only" elements.
Wed, Feb 13, 6:46 PM
amckinley accepted D20159: Raise a setup warning when locked configuration has a configuration value stored in the database.
Wed, Feb 13, 6:45 PM
amckinley accepted D20158: Rate limit attempts to add payment methods in Phortune.
Wed, Feb 13, 6:40 PM
amckinley accepted D20160: Bump the markup cache version for URI changes.
Wed, Feb 13, 6:38 PM
amckinley accepted D20162: Fix some "URI->alter(X, null)" callsites.
Wed, Feb 13, 6:38 PM

Tue, Feb 12

amckinley added a comment to D20149: Introduce new PhutilURI API methods to move away from the ambiguity of the "set" operation.

new PhutilURI('/x/?y=1', array('y' => 2));

Tue, Feb 12, 8:05 PM
amckinley accepted D20150: Replace "getRequestURI()->setQueryParams(array())" with "getPath()".
Tue, Feb 12, 7:29 PM
amckinley requested review of D20152: Expose DifferentialRevisionQuery's ability to search for revisions with draft authors.
Tue, Feb 12, 7:10 PM
amckinley accepted D20148: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error".
Tue, Feb 12, 7:09 PM
amckinley accepted D20147: Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1" parameters in the URI.
Tue, Feb 12, 6:49 PM

Mon, Feb 11

amckinley accepted D20146: Add version check whitelists for constants to the version compatibility lint rule.
Mon, Feb 11, 11:18 PM
amckinley accepted D20143: Let "phlog()" log Throwables.
Mon, Feb 11, 11:11 PM
amckinley accepted D20145: Make libphutil `utils.php` PHP version violations statically analyzable.
Mon, Feb 11, 11:09 PM
amckinley accepted D20144: Fix a remarkup rule for `[x](y)` links when "y" is the empty string.
Mon, Feb 11, 11:08 PM
amckinley accepted D20142: Let the top-level exception handler dump a stack trace if we reach debug mode before things go sideways.
Mon, Feb 11, 11:05 PM
amckinley accepted D20141: Replace "getQueryParams()" callsites in Phabricator.
Mon, Feb 11, 11:02 PM
amckinley added a comment to D20140: Use "phutil_string_cast()" in TypeaheadDatasource.

Mon, Feb 11, 9:36 PM
amckinley accepted D20140: Use "phutil_string_cast()" in TypeaheadDatasource.
Mon, Feb 11, 9:35 PM
amckinley accepted D20137: Try harder to present display/rendering exceptions to the user using standard exception handling.
Mon, Feb 11, 9:35 PM
amckinley added a comment to D20139: Introduce "phutil_string_cast()" to work around interesting choices in "(string)" behavior.

Do you have an example of phlog() misbehaving on arrays? I get tailored behavior in the simple case:

Mon, Feb 11, 9:21 PM
amckinley accepted D20136: Fix destructive representation of "?x=1&x=2" in PhutilURI so it can raise errors immediately.

It has taken some soul searching on my part to be ok with the fact that interleavings of appendQueryParam() and setQueryParam() are effectively changing the "type" of the key in question. I can't decide if it would make sense to change the code to do something like "if you're doing a set and you find some duplicate key names that you're going to blow away, decide that now is a good time to go through the rest of the params and blow away all the other dupes, except for the first one of each". That's probably even even more confusing though. Maybe the class could have a variable that can only be set on construction called $duplicate_keys_allowed or something, that would make append throw on duplicate key names? This is all probably overthinking things and the current implementation is fine, even though it doesn't feel like it's totally eliminating surprises.

Mon, Feb 11, 8:13 PM
amckinley accepted D20138: Improve top-level fatal exception handling in PHP 7+.

This is much better than having to tab over to the terminal where my nginx logs are scrolling when I'm fixing a fatal!

Mon, Feb 11, 7:34 PM
amckinley awarded D20138: Improve top-level fatal exception handling in PHP 7+ a Mountain of Wealth token.
Mon, Feb 11, 7:08 PM
amckinley accepted D20139: Introduce "phutil_string_cast()" to work around interesting choices in "(string)" behavior.
Mon, Feb 11, 7:06 PM
amckinley added a comment to D20136: Fix destructive representation of "?x=1&x=2" in PhutilURI so it can raise errors immediately.

Instead, it will return 'x[]' => '2'. That is, it has lost the PHP-specific notion of what x[]=1&x[]=2 means.

Mon, Feb 11, 6:17 PM
amckinley accepted D20135: Fix inverted check in audit triggers for "uninvolved owner".
Mon, Feb 11, 6:12 PM
amckinley accepted D20134: Allow typeaheads to pass nonscalar data to datasources.

Does it make any sense to change phutil_build_http_querystring to implement this this "if it's an object or an array, turn it into a JSON string" behavior?

Mon, Feb 11, 6:10 PM
amckinley added a comment to T11413: Support renaming Phacility instances.

This load chart for admin001, where steady state CPU load has dropped from ~20% to ~10%, suggests that the new scheme is legitimately more efficient and the deploy actually changed something:

Mon, Feb 11, 12:26 AM · Phacility

Sun, Feb 10

amckinley added a revision to T13249: 2019 Week 7 - 8 Bonus Content: Unknown Object (Differential Revision).
Sun, Feb 10, 10:51 PM · Plans
amckinley accepted D20055: Support EU domains for Mailgun API.
Sun, Feb 10, 9:59 PM

Fri, Feb 8

amckinley added a comment to D20132: Improve UI/UX when users try to add an invalid card with Stripe.

Is there some other abuse vector here I'm not aware of?

Fri, Feb 8, 10:26 PM
amckinley accepted D20131: When an edit overrides an object lock, note it in the transaction record.
Fri, Feb 8, 10:21 PM
amckinley added a comment to D20131: When an edit overrides an object lock, note it in the transaction record.

Wasn't there supposed to be an icon getting upstreamed in this revision? I can see the change to the celerity map but not the associated icon file.

Fri, Feb 8, 8:13 PM
amckinley accepted D20132: Improve UI/UX when users try to add an invalid card with Stripe.

Unrelated to this diff, but we rate limit users attempting to add new payment methods, right?

Fri, Feb 8, 7:36 PM

Thu, Feb 7

amckinley accepted D20130: When an Owners package accepts a revision, count that as an "involved owner" for the purposes of audit.
Thu, Feb 7, 11:29 PM
amckinley accepted D20129: When building audit queries, prefilter possible "authorPHID" values.
Thu, Feb 7, 11:24 PM
amckinley accepted D20127: Make "bin/audit delete" synchronize commit audit status, and improve "bin/audit synchronize" documentation.
Thu, Feb 7, 11:14 PM
amckinley accepted D20126: Support a wider range of "Audit" rules for Owners packages.
Thu, Feb 7, 11:04 PM
amckinley accepted D20124: Prepare owners package audit rules to become more flexible.
Thu, Feb 7, 10:17 PM