Page MenuHomePhabricator
Feed Advanced Search

Today

amckinley requested review of D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Wed, Jun 19, 10:21 PM
amckinley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Wed, Jun 19, 10:19 PM · EditEngine
D20594: Improve rendering of "default value changed" custom form transactions to at least have all the information is now accepted and ready to land.
Wed, Jun 19, 8:35 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

(Also, now that I've read PHI1312, I mind this^^ implementation less since that was the actual support request anyway).

Wed, Jun 19, 7:46 PM
D20593: Don't count "Cc: x@y.com" as a legitimate recipient if the user who has "x@y.com" attached to their account has not verified the address is now accepted and ready to land.
Wed, Jun 19, 7:27 PM
D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper) is now accepted and ready to land.

Do you think ( XXX-123 Order More Copier Paper ) is still a reasonable rendering if the parameter is something like ?download=123 and that means "Download Attached File 123" and clicking the link doesn't take you to XXX-123 at all?

Wed, Jun 19, 7:21 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

If it's the same thing, that seems possibly confusing (two different links have the same visual rendering).

Wed, Jun 19, 7:03 PM
amckinley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).

This is just short-circuiting the whole external object lookup process, right? Is it significantly more work to just fix the lookup process to preserve these fragments?

Wed, Jun 19, 6:40 PM
D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic is now accepted and ready to land.

👻

Wed, Jun 19, 5:42 PM

Yesterday

D20568: Parse remarkup tables with something like a real parser instead of regular expressions is now accepted and ready to land.

I'm a little worried about a Postel's Law-style HTML parser. Later on I can envision getting more strict about what we accept in the interest of delivering more precise error messages, which might break existing pages that previously worked just by accident. I guess if it ever comes to that, we can write a migration that warns installs about suddenly-malformed wiki pages.

Tue, Jun 18, 11:26 PM
D20573: When a user clicks a navigation link in a dialog, close the dialog is now accepted and ready to land.
Tue, Jun 18, 9:49 PM
D20584: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list is now accepted and ready to land.
Tue, Jun 18, 9:19 PM
D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser is now accepted and ready to land.
Tue, Jun 18, 9:08 PM
D20586: Fix missing link targets for "View Object" header buttons in HTML email is now accepted and ready to land.
Tue, Jun 18, 8:15 PM
D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X" is now accepted and ready to land.
Tue, Jun 18, 5:26 PM
D20588: In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException" is now accepted and ready to land.
Tue, Jun 18, 5:24 PM
D20587: Fix more "msort()" vs "msortv()" callsites is now accepted and ready to land.
Tue, Jun 18, 5:14 PM
amckinley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.

Is it expected that B22956 never completed?

Tue, Jun 18, 12:22 AM

Mon, Jun 17

D20578: Don't require users be logged in to access the Logout controller, so users with no Spaces can log out is now accepted and ready to land.
Mon, Jun 17, 8:22 PM
D20585: Fix another stray "msort()/msortv()" issue is now accepted and ready to land.
Mon, Jun 17, 8:19 PM
D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes is now accepted and ready to land.
Mon, Jun 17, 7:41 PM
D20582: Consider "msort()" on "PhutilSortVector" objects to be an error is now accepted and ready to land.
Mon, Jun 17, 7:40 PM
D20581: Respect repository identities when selecting author vs auditor actions is now accepted and ready to land.
Mon, Jun 17, 7:40 PM
D20570: Skip loading transaction handles in an old migration is now accepted and ready to land.
Mon, Jun 17, 7:39 PM
D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes is now accepted and ready to land.
Mon, Jun 17, 7:05 PM
D20580: When triggering audits, respect committer identities when importing commits is now accepted and ready to land.
Mon, Jun 17, 5:17 PM
D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT" is now accepted and ready to land.
Mon, Jun 17, 5:17 PM

Tue, Jun 4

D20566: Add a basic profiler to Herald transcripts is now accepted and ready to land.
Tue, Jun 4, 9:26 PM
amckinley awarded D20569: Differentiate Remarkup header sizes more clearly a Party Time token.
Tue, Jun 4, 9:18 PM
D20569: Differentiate Remarkup header sizes more clearly is now accepted and ready to land.
Tue, Jun 4, 9:18 PM

Sun, Jun 2

D20567: Add "bin/herald rule ..." to modify Herald rules from the CLI is now accepted and ready to land.
Sun, Jun 2, 8:33 AM
D20565: When a revision is closed, always promote it out of draft is now accepted and ready to land.
Sun, Jun 2, 8:28 AM

Thu, May 30

D20564: When triggering audits, count "Accepted" revisions as successfully reviewed is now accepted and ready to land.
Thu, May 30, 11:52 PM
D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order is now accepted and ready to land.
Thu, May 30, 11:50 PM
D20562: Require valid comments to contain at least one non-whitespace character is now accepted and ready to land.
Thu, May 30, 7:37 PM
D20561: Add a "View Task" button to HTML mail from Maniphest is now accepted and ready to land.

Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?

Thu, May 30, 7:06 PM
D20560: Clean up "phabricator.timezone" configuration instructions a little bit is now accepted and ready to land.
Thu, May 30, 7:03 PM
D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles"). is now accepted and ready to land.

¯\_(ツ)_/¯

Thu, May 30, 7:00 PM
amckinley updated the test plan for D20559: Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles")..
Thu, May 30, 7:00 PM

Tue, May 28

amckinley awarded D20558: Test for "CAN_INTERACT" on comment edits in a way that survives objects which only implement "CAN_VIEW" a Manufacturing Defect? token.
Tue, May 28, 5:20 PM

Sat, May 25

amckinley accepted D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior.
Sat, May 25, 3:41 PM

Thu, May 23

amckinley accepted D20554: Disable PHP config option "pcre.jit" to work around PCRE segfault after "fork()".
Thu, May 23, 11:58 PM
amckinley accepted D20551: Prevent editing and deleting comments in locked conversations.
Thu, May 23, 8:16 PM
amckinley accepted D20552: Fix a looping workflow when trying to submit a partially-effectless transaction group.
Thu, May 23, 8:11 PM
amckinley accepted D20553: Fix two straggling pagination issues in Drydock.
Thu, May 23, 8:10 PM
amckinley added a comment to D20550: Remove misleading reference to "search_documentfield" in documentation.

This looks good, except as you said, we can't land it until after we remove conpherence_index as well. Should I just approve it now and let it hang around in your unlanded revisions?

Thu, May 23, 5:28 PM
amckinley added a comment to D20549: Remove the "search_documentfield" table.

If we're trying to drop the MyISAM dependency, don't forget to update the quickstart when we're finished: https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/quickstart.sql$9727

Thu, May 23, 5:25 PM
amckinley accepted D20549: Remove the "search_documentfield" table.
Thu, May 23, 5:18 PM

Wed, May 22

amckinley accepted D20548: When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email.
Wed, May 22, 10:39 PM
amckinley accepted D20545: Drop the "update revision with commit diff" transaction if the revision is already closed.
Wed, May 22, 10:36 PM
amckinley accepted D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
Wed, May 22, 10:30 PM
amckinley accepted D20547: In the Herald test console, don't consider transactions that Herald rules applied.
Wed, May 22, 10:30 PM
amckinley accepted D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
Wed, May 22, 9:37 PM
amckinley added a comment to D20540: Stabilize sorting of feed stories with similar strength.

Reading PHI1222; nice catch!

Wed, May 22, 9:19 PM
amckinley accepted D20540: Stabilize sorting of feed stories with similar strength.
Wed, May 22, 9:18 PM
amckinley updated the summary of D20540: Stabilize sorting of feed stories with similar strength.
Wed, May 22, 9:15 PM

Tue, May 21

amckinley accepted D20506: Stack chart functions in a more physical way.
Tue, May 21, 10:56 PM
amckinley accepted D20504: Store charts earlier and build them out a little later.
Tue, May 21, 10:40 PM
amckinley accepted D20503: Automatically select the range for charts in a general way.
Tue, May 21, 10:30 PM
amckinley accepted D20502: Wrap "<min, max>" chart domain pairs in an "Interval" class.
Tue, May 21, 10:27 PM
amckinley accepted D20501: Provide chart function labels over the wire instead of making them up.
Tue, May 21, 9:38 PM
amckinley accepted D20500: Label important data on charts.
Tue, May 21, 9:36 PM
amckinley accepted D20496: Consolidate burndown logic into a "BurndownChartEngine".
Tue, May 21, 9:35 PM
amckinley accepted D20486: Replace the chart in Maniphest Reports with a chart driven by Facts.
Tue, May 21, 9:34 PM
amckinley accepted D20485: Add a rough "Chart" Dashboard Panel.
Tue, May 21, 8:36 PM
amckinley accepted D20483: Render charts from storage instead of just one ad-hoc hard-coded chart.
Tue, May 21, 8:28 PM
amckinley accepted D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.
Tue, May 21, 7:22 PM
amckinley accepted D20535: Support export of feed transactions to CSV/Excel/etc.
Tue, May 21, 7:21 PM
amckinley accepted D20534: Support filtering feed transactions by object type.
Tue, May 21, 7:20 PM
amckinley accepted D20538: Recognize self-URI links to Diffusion files and give them special rendering behavior.
Tue, May 21, 7:09 PM
amckinley accepted D20537: Support "none()" in Differential to find revisions with no (un-resigned) reviewers.
Tue, May 21, 6:44 PM
amckinley accepted D20533: Add support for querying feed transactions by author and date range.
Tue, May 21, 6:40 PM
amckinley accepted D20531: Build a rough transaction-level view of Feed.
Tue, May 21, 6:37 PM
amckinley accepted D20530: Add a 15-second timeout to external service calls to fill Doorkeeper link tags.
Tue, May 21, 5:55 PM
amckinley accepted D20528: Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules.
Tue, May 21, 5:54 PM
amckinley accepted D20529: Support timeouts in OAuth1Future.
Tue, May 21, 5:44 PM
amckinley accepted D20525: Fix an issue where handles could load with the incorrect viewer when building mail about changes to related objects.
Tue, May 21, 5:43 PM
amckinley accepted D20527: When an object is referenced by URI, treat it like a mention.
Tue, May 21, 5:30 PM
amckinley updated the summary of D20537: Support "none()" in Differential to find revisions with no (un-resigned) reviewers.
Tue, May 21, 5:07 PM
amckinley accepted D20536: To improve wrapping behavior of rendered README files, don't use "PHUIDocumentView" in Diffusion.
Tue, May 21, 5:05 PM

May 17 2019

amckinley accepted D20454: Separate the "configuration" and "evaluation" phases of chart functions.
May 17 2019, 4:07 PM
amckinley accepted D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully.
May 17 2019, 3:56 PM

May 16 2019

amckinley accepted D20522: Improve the performance of large remarkup documents with many complex rules.

I've been staring at this long enough that I can plausibly claim to understand how it works. Put this on the pile of "terrible interview questions that I'm sure someone somewhere is getting asked".

May 16 2019, 5:49 PM
amckinley accepted D20520: Add a "Published document changed" rule to Herald for Phriction documents.
May 16 2019, 4:22 PM
amckinley accepted D20495: Add a "Reports" menu item to Projects.
May 16 2019, 4:00 PM
amckinley accepted D20519: When using the Herald test console on a transactional object, guess a reasonable set of transactions to simulate.
May 16 2019, 1:12 PM
amckinley accepted D20493: Make branch status more clear on Diffusion branches view.
May 16 2019, 1:05 PM
amckinley updated the summary of D20493: Make branch status more clear on Diffusion branches view.
May 16 2019, 1:03 PM
amckinley accepted D20492: Add support for custom "Wait for Approval" instructions.
May 16 2019, 1:01 PM
amckinley accepted D20507: Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search".
May 16 2019, 12:59 PM
amckinley accepted D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.

I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.

May 16 2019, 12:57 PM
amckinley accepted D20477: Improve the performance of tab replacement in common cases.
May 16 2019, 12:53 PM

May 15 2019

amckinley accepted D20518: In Herald, save applied transaction PHIDs in the transcript and display them in the UI.
May 15 2019, 5:37 PM
amckinley accepted D20517: When viewing a workboard, only link to parent workboards in crumbs if parents have workboards.
May 15 2019, 2:03 PM
amckinley accepted D20498: Roughly support stacked area charts.
May 15 2019, 2:03 PM

May 14 2019

amckinley accepted D20497: Update D3 to the current version.
May 14 2019, 2:52 PM
amckinley accepted D20513: Don't mark subscribes/mentions as "Lock Overridden".
May 14 2019, 2:50 PM
amckinley accepted D20521: Remove WePay support from Phortune, and Restful/Httpful dependencies.

burnittotheground

May 14 2019, 2:48 PM
amckinley accepted D20508: Expose subscribers transaction data via Conduit "transaction.search".
May 14 2019, 2:38 PM
amckinley accepted D20494: Fix a potential double-prompt in "arc land" when landing with ongoing builds.
May 14 2019, 2:38 PM