Page MenuHomePhabricator
Feed Advanced Search

Yesterday

amckinley accepted D20467: Merge the "Herald" and "Owners" daemon workers into a single "Publish" worker.
Wed, Apr 24, 4:10 AM
amckinley accepted D20466: Show "hold reasons" on commit page, not on "Edit" page.
Wed, Apr 24, 1:01 AM
amckinley accepted D20465: Remove nearly all remaining references to "Autoclose".
Wed, Apr 24, 12:47 AM
amckinley accepted D20464: Remove "--force-autoclose" from "bin/repository reparse".
Wed, Apr 24, 12:32 AM
amckinley accepted D20463: Move "update related object after commit" to a separate worker in the task queue.
Wed, Apr 24, 12:32 AM

Tue, Apr 23

amckinley accepted D20462: When applying transactions, acquire a read lock sooner.
Tue, Apr 23, 8:03 PM
amckinley accepted D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Tue, Apr 23, 5:49 PM
amckinley accepted D20460: Change "Revision Close" story to use commit identities only with no fallback to commit data.
Tue, Apr 23, 5:48 PM
amckinley accepted D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Tue, Apr 23, 5:19 PM
amckinley added inline comments to D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Tue, Apr 23, 5:18 PM
amckinley accepted D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Tue, Apr 23, 5:14 PM
amckinley accepted D20457: Move BlameController away from ancient "TABLE_COMMIT".
Tue, Apr 23, 4:30 PM
amckinley accepted D20456: Fix "before/after" cursor paging for API call "feed.query".
Tue, Apr 23, 4:29 PM
amckinley accepted D20455: Fix an issue where internal paging of notifications could fail if some notifications are not visible.
Tue, Apr 23, 4:28 PM

Fri, Apr 19

remusvrm awarded Changelog a Like token.
Fri, Apr 19, 7:09 PM
amckinley committed rPde743326394b: Improve timeline rendering for old macros (authored by amckinley).
Improve timeline rendering for old macros
Fri, Apr 19, 1:25 AM
amckinley closed D20453: Improve timeline rendering for old macros.
Fri, Apr 19, 1:25 AM
amckinley accepted D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working.
Fri, Apr 19, 12:26 AM
amckinley requested review of D20453: Improve timeline rendering for old macros.
Fri, Apr 19, 12:19 AM
amckinley accepted D20446: Simplify implementation of "pure" Chart functions.
Fri, Apr 19, 12:07 AM

Thu, Apr 18

amckinley added inline comments to D20442: Select the domain (X-axis range) for charts before pulling data.
Thu, Apr 18, 11:42 PM
amckinley created Image Macro "gimli".
Thu, Apr 18, 11:41 PM
amckinley accepted D20445: Make chart function argument parsing modular/flexible with 900 pages of error messages.
Thu, Apr 18, 11:37 PM
amckinley accepted D20450: Simplify non-bare working copy rules for the new "git fetch" strategy.
Thu, Apr 18, 11:27 PM
amckinley accepted D20448: Don't warn that workboard columns need a name when editing milestone columns.
Thu, Apr 18, 4:40 PM
amckinley accepted D20447: Don't warn about a locked database value after users run "bin/auth lock".
Thu, Apr 18, 2:18 AM

Wed, Apr 17

amckinley added a comment to D20441: Separate chart functions into a class tree.

we can cache datasets by chart key very near the display layer

Wed, Apr 17, 11:29 PM
amckinley added a comment to D20446: Simplify implementation of "pure" Chart functions.

That screenshot produces quite the intense optical effect. I thought I was looking at moiré effect from a cellphone camera.

Wed, Apr 17, 11:20 PM
amckinley accepted D20444: Add a "sin()" function to charts.
Wed, Apr 17, 11:18 PM
amckinley accepted D20443: Add chart functions "x()" and "constant(3)".
Wed, Apr 17, 11:16 PM
amckinley accepted D20442: Select the domain (X-axis range) for charts before pulling data.
Wed, Apr 17, 11:01 PM
amckinley accepted D20441: Separate chart functions into a class tree.
Wed, Apr 17, 10:50 PM
amckinley accepted D20440: Fetch chart data via async request and redraw charts when the window is resized.

howneatisthat

Wed, Apr 17, 10:20 PM
amckinley accepted D20439: Support drawing multiple functions on the same chart.
Wed, Apr 17, 10:15 PM
amckinley accepted D20438: Fix negative chart values, add storage for charts.
Wed, Apr 17, 9:54 PM
amckinley added a comment to D20437: Hide revision dependency stories from feed/notifications.

A half-step might be to just silence "added a commit to" in all cases?

Wed, Apr 17, 9:40 PM
amckinley added a comment to D20437: Hide revision dependency stories from feed/notifications.

All the same underlying action:

Wed, Apr 17, 9:31 PM
amckinley accepted D20437: Hide revision dependency stories from feed/notifications.

I feel kinda similarly about getting a flurry of "added commit to TXXX" notifications that fire in addition to the "bob closed DXXX" notifications. We don't have the infrastructure to say stuff like "only hide this notification if the same action already generated a separate notification of type foo, do we?

Wed, Apr 17, 9:30 PM
amckinley awarded D20437: Hide revision dependency stories from feed/notifications a Baby Tequila token.
Wed, Apr 17, 9:27 PM
amckinley accepted D20436: Make the "git upload-pack" proxy more robust.
Wed, Apr 17, 9:26 PM
amckinley accepted D20435: In Git repositories, use "git symbolic-ref HEAD ..." to select the default branch.
Wed, Apr 17, 9:17 PM
amckinley accepted D20434: Update "Autoclose" documentation to focus on "Permanent Refs" instead.
Wed, Apr 17, 8:46 PM
amckinley accepted D20433: Deprecate "Track Only" in the Diffusion UI.
Wed, Apr 17, 8:24 PM
amckinley accepted D20432: Rename some internal "Autoclose" mentions to "Permanent Refs".
Wed, Apr 17, 8:11 PM
amckinley accepted D20429: When an invalid "constraints" parameter is provided to a "*.search" method, raise a more tailored error.
Wed, Apr 17, 8:10 PM
amckinley accepted D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.
Wed, Apr 17, 8:09 PM
amckinley accepted D20427: Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field.

I guess it's not worth cleaning this up and removing the class + DB rows since it's just a no-op now and shouldn't bother anyone.

Wed, Apr 17, 8:08 PM
amckinley accepted D20426: Expose repository ref rules via "diffusion.repository.search".
Wed, Apr 17, 8:06 PM
amckinley accepted D20425: Move the repository "Publishing" option to the "Basics" panel in repository management.
Wed, Apr 17, 7:58 PM
amckinley accepted D20424: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off".
Wed, Apr 17, 7:48 PM
amckinley added inline comments to D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.
Wed, Apr 17, 7:45 PM
amckinley accepted D20423: Rename most user-facing "Autoclose" strings to "Permanent Refs".
Wed, Apr 17, 7:43 PM
amckinley accepted D20422: Add "Fetch Rules" to observed Git repositories.
Wed, Apr 17, 7:13 PM
amckinley accepted D20421: When observing a repository in Git, just "fetch <url>" without worrying about the "origin" remote.
Wed, Apr 17, 6:56 PM
amckinley accepted D20420: Accept pushes with arbitrary Git refs.
Wed, Apr 17, 6:49 PM
amckinley accepted D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
Wed, Apr 17, 6:38 PM
amckinley accepted D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Wed, Apr 17, 6:29 PM
amckinley accepted D20417: Distinguish between "bad record format" and "bad record value" when validating Trigger rules.
Wed, Apr 17, 6:18 PM
amckinley committed rP0583f6dc50a8: Some formatting changes for showing auth provider config guidance (authored by amckinley).
Some formatting changes for showing auth provider config guidance
Wed, Apr 17, 6:08 PM
Herald updated subscribers of T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.
Wed, Apr 17, 6:08 PM · Auth, Security
amckinley closed D20400: Some formatting changes for showing auth provider config guidance.
Wed, Apr 17, 6:08 PM
amckinley accepted D20416: Improve trigger editor behavior when switching to/from tokenizers.
Wed, Apr 17, 6:03 PM
amckinley accepted D20415: Reduce drag-and-drop jank on dashboards.
Wed, Apr 17, 5:53 PM
amckinley accepted D20414: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages.
Wed, Apr 17, 5:51 PM
amckinley accepted D20413: Index and show Owners packages affected by Herald rules.
Wed, Apr 17, 5:44 PM
amckinley accepted D20412: Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs).
Wed, Apr 17, 5:37 PM
amckinley accepted D19746: Make the Harbormaster build plan edit engine forms configurable.
Wed, Apr 17, 5:33 PM

Fri, Apr 12

amckinley accepted D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.
Fri, Apr 12, 9:56 PM
amckinley accepted D20410: Remove legacy "DashboardInstall" table.
Fri, Apr 12, 9:47 PM
amckinley added inline comments to D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 9:47 PM
amckinley accepted D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Fri, Apr 12, 8:41 PM
amckinley accepted D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format.
Fri, Apr 12, 8:30 PM
amckinley accepted D20407: Convert dashboard read/display pathways to the new panel storage format.
Fri, Apr 12, 7:45 PM
amckinley accepted D20406: Modularize dashboard layout modes (one column, two columns, etc).
Fri, Apr 12, 7:38 PM
amckinley accepted D20405: Convert dashboard panel storage to a format which can handle duplicates.
Fri, Apr 12, 7:33 PM
amckinley accepted D20404: Fix a missing pht() in Ponder.
Fri, Apr 12, 2:33 PM

Thu, Apr 11

amckinley accepted D20403: Move Dashboards main edit flow to EditEngine.
Thu, Apr 11, 11:00 PM
amckinley accepted D20402: Modularize Dashboard transactions.
Thu, Apr 11, 10:05 PM
amckinley added inline comments to D20399: On panel pages, show where panels are used.
Thu, Apr 11, 9:58 PM
amckinley accepted D20399: On panel pages, show where panels are used.
Thu, Apr 11, 9:54 PM
amckinley accepted D20398: Index and surface usage sites for Dashboards.
Thu, Apr 11, 9:07 PM
amckinley updated the diff for D20400: Some formatting changes for showing auth provider config guidance.

Less el-autho.

Thu, Apr 11, 8:27 PM
amckinley added a comment to D20400: Some formatting changes for showing auth provider config guidance.

This probably adds bullets all over the place, i.e. not only if there are multiple items. Try creating a task with no title, for example?

Thu, Apr 11, 8:26 PM
amckinley updated the diff for D20400: Some formatting changes for showing auth provider config guidance.

Oh whoops, I was editing the PhabricatorAuthProvidersGuidanceEngineExtension in rSERVICES.

Thu, Apr 11, 8:23 PM
amckinley added inline comments to D20400: Some formatting changes for showing auth provider config guidance.
Thu, Apr 11, 8:18 PM
amckinley requested review of D20400: Some formatting changes for showing auth provider config guidance.
Thu, Apr 11, 8:17 PM
amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20400: Some formatting changes for showing auth provider config guidance.
Thu, Apr 11, 8:16 PM · Auth, Security
amckinley accepted D20397: When editing a tab panel from a dashboard, redirect back to the dashboard.
Thu, Apr 11, 6:52 PM
amckinley accepted D20396: On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links.
Thu, Apr 11, 6:16 PM
amckinley accepted D20393: Make the "Reply" and "Quote" Remarkup rules more similar.

I confess to skimming this because it's mostly code shuffling and also includes a convincing unit test.

Thu, Apr 11, 5:38 PM
amckinley accepted D20395: Remove very old "vsDiff" data from commit update / diff extraction pipeline.
Thu, Apr 11, 3:03 PM

Wed, Apr 10

amckinley committed rP0f9776fb58e2: Add a workflow and a new config option for locking authentication providers (authored by amckinley).
Add a workflow and a new config option for locking authentication providers
Wed, Apr 10, 11:15 PM
amckinley closed D20394: Add a workflow and a new config option for locking authentication providers.
Wed, Apr 10, 11:15 PM
amckinley updated the diff for D20394: Add a workflow and a new config option for locking authentication providers.

Requested changes.

Wed, Apr 10, 11:11 PM
amckinley added inline comments to D20394: Add a workflow and a new config option for locking authentication providers.
Wed, Apr 10, 11:11 PM
amckinley requested review of D20394: Add a workflow and a new config option for locking authentication providers.
Wed, Apr 10, 10:38 PM
amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20394: Add a workflow and a new config option for locking authentication providers.
Wed, Apr 10, 10:35 PM · Auth, Security
amckinley committed rP26ee9274ca21: Change docs to be consistent with script (authored by amckinley).
Change docs to be consistent with script
Wed, Apr 10, 7:38 PM
amckinley closed D20391: Change docs to be consistent with script.
Wed, Apr 10, 7:38 PM
amckinley added a comment to D20391: Change docs to be consistent with script.

Yeah, I mean, the reporter's not wrong...

Wed, Apr 10, 7:38 PM