(Also, now that I've read PHI1312, I mind this^^ implementation less since that was the actual support request anyway).
Do you think ( XXX-123 Order More Copier Paper ) is still a reasonable rendering if the parameter is something like ?download=123 and that means "Download Attached File 123" and clicking the link doesn't take you to XXX-123 at all?
If it's the same thing, that seems possibly confusing (two different links have the same visual rendering).
This is just short-circuiting the whole external object lookup process, right? Is it significantly more work to just fix the lookup process to preserve these fragments?
I'm a little worried about a Postel's Law-style HTML parser. Later on I can envision getting more strict about what we accept in the interest of delivering more precise error messages, which might break existing pages that previously worked just by accident. I guess if it ever comes to that, we can write a migration that warns installs about suddenly-malformed wiki pages.
Is it expected that B22956 never completed?
Mon, Jun 17
Tue, Jun 4
Sun, Jun 2
Thu, May 30
Shouldn't DifferentialTransactionEditor->buildMailBody() get an update to use this new API?
Tue, May 28
Sat, May 25
Thu, May 23
This looks good, except as you said, we can't land it until after we remove conpherence_index as well. Should I just approve it now and let it hang around in your unlanded revisions?
If we're trying to drop the MyISAM dependency, don't forget to update the quickstart when we're finished: https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/quickstart.sql$9727
Wed, May 22
Reading PHI1222; nice catch!
Tue, May 21
May 17 2019
May 16 2019
I've been staring at this long enough that I can plausibly claim to understand how it works. Put this on the pile of "terrible interview questions that I'm sure someone somewhere is getting asked".
I didn't go all the way down the rabbit hole on this, but it's not immediately obvious to me that this is actually relevant to T5378.