Page MenuHomePhabricator
Feed Advanced Search

Tue, Aug 13

jcox awarded Changelog a Love token.
Tue, Aug 13, 4:30 PM

Wed, Jul 24

amckinley accepted D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Wed, Jul 24, 3:43 PM
amckinley accepted D20674: Provide a basic detail view for user activity logs.
Wed, Jul 24, 2:18 AM
amckinley accepted D20671: Modularize user activity log message types.
Wed, Jul 24, 2:17 AM
amckinley accepted D20678: Contain fallout from overheating feed queries on user profile pages.
Wed, Jul 24, 2:14 AM

Mon, Jul 22

amckinley accepted D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Mon, Jul 22, 11:00 PM
amckinley accepted D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Mon, Jul 22, 10:59 PM

Jul 19 2019

amckinley accepted D20670: Remove explicit administrative actions from the user activity log.
Jul 19 2019, 9:45 PM
amckinley accepted D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".
Jul 19 2019, 9:44 PM
amckinley accepted D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Jul 19 2019, 9:43 PM
amckinley accepted D20667: Add a rate limit to requesting account recovery links from a given remote address.
Jul 19 2019, 9:42 PM
amckinley accepted D20666: Add a rate limit to generating new account recovery links for a given account.
Jul 19 2019, 9:41 PM
amckinley accepted D20665: Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both.
Jul 19 2019, 9:40 PM
amckinley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

Yeah -- I lean toward thinking that we probably should make bin/auth lock also lock the guidance messages too.

Jul 19 2019, 9:02 PM
amckinley accepted D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.
Jul 19 2019, 8:46 PM
amckinley accepted D20664: Give "Auth Messages" a view/detail state before users customize them.
Jul 19 2019, 8:24 PM
amckinley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

Are we worried about attackers changing the guidance to something like "To prove that your Phabricator account is in use, please email the following link to bob.hackerman@gmail.com and don't read the rest of this email"?

Jul 19 2019, 8:20 PM
amckinley accepted D20662: Move "Password Reset" email to "PeopleMailEngine".
Jul 19 2019, 8:00 PM
amckinley accepted D20661: Rename "pastebin" database to "paste".
Jul 19 2019, 2:41 AM

Jul 18 2019

amckinley accepted D20660: In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field.
Jul 18 2019, 5:27 PM
amckinley updated the task description for T13345: Ferret does not match documents with no title.
Jul 18 2019, 5:26 PM · Search
amckinley accepted D20658: Export "date" and "remarkup" custom fields to Excel + "zip" extension check.
Jul 18 2019, 4:14 PM

Jul 17 2019

amckinley added inline comments to D20659: Modularize auth provider configuration.
Jul 17 2019, 11:19 PM
amckinley requested review of D20659: Modularize auth provider configuration.
Jul 17 2019, 11:18 PM
amckinley accepted D20656: Make workboard real-time updates mostly work.

howneatisthat

Jul 17 2019, 10:42 PM
amckinley accepted D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 7:51 PM
amckinley accepted D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 7:44 PM
amckinley committed rP97c16997561b: Fix transaction title rendering for AuthenticationConfigs (authored by amckinley).
Fix transaction title rendering for AuthenticationConfigs
Jul 17 2019, 7:41 PM
amckinley closed D20655: Fix transaction title rendering for AuthenticationConfigs.
Jul 17 2019, 7:41 PM
amckinley requested review of D20655: Fix transaction title rendering for AuthenticationConfigs.
Jul 17 2019, 7:34 PM
amckinley accepted D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:53 PM

Jul 15 2019

amckinley committed rP2f313a0e0d55: Remove "unstable" status and T2784-specific warning message (authored by amckinley).
Remove "unstable" status and T2784-specific warning message
Jul 15 2019, 9:05 PM
amckinley closed D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:05 PM
amckinley requested review of D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:04 PM
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Am I going crazy, or do those methods only handle the "blob fetching" part of this equation? I was looking for examples of the "create a File, do a chunked upload, attach said File to an existing object" flow.

Jul 15 2019, 8:28 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

For uploading binary blobs, we'd do the reverse: have the client stream the blob into Files, then call an API method with a reference to the object.

Jul 15 2019, 8:16 PM · Restricted Project, Auth, Conduit
amckinley requested review of D20650: Add Ferret support to Paste.
Jul 15 2019, 7:44 PM
amckinley committed rP7852adb84bbe: Actually enforce auth.lock-config (authored by amckinley).
Actually enforce auth.lock-config
Jul 15 2019, 6:53 PM
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI, a subtask of T6755: Allow more granular configuration of `security.allow-outbound-http`, as Resolved.
Jul 15 2019, 6:53 PM · Security
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI as Resolved by committing rP7852adb84bbe: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM · Auth, Security
amckinley closed D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM
amckinley updated the diff for D20645: Actually enforce auth.lock-config.

Pop a dialog instead of navigating away.

Jul 15 2019, 6:51 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:50 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:37 PM

Jul 12 2019

amckinley accepted D20649: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined.
Jul 12 2019, 4:14 PM

Jul 11 2019

amckinley accepted D20648: Update one straggling "CAN_INTERACT" check in comment removal.
Jul 11 2019, 10:56 PM
amckinley accepted D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 10:52 PM
amckinley updated the test plan for D20645: Actually enforce auth.lock-config.
Jul 11 2019, 6:32 PM
amckinley updated the test plan for D20645: Actually enforce auth.lock-config.
Jul 11 2019, 6:31 PM
amckinley updated the summary of D20645: Actually enforce auth.lock-config.
Jul 11 2019, 6:31 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 11 2019, 5:15 PM
amckinley updated the diff for D20645: Actually enforce auth.lock-config.
  • Raise "editing while locked" errors in the transaction layer.
  • Changed controllers to catch errors and display them reasonably.
  • Warn users about locked config when editing existing provider:
  • When trying to save a provider when the config gets locked during an edit, show reasonable error:
Jul 11 2019, 5:14 PM

Jul 10 2019

amckinley committed rP2c435433e0db: Start fleshing out PhabricatorAuthProviderViewController (authored by amckinley).
Start fleshing out PhabricatorAuthProviderViewController
Jul 10 2019, 5:45 PM
amckinley closed D20646: Start fleshing out PhabricatorAuthProviderViewController.
Jul 10 2019, 5:45 PM
epriestley awarded D20646: Start fleshing out PhabricatorAuthProviderViewController a Pterodactyl token.
Jul 10 2019, 5:34 PM
amckinley updated the diff for D20646: Start fleshing out PhabricatorAuthProviderViewController.

Gate auto-login and trust emails.

Jul 10 2019, 5:31 PM
amckinley requested review of D20646: Start fleshing out PhabricatorAuthProviderViewController.
Jul 10 2019, 4:30 PM
amckinley planned changes to D20645: Actually enforce auth.lock-config.
Jul 10 2019, 4:29 PM
amckinley added a comment to D20645: Actually enforce auth.lock-config.

I was also looking for a way to still render the form, except with all the fields grayed out, since it isn't terribly user-friendly to make someone unlock the config just to see what it already says. This seems tricky though, since there's no AphrontFormView->getChildren() method I can iterate over to call setDisable(true) on.

Jul 10 2019, 3:16 PM
amckinley requested review of D20645: Actually enforce auth.lock-config.
Jul 10 2019, 3:07 PM
amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20645: Actually enforce auth.lock-config.
Jul 10 2019, 3:05 PM · Auth, Security

Jul 9 2019

amckinley created P2119 (An Untitled Masterwork).
Jul 9 2019, 6:51 PM
amckinley created P2118 (An Untitled Masterwork).
Jul 9 2019, 6:45 PM
amckinley awarded D20644: Improve coverage of remarkup "<table>" rule and fix some bad method calls a Baby Tequila token.
Jul 9 2019, 12:42 AM

Jul 5 2019

amckinley committed rP3c4322252513: Fix paging fatal with flagged objects (authored by amckinley).
Fix paging fatal with flagged objects
Jul 5 2019, 9:25 PM
amckinley closed D20642: Fix paging fatal with flagged objects.
Jul 5 2019, 9:25 PM
amckinley closed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()" as Resolved by committing rP3c4322252513: Fix paging fatal with flagged objects.
Jul 5 2019, 9:25 PM · Flags

Jul 4 2019

amckinley requested review of D20642: Fix paging fatal with flagged objects.
Jul 4 2019, 11:03 PM
amckinley added a comment to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".

Thanks for the report. Fixed in D20642, which may or may not land today because of the holiday.

Jul 4 2019, 11:02 PM · Flags
amckinley added a revision to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()": D20642: Fix paging fatal with flagged objects.
Jul 4 2019, 11:01 PM · Flags
amckinley claimed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 10:40 PM · Flags
amckinley added a comment to D20641: Add ferret support to Slowvote.

But we could also do it later.

Jul 4 2019, 1:37 AM

Jul 3 2019

amckinley requested review of D20641: Add ferret support to Slowvote.
Jul 3 2019, 11:17 PM
amckinley accepted D20640: Fix double-close on dialogs leading to Javascript console error.
Jul 3 2019, 6:57 PM

Jul 2 2019

amckinley accepted D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 11:31 PM
amckinley accepted D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 2 2019, 10:57 PM
amckinley accepted D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 10:56 PM
amckinley accepted D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 10:38 PM
amckinley accepted D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 9:57 PM
amckinley accepted D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 9:37 PM
amckinley accepted D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 8:37 PM
amckinley accepted D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 8:35 PM
amckinley accepted D20630: Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing.
Jul 2 2019, 7:25 PM
amckinley accepted D20629: Give the workboard "default" workflows more modern state handling.
Jul 2 2019, 7:13 PM
amckinley accepted D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 6:26 PM
amckinley updated the test plan for D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 5:50 PM
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

It's turtles all the way down. Computers don't work and all conventions and toolsets are fundamentally broken:

Jul 2 2019, 5:31 PM
amckinley accepted D20631: When parsing HTML in remarkup, always start a new tag when encountering "<".
Jul 2 2019, 5:25 PM

Jun 29 2019

amckinley accepted D20627: Remove property "id" from Workboard View controller.
Jun 29 2019, 9:26 PM
amckinley accepted D20626: Remove unused property "slug" from Workboard View controller.
Jun 29 2019, 9:25 PM
amckinley accepted D20625: Lightly modernize OAuth server application view pages.
Jun 29 2019, 9:25 PM
amckinley accepted D20624: Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button.
Jun 29 2019, 9:24 PM

Jun 28 2019

D20623: Fix the "x" link in tokenizer tokens incorrectly closing dialogs is now accepted and ready to land.

ayyyyy

Jun 28 2019, 7:37 PM

Jun 26 2019

amckinley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

cd provides "at least once" delivery guarantees.

Jun 26 2019, 12:13 AM · Daemons, Phacility

Jun 25 2019

D20620: When matching process titles, don't attempt a match if we're out of "argv" parts is now accepted and ready to land.
Jun 25 2019, 10:44 PM
D20619: Bump the remarkup cache version after JIRA/Asana rule changes is now accepted and ready to land.
Jun 25 2019, 8:32 PM
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

Oh, and this might be useful, but is probably less portable than just using ps.

Jun 25 2019, 8:31 PM
D20616: Make "PhutilProcessQuery" detection of overseer processes more robust is now accepted and ready to land.
  • The disk can be full, or read-only. Or become full later, including while the daemon is running.
    • Any of these policy/disk state problems can pass any effort we make to test them early, then fail after the process daemonizes, making it difficult to report the failure to the user.
Jun 25 2019, 8:29 PM
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

This whole series of changes is motivated by "a PID file was out of date because of a reboot, and we tried to kill some other random process", right? Was there anything else that PID file tracking wasn't doing correctly?

Jun 25 2019, 6:59 PM
D20617: Limit the read buffer size in `bin/storage dump` is now accepted and ready to land.
Jun 25 2019, 1:53 PM