Page MenuHomePhabricator
Feed Advanced Search

Yesterday

amckinley added inline comments to D19886: Track MFA "challenges" so we can bind challenges to sessions and support SMS and other push MFA.
Fri, Dec 14, 11:32 PM
amckinley accepted D19892: Fix weird gap/spacing on user "Manage" page.
Fri, Dec 14, 11:32 PM
amckinley requested review of D19891: Move admin promotions to modular transactions.
Fri, Dec 14, 11:28 PM
amckinley accepted D19888: Add a garbage collector for MFA challenges.

I don't want to go down a bike shedding path here, but I feel like keeping challenges for a ~week would put us in a better position the first time someone wants to debug this stuff.

Fri, Dec 14, 8:14 PM
amckinley accepted D19886: Track MFA "challenges" so we can bind challenges to sessions and support SMS and other push MFA.
Fri, Dec 14, 7:52 PM
amckinley committed rPd23cc4b862aa: Move user renames to modular transactions (authored by amckinley).
Move user renames to modular transactions
Fri, Dec 14, 12:48 AM
amckinley closed D19887: Move user renames to modular transactions.
Fri, Dec 14, 12:48 AM
amckinley added inline comments to D19887: Move user renames to modular transactions.
Fri, Dec 14, 12:47 AM
amckinley updated the diff for D19887: Move user renames to modular transactions.

Requested changes.

Fri, Dec 14, 12:46 AM
amckinley added inline comments to D19887: Move user renames to modular transactions.
Fri, Dec 14, 12:23 AM
amckinley requested review of D19887: Move user renames to modular transactions.
Fri, Dec 14, 12:22 AM

Thu, Dec 13

amckinley accepted D19884: Upgrade an old "weakDigest()" inside TOTP synchronization code.
Thu, Dec 13, 10:14 PM
amckinley accepted D19885: Require MFA implementations to return a formal result object when validating factors.
Thu, Dec 13, 9:17 PM
amckinley accepted D19883: Upgrade sessions digests to HMAC256, retaining compatibility with old digests.

Accepted assuming my inlines aren't actual issues.

Thu, Dec 13, 8:56 PM
amckinley accepted D19882: Fix construction of two new qsprintf() exceptions.
Thu, Dec 13, 7:49 PM
amckinley accepted D19881: Give sessions real PHIDs and slightly modernize session queries.
Thu, Dec 13, 7:48 PM
avivey awarded D19877: Move user approval to modular transactions a Like token.
Thu, Dec 13, 12:39 AM
amckinley accepted D19879: Completely remove "LiskDAOSet" and "loadRelatives/loadOneRelative".
Thu, Dec 13, 12:28 AM
amckinley accepted D19878: Remove all application callers to "putInSet()".
Thu, Dec 13, 12:27 AM
amckinley committed rPaba99459238f: Move user approval to modular transactions (authored by amckinley).
Move user approval to modular transactions
Thu, Dec 13, 12:12 AM
amckinley closed D19877: Move user approval to modular transactions.
Thu, Dec 13, 12:12 AM
amckinley updated the diff for D19877: Move user approval to modular transactions.

Move logging in PhabricatorUserDisableTransaction.

Thu, Dec 13, 12:08 AM
amckinley updated the diff for D19877: Move user approval to modular transactions.

Override requireCapabilities to correctly check permissions.

Thu, Dec 13, 12:07 AM
amckinley added a comment to D19877: Move user approval to modular transactions.

Also note that this is a slight behavior change, because it is now possible to "unapprove" an already-approved user (primarily by using Conduit). The effects of this change are left as an exercise for the reader, but PhabricatorPeopleDisableController, for example, won't let you disable a user that has already been approved.

Thu, Dec 13, 12:00 AM

Wed, Dec 12

amckinley accepted D19876: Remove application callsites to "LiskDAO->loadOneRelative()".
Wed, Dec 12, 11:57 PM
amckinley accepted D19874: Remove application callers to "LiskDAO->loadRelatives()".
Wed, Dec 12, 11:54 PM
amckinley added inline comments to D19877: Move user approval to modular transactions.
Wed, Dec 12, 11:53 PM
amckinley added inline comments to D19877: Move user approval to modular transactions.
Wed, Dec 12, 11:52 PM
amckinley requested review of D19877: Move user approval to modular transactions.
Wed, Dec 12, 11:52 PM
amckinley committed rP5cb462d511c7: Show more of UTC offset when user's TZ is not an integer number of hours offset (authored by amckinley).
Show more of UTC offset when user's TZ is not an integer number of hours offset
Wed, Dec 12, 10:02 PM
amckinley closed D19873: Show more of UTC offset when user's TZ is not an integer number of hours offset.
Wed, Dec 12, 10:02 PM
amckinley updated the diff for D19873: Show more of UTC offset when user's TZ is not an integer number of hours offset.

Repeated code.

Wed, Dec 12, 10:02 PM
amckinley added a comment to D19873: Show more of UTC offset when user's TZ is not an integer number of hours offset.

New appearance:

Wed, Dec 12, 10:02 PM
amckinley updated the diff for D19873: Show more of UTC offset when user's TZ is not an integer number of hours offset.

Change format string to match "hours:minutes", rename variables for clarity.

Wed, Dec 12, 10:00 PM
amckinley requested review of D19873: Show more of UTC offset when user's TZ is not an integer number of hours offset.
Wed, Dec 12, 9:21 PM
amckinley accepted D19872: Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects.
Wed, Dec 12, 7:15 PM
amckinley accepted D19871: Fix an issue with item list view icon labels (including Differential date updated times) not appearing in the UI.
Wed, Dec 12, 7:04 PM
amckinley accepted D19870: Fix an issue with creating tasks directly into workboard columns.
Wed, Dec 12, 4:35 PM
amckinley accepted D19869: Fix some straggling qsprintf() warnings in repository import.
Wed, Dec 12, 4:34 PM
amckinley accepted D19868: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule.
Wed, Dec 12, 4:32 PM

Tue, Dec 11

amckinley accepted D19867: Make viewing a user's profile page clear notifications about that user.
Tue, Dec 11, 12:26 AM

Mon, Dec 10

amckinley accepted D19865: Remove obsolete "NotifyTest" feed story.
Mon, Dec 10, 11:36 PM
amckinley accepted D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only.
Mon, Dec 10, 11:36 PM
amckinley accepted D19858: Share more inline "Done" code between Differential and Diffusion.
Mon, Dec 10, 11:28 PM
amckinley accepted D19866: Add a CLI workflow for testing that notifications are being delivered.
Mon, Dec 10, 10:46 PM
amckinley committed rPda4341cf8be5: Make it less confusing to create root-level Phriction doc (authored by amckinley).
Make it less confusing to create root-level Phriction doc
Mon, Dec 10, 10:10 PM
amckinley closed D19863: Make it less confusing to create root-level Phriction doc.
Mon, Dec 10, 10:10 PM
amckinley accepted D19861: Update the "Notification Test" workflow to use more modern mechanisms.
Mon, Dec 10, 10:03 PM
amckinley updated the diff for D19863: Make it less confusing to create root-level Phriction doc.

Change variable name.

Mon, Dec 10, 10:00 PM
amckinley requested review of D19863: Make it less confusing to create root-level Phriction doc.
Mon, Dec 10, 9:46 PM
amckinley committed rP00a7071e2d1d: Fix handling of Phriction conduit edits (authored by amckinley).
Fix handling of Phriction conduit edits
Mon, Dec 10, 9:38 PM
amckinley closed D19862: Fix handling of Phriction conduit edits.
Mon, Dec 10, 9:38 PM
amckinley updated the diff for D19862: Fix handling of Phriction conduit edits.

Switch to strlen.

Mon, Dec 10, 9:37 PM
amckinley published a new version of Welcome.
Mon, Dec 10, 9:19 PM
amckinley renamed Welcome from saucey to 0.
Mon, Dec 10, 9:15 PM
amckinley renamed Welcome from Welcome to saucey.
Mon, Dec 10, 9:14 PM
amckinley requested review of D19862: Fix handling of Phriction conduit edits.
Mon, Dec 10, 8:54 PM
amckinley accepted D19860: Fix a bad method call signature throwing exceptions in newer Node.
Mon, Dec 10, 8:00 PM
amckinley accepted D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Mon, Dec 10, 7:58 PM
amckinley accepted D19859: When users mark their own inline comments as "Done", suppress the timeline/mail stories.
Mon, Dec 10, 7:27 PM
amckinley accepted D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask".
Mon, Dec 10, 7:17 PM
amckinley accepted D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options.
Mon, Dec 10, 7:07 PM
amckinley accepted D19856: Give "Autoclose Only" repository detail proper getters/setters.
Mon, Dec 10, 6:21 PM
amckinley accepted D19857: Give "Track Only" repository detail proper getters/setters.
Mon, Dec 10, 6:17 PM

Sat, Dec 8

amckinley accepted D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object.
Sat, Dec 8, 12:02 AM

Fri, Dec 7

amckinley accepted D19851: Add an "availaiblity" attachment for user.search.
Fri, Dec 7, 11:33 PM
amckinley accepted D19850: Allow "bin/repository thaw --demote" to demote an entire service, not just a single device.
Fri, Dec 7, 11:32 PM
amckinley accepted D19849: Allow "bin/repository thaw" to accept "--all-repositories" instead of a list of repositories.
Fri, Dec 7, 11:28 PM
amckinley accepted D19846: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates.
Fri, Dec 7, 10:25 PM
amckinley accepted D19845: Address a transaction issue with some audit actions not applying correctly.
Fri, Dec 7, 10:25 PM

Thu, Dec 6

amckinley accepted D19848: Support reading and querying Almanac service PHIDs via "diffusion.repository.search".
Thu, Dec 6, 12:36 AM
amckinley accepted D19847: Prevent Pygments from flying off the rails too aggressively.
Thu, Dec 6, 12:35 AM

Wed, Dec 5

amckinley accepted D19844: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3.
Wed, Dec 5, 4:36 PM

Wed, Nov 28

amckinley accepted D19843: Allow applications to require a High Security token without doing a session upgrade.
Wed, Nov 28, 7:09 PM
amckinley added a comment to D19843: Allow applications to require a High Security token without doing a session upgrade.

When you fix the error and submit again, you have to do another MFA check.

Wed, Nov 28, 7:07 PM
amckinley accepted D19842: Allow "Change Subtype" to be selected from the comment action stack.
Wed, Nov 28, 6:56 PM
amckinley accepted D19841: Add support for "harbormaster.target.search".
Wed, Nov 28, 6:43 PM
amckinley accepted D19839: Add a "touched paths" limit to repositories, limiting the maximum number of paths any commit may touch.
Wed, Nov 28, 6:40 PM
amckinley accepted D19834: Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned.
Wed, Nov 28, 6:30 PM
amckinley accepted D19831: Make the repository "Filesize Limit" and "Clone/Fetch Timeout" configurable in the UI.
Wed, Nov 28, 6:25 PM
amckinley accepted D19829: Modularize Repository transactions.

This was kinda big to review, so I read everything and then spot-checked some of the cut/paste changes from PhabricatorRepositoryEditor.php to make sure they ended up in the right places instead of exhaustively going back and forth.

Wed, Nov 28, 6:09 PM

Tue, Nov 27

amckinley accepted D19827: Separate the repository management UI into sections.
Tue, Nov 27, 3:38 PM
amckinley accepted D19826: Convert the "Repository Management" UI to a full-width, Phortune-style UI.
Tue, Nov 27, 12:30 AM

Mon, Nov 26

amckinley accepted D19837: Make a Feed query construction less clever/sneaky for new qsprintf() semantics.
Mon, Nov 26, 6:33 PM
amckinley accepted D19830: Pull Git filesize logic into a separate LowLevel query and use more Iterators.
Mon, Nov 26, 5:35 PM
amckinley accepted D19836: Don't allow the middle mouse button to start an inline comment.
Mon, Nov 26, 5:18 PM
amckinley accepted D19833: Remove defunct "metamta.herald.show-hints" Config option.
Mon, Nov 26, 4:51 PM
amckinley accepted D19835: Allow "Abandoned" revisions to be commandeered.
Mon, Nov 26, 4:50 PM
amckinley accepted D19832: Recover when cookies are disabled in Firefox and accessing localStorage throws.
Mon, Nov 26, 4:48 PM
amckinley accepted D19838: Fix an off-by-one error affecting mail rendering of inlines on the final line of a file.
Mon, Nov 26, 4:35 PM
amckinley accepted D19840: When the last rejecting reviewer resigns from a revision, return it to "Needs Review".
Mon, Nov 26, 4:32 PM

Fri, Nov 23

amckinley accepted D19828: Remove rendering support for very old Repository transactions.
Fri, Nov 23, 2:30 PM
amckinley accepted D19825: Expose "identifiers" as a query constraint for Commit search.
Fri, Nov 23, 2:24 PM

Tue, Nov 20

amckinley accepted D19824: When waiting for long-running Harbormaster futures to resolve, close idle database connections.
Tue, Nov 20, 10:09 PM
amckinley accepted D19823: Define "idle" connections that are safe to close (no transactions, no held locks).
Tue, Nov 20, 10:06 PM
amckinley accepted D19817: Support (but do not actually enable) a maximum file size limit for Git repositories.
Tue, Nov 20, 2:09 AM

Mon, Nov 19

amckinley added a comment to D19817: Support (but do not actually enable) a maximum file size limit for Git repositories.

Some testing comments:

  • Commits that touch a ton of files? I just wonder if there's any limit to the input that git diff-tree and git cat-file will accept.
  • Commits that delete files? Not sure if these commands do anything goofy on deleted files, and in theory they should still work since the underlying objects should still exist in the object DB. As a micro-optimization we could skip checking deletes entirely by (I think) checking the "change mode" output from git diff-tree.
  • Races on git repack? Are we worried about git commands that reorganize the object DB on disk running concurrently with these commands (see question about objectsize vs objectsize:disk).
Mon, Nov 19, 8:01 PM
amckinley accepted D19813: On the Diffusion cluster status page, improve device sort order.
Mon, Nov 19, 4:14 PM
amckinley accepted D19820: Fix some "%Q" behavior in PhortuneMerchantQuery.
Mon, Nov 19, 4:11 PM

Fri, Nov 16

amckinley accepted D19816: Unify intracluster sync and Drydock working copy construction timeouts as a repository "copy time limit".
Fri, Nov 16, 8:13 PM