Page MenuHomePhabricator

Make very minor generality improvements to the scope selector
ClosedPublic

Authored by epriestley on Apr 25 2019, 10:31 PM.
Tags
None
Referenced Files
F15397229: D20479.diff
Sun, Mar 16, 7:02 PM
F15369881: D20479.diff
Wed, Mar 12, 8:34 AM
F15335456: D20479.diff
Sat, Mar 8, 3:32 PM
F15311840: D20479.id48851.diff
Thu, Mar 6, 11:38 AM
Unknown Object (File)
Mar 1 2025, 2:52 PM
Unknown Object (File)
Mar 1 2025, 11:17 AM
Unknown Object (File)
Feb 15 2025, 1:22 AM
Unknown Object (File)
Feb 14 2025, 10:53 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI985. I think we pretty much need to start applying language-specific rules, but we can apply at least one more relatively language-agnostic rule: don't match lines which are indented 3+ levels.

In C++, we may have symbols like this:

class X {
  public:
    int m() { ... }
}

..but I believe no mainstream language puts symbol definitions 3+ levels deep.

Also clean up some of the tab handling very slightly.

Test Plan

Tests pass, looked at some C++ code and got slightly better (but still not great) matches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable