Page MenuHomePhabricator

Make very minor generality improvements to the scope selector
ClosedPublic

Authored by epriestley on Apr 25 2019, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Aug 5 2026, 8:10 PM
Unknown Object (File)
Jul 1 2026, 6:46 AM
Unknown Object (File)
Jun 21 2026, 2:28 AM
Unknown Object (File)
Jun 21 2026, 12:27 AM
Unknown Object (File)
Jun 20 2026, 8:09 PM
Unknown Object (File)
Apr 8 2026, 6:35 PM
Unknown Object (File)
Mar 30 2026, 9:49 PM
Unknown Object (File)
Mar 15 2026, 1:54 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI985. I think we pretty much need to start applying language-specific rules, but we can apply at least one more relatively language-agnostic rule: don't match lines which are indented 3+ levels.

In C++, we may have symbols like this:

class X {
  public:
    int m() { ... }
}

..but I believe no mainstream language puts symbol definitions 3+ levels deep.

Also clean up some of the tab handling very slightly.

Test Plan

Tests pass, looked at some C++ code and got slightly better (but still not great) matches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable