Page MenuHomePhabricator

Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working
ClosedPublic

Authored by epriestley on Apr 18 2019, 1:41 PM.
Tags
None
Referenced Files
F15369959: D20449.diff
Wed, Mar 12, 8:58 AM
F15360711: D20449.diff
Tue, Mar 11, 9:46 AM
F15342601: D20449.diff
Sun, Mar 9, 9:12 PM
F15312131: D20449.id48807.diff
Thu, Mar 6, 2:18 PM
F15311995: D20449.diff
Thu, Mar 6, 12:51 PM
Unknown Object (File)
Fri, Feb 14, 10:51 PM
Unknown Object (File)
Feb 9 2025, 7:40 AM
Unknown Object (File)
Feb 9 2025, 7:40 AM
Subscribers
None

Details

Summary

Ref T13279. Charting changes alter how the "line-chart" behavior works, but the "Burnup Chart" still relies on the old behavior.

Although I'm intending to remove "Maniphest > Reports" once Facts is a minimally sufficient replacement, copy this behavior to keep it working until we're ready to pull the trigger.

Also fix a leftover typo from D20435.

Test Plan

Viewed a legacy Maniphest burnup rate report.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
webroot/rsrc/js/application/maniphest/behavior-line-chart-legacy.js
10

Didn't review; assuming it's a faithful copy from the original.

This revision is now accepted and ready to land.Apr 19 2019, 12:26 AM
This revision was landed with ongoing or failed builds.Apr 19 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.