Page MenuHomePhabricator

Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working

Authored by epriestley on Apr 18 2019, 1:41 PM.



Ref T13279. Charting changes alter how the "line-chart" behavior works, but the "Burnup Chart" still relies on the old behavior.

Although I'm intending to remove "Maniphest > Reports" once Facts is a minimally sufficient replacement, copy this behavior to keep it working until we're ready to pull the trigger.

Also fix a leftover typo from D20435.

Test Plan

Viewed a legacy Maniphest burnup rate report.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 18 2019, 1:41 PM
epriestley requested review of this revision.Apr 18 2019, 1:43 PM
amckinley accepted this revision.Apr 19 2019, 12:26 AM
amckinley added inline comments.

Didn't review; assuming it's a faithful copy from the original.

This revision is now accepted and ready to land.Apr 19 2019, 12:26 AM
This revision was landed with ongoing or failed builds.Apr 19 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.