Page MenuHomePhabricator

Select the domain (X-axis range) for charts before pulling data
ClosedPublic

Authored by epriestley on Apr 17 2019, 1:09 PM.

Details

Summary

Depends on D20441. Ref T13279. Currently, we pull all the data, then decide what the X-axis should look like.

Since users will reasonably want to do stuff like "show me march-april 2018" in the future, we need to move toward flipping this around so that we can support cases where the domain is specified by the user.

For actual chart functions (like "constant(3)" or "cos(x)"), we must also know the domain before we pull data, since there are an infinite number of places where we can evaluate the function "constant(3)".

See note in T13279 about continunity.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 17 2019, 1:09 PM
epriestley requested review of this revision.Apr 17 2019, 1:10 PM
amckinley accepted this revision.Apr 17 2019, 11:00 PM
amckinley added inline comments.
src/applications/fact/controller/PhabricatorFactChartController.php
36

No setYAxis?

124–127

No list($domain_min, $domain_max)?

This revision is now accepted and ready to land.Apr 17 2019, 11:00 PM
epriestley added inline comments.Apr 18 2019, 8:07 PM
src/applications/fact/controller/PhabricatorFactChartController.php
36

What, you think I'm just made of axes over here? That axes grow on trees?

epriestley updated this revision to Diff 48797.Apr 18 2019, 8:08 PM
  • Small simplification.
This revision was automatically updated to reflect the committed changes.
amckinley added inline comments.Apr 18 2019, 11:42 PM
src/applications/fact/controller/PhabricatorFactChartController.php
36

Macro gimli:  AND MY AXIS