amckinley (Austin McKinley)Administrator


  • Clear sailing ahead.


  • Clear sailing ahead.


  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (355 w, 2 d)
Busy Busy until Dec 14.

Recent Activity

Tue, Dec 5

amckinley accepted D18819: Execute Herald again after promoting revisions out of the "Draft" state.
Tue, Dec 5, 5:13 PM
amckinley accepted D18818: Restore the "Log In" menubar action.
Tue, Dec 5, 5:02 PM
amckinley accepted D18817: Fix Mercurial commit history ordering.
Tue, Dec 5, 5:02 PM

Thu, Nov 30

amckinley accepted D18806: Rebuild the bulk editor on SearchEngine.
Thu, Nov 30, 11:26 PM
amckinley accepted D18805: Make bulk editor working set editable and more homogenous.

New interface looks great!

Thu, Nov 30, 10:59 PM
amckinley added a comment to D18812: Don't require the "gd" extension be installed in order to run unit tests.

I see a handful of other places where we use imagecreatefromstring(); should we be fixing those as well?

Thu, Nov 30, 9:51 PM
amckinley accepted D18810: Fix several safety issues with repository URIs.
Thu, Nov 30, 9:29 PM
amckinley accepted D18811: Fix an issue where Diffusion could fatal if the default branch was deleted.
Thu, Nov 30, 9:22 PM
amckinley accepted D18809: Mark `ParseError` as a PHP7 builtin class.
Thu, Nov 30, 7:30 PM
amckinley accepted D18808: Add an explicit warning in the Differential transaction log when users skip review.
Thu, Nov 30, 7:01 PM
amckinley accepted D18807: Make "arc land" prompt on "Changes Planned" revisions more explicit.
Thu, Nov 30, 6:58 PM

Tue, Nov 28

amckinley accepted D18802: Disallow "Accept" on drafts, allow "Resign".
Tue, Nov 28, 9:22 PM
amckinley accepted D18801: Make "first broadcast" rules for Differential drafts more general.
Tue, Nov 28, 9:21 PM
amckinley accepted D18784: Support "Set X to" as an action in Herald for tokenizer/datasource custom fields.
Tue, Nov 28, 9:19 PM
amckinley accepted D18797: Improve PHP7 error reporting for include-time syntax errors.
Tue, Nov 28, 5:54 PM
amckinley accepted D18793: Don't show personalized menu items until users establish a full session.
Tue, Nov 28, 5:47 PM
amckinley accepted D18792: Allow MFA enrollment before email verification.
Tue, Nov 28, 5:45 PM
amckinley accepted D18791: Tell users to "Wait Patiently" for admin account verification later in the registration process.
Tue, Nov 28, 1:52 AM
amckinley accepted D18790: Ask users to sign Legalpad documents before requiring they enroll in MFA.
Tue, Nov 28, 1:19 AM
amckinley accepted D18789: When requiring login signatures, order documents from oldest to newest.
Tue, Nov 28, 1:18 AM
amckinley accepted D18788: Refactor on-login Legalpad document signature requirement.
Tue, Nov 28, 1:17 AM
amckinley accepted D18786: Lightly modernize LegalpadDocumentSearchEngine.
Tue, Nov 28, 1:16 AM
amckinley accepted D18785: Lightly modernize LegalpadDocumentQuery.
Tue, Nov 28, 1:14 AM

Mon, Nov 27

amckinley accepted D18783: Hide archived projects only on workboards, not hovercards.
Mon, Nov 27, 10:15 PM

Wed, Nov 22

amckinley accepted D18782: Revert partial/nonfunctional OpenGraph support.
Wed, Nov 22, 11:08 PM
amckinley accepted D18781: Include OpenGraph prefix material in <html> tag if OpenGraph is enabled.
Wed, Nov 22, 7:35 PM
amckinley accepted D18778: Fix inbound mail handling for messages with no HTML body part.
Wed, Nov 22, 6:39 PM
amckinley accepted D18780: Add basic support for OpenGraph header tags for public installs.
Wed, Nov 22, 6:38 PM
amckinley accepted D18779: Fix a bad link target in Diffusion content search results.
Wed, Nov 22, 6:36 PM
amckinley accepted D18777: Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent.
Wed, Nov 22, 6:36 PM

Fri, Nov 17

amckinley added a comment to T13017: * TLS certificate expiration.

Fixed! Thanks again for the report.

Fri, Nov 17, 5:18 PM · Phacility, Ops
amckinley added a comment to T13017: * TLS certificate expiration.

Thanks; good catch. Fixing now.

Fri, Nov 17, 4:04 PM · Phacility, Ops

Thu, Nov 16

amckinley shifted T13017: * TLS certificate expiration from the Restricted Space space to the S1 Core space.
Thu, Nov 16, 8:50 PM · Phacility, Ops
amckinley created T13017: * TLS certificate expiration.
Thu, Nov 16, 8:42 PM · Phacility, Ops

Wed, Nov 15

amckinley committed rPbea45e90d324: Add yaml files to differential.whitespace-matters (authored by amckinley).
Add yaml files to differential.whitespace-matters
Wed, Nov 15, 7:57 PM
amckinley closed D18775: Add yaml files to differential.whitespace-matters.
Wed, Nov 15, 7:57 PM
amckinley requested review of D18775: Add yaml files to differential.whitespace-matters.
Wed, Nov 15, 7:51 PM
amckinley accepted D18774: Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline.
Wed, Nov 15, 5:35 PM

Tue, Nov 14

amckinley accepted D18772: Allow "arc diff --draft" to create revisions as drafts more forcefully.
Tue, Nov 14, 8:24 PM
amckinley accepted D18771: Restore "Summary" and "Test Plan" to initial mail for non-draft configurations.
Tue, Nov 14, 8:15 PM

Nov 10 2017

amckinley accepted D18769: Filter and reject "--config" and "--debugger" flags to Mercurial in any position.
Nov 10 2017, 4:33 PM

Nov 7 2017

amckinley accepted D18764: Refine bucketing and display rules for voided "Accepts" in Differential.


Nov 7 2017, 9:13 PM
amckinley accepted D18766: Properly exclude others' revisions from automatic "Depends On".
Nov 7 2017, 9:10 PM
amckinley accepted D18765: Include "Draft" revisions in Differential legacy status queries.
Nov 7 2017, 9:10 PM
amckinley accepted D18762: Provide revision parent/child edges in ``, and more information in ``.
Nov 7 2017, 9:08 PM
amckinley accepted D18761: Fill in some straightforward Maniphest transactions for ``.
Nov 7 2017, 9:07 PM

Nov 6 2017

amckinley accepted D18763: Remove some defunct old-style transaction policy checks.
Nov 6 2017, 7:10 PM

Nov 1 2017

amckinley accepted D18756: Denormalize Diff PHIDs onto Revisions.
Nov 1 2017, 8:53 PM
amckinley accepted D18757: After "Request Review", move revisions with voided "Accepts" into "Ready to Review", not "Waiting on Other Reviewers".
Nov 1 2017, 8:50 PM
amckinley accepted D18758: Don't include resigned reviewers in the Differential "To" list.
Nov 1 2017, 8:49 PM
amckinley accepted D18759: Fix some lint rendering issues when lines prior to other identical lines are removed.
Nov 1 2017, 8:49 PM

Oct 31 2017

amckinley accepted D18751: Fix an error with Remarkup when a header-indicator row has more cells than the one above it.
Oct 31 2017, 9:11 PM
amckinley accepted D18752: Fix a typo in JSON parser.
Oct 31 2017, 9:07 PM
amckinley accepted D18753: Fix an issue where the repository symbol index would incorrectly activate inside inline comments.
Oct 31 2017, 9:06 PM
amckinley accepted D18748: Clean up Differential draft mail behaviors.
Oct 31 2017, 7:40 PM
amckinley accepted D18749: Tweak padding/spacing on Diffusion blame view for profile pictures.
Oct 31 2017, 7:38 PM
amckinley accepted D18747: Show small author portraits in Diffusion blame view.
Oct 31 2017, 6:48 PM
amckinley accepted D18745: Don't run Herald build rules when Differential revisions are updated automatically.
Oct 31 2017, 6:10 PM
amckinley accepted D18746: Revert changes to Diffusion blame view.
Oct 31 2017, 6:08 PM
amckinley accepted D18737: Allow revisions to be held as drafts, even after builds finish.
Oct 31 2017, 2:48 PM

Oct 28 2017

amckinley accepted D18744: Provide "".
Oct 28 2017, 3:37 PM
amckinley accepted D18743: Add "arc diff --draft".
Oct 28 2017, 3:35 PM
amckinley accepted D18742: If possible, use "differential.revision.edit" in "arc diff".
Oct 28 2017, 3:31 PM
amckinley accepted D18741: Return transactions from "differential.parsecommitmessage".
Oct 28 2017, 3:30 PM
amckinley accepted D18740: Rename "arc diff --preview" to "arc diff --only".
Oct 28 2017, 3:29 PM
amckinley accepted D18739: Remove "arc diff --only".
Oct 28 2017, 3:29 PM
amckinley accepted D18738: Remove "arc diff --plan-changes".
Oct 28 2017, 3:28 PM
amckinley requested changes to D18737: Allow revisions to be held as drafts, even after builds finish.
Oct 28 2017, 3:27 PM

Oct 27 2017

amckinley accepted D18731: Don't run Herald build and mail rules when they don't make sense.
Oct 27 2017, 1:26 AM

Oct 26 2017

amckinley accepted D18736: Convert Ponder Questions to Ferret engine.
Oct 26 2017, 9:35 PM
amckinley accepted D18735: Add a missing key on DrydockLease.
Oct 26 2017, 9:34 PM
amckinley accepted D18734: Add a missing key to PhabricatorFile for destroying Files.
Oct 26 2017, 9:34 PM
amckinley accepted D18732: Add a missing `artifactIndex` key to HarbormasterBuildArtifact.

Unrelated to the revision itself, but this is weird:

Oct 26 2017, 9:33 PM
amckinley accepted D18733: Add a missing DaemonLogEvent key for garbage collection.
Oct 26 2017, 9:32 PM

Oct 25 2017

amckinley accepted D18730: Attribute revision promotion from "Draft" to "Needs Review" to the author.
Oct 25 2017, 4:14 PM

Oct 24 2017

amckinley accepted D18729: Fix a couple of other missing getApplicationTransactionCommentObject() implementations.
Oct 24 2017, 3:44 PM

Oct 23 2017

amckinley created Image Macro "moneyfire".
Oct 23 2017, 11:18 PM
amckinley accepted D18727: Simplify UNION/ORDER query construction in DifferentialRevisionQuery.
Oct 23 2017, 11:00 PM
amckinley accepted D18728: Clean up virtual "_ft_rank" column for query construction of Ferret objects.
Oct 23 2017, 11:00 PM
amckinley accepted D18724: Convert all "include_once" warnings into exceptions in all PHP versions.
Oct 23 2017, 5:50 PM
amckinley accepted D18723: Correct a method signature in DifferentialDraftField.
Oct 23 2017, 5:33 PM

Oct 21 2017

amckinley accepted D18722: Rewrite CommitQuery to use UNION for performance.
Oct 21 2017, 4:19 PM
amckinley accepted D18721: Simply how Differential drafts ignore Harbormaster autobuilds.
Oct 21 2017, 4:17 PM

Oct 20 2017

amckinley accepted D18717: Improve "refengine" performance for testing large numbers of Mercurial branches.


Oct 20 2017, 6:02 PM
amckinley accepted D18718: Add aural "+" and "-" hints to unified diffs for users who use screenreaders.

Is it possible for this to cause unexpected line wraps by overflowing the diff pane?

Oct 20 2017, 6:00 PM
amckinley accepted D18719: Remove obsolete instructions from information on prototype applications.
Oct 20 2017, 5:55 PM
amckinley accepted D18716: Correct some lint console renderer issues with files missing trailing newlines.
Oct 20 2017, 5:24 PM
amckinley accepted D18715: Fix an issue with attempting to index comments on packages.
Oct 20 2017, 4:03 PM

Oct 19 2017

amckinley accepted D18714: Show more detailed hints about draft revisions in the UI.

Otherwise looks good.

Oct 19 2017, 9:26 PM
amckinley accepted D18713: Start revisions in "Draft" if prototypes are enabled.
Oct 19 2017, 9:20 PM

Oct 17 2017

amckinley accepted D18712: Clarify acceptable values for `--threshold` in `search ngrams`.


Oct 17 2017, 9:30 PM
amckinley accepted D18711: Make "line" and "char" strictly optional in ArcanistLintMessage.
Oct 17 2017, 9:24 PM
amckinley accepted D18710: Parameterize the common ngrams threshold.
Oct 17 2017, 9:08 PM

Oct 14 2017

amckinley accepted D18708: Tweak rate limiting point counts for omnipotent users.
Oct 14 2017, 4:41 PM

Oct 13 2017

amckinley accepted D18707: Make `bin/storage dump` insert CREATE DATABASE and USE statements.
Oct 13 2017, 9:28 PM
amckinley accepted D18703: Modularize rate/connection limits in Phabricator.
Oct 13 2017, 7:50 PM
amckinley accepted D18702: Allow Phabricator to run with "enable_post_data_reading" disabled.
Oct 13 2017, 7:43 PM
amckinley accepted D18706: Allow duplicates and merged-in tasks to be queried with ``.
Oct 13 2017, 7:25 PM

Oct 12 2017

amckinley accepted D18704: Fix a bug which prevented Conduit futures from having parallelism limited effectively.
Oct 12 2017, 7:25 PM

Oct 11 2017

amckinley accepted D18701: Stream "multipart/form-data" file uploads to disk.

Do we currently write uploads to disk temporarily? I guess rate limiting will prevent this, but I'm worried this opens ourselves up to a DoS by filling disks (especially if there's a problem with S3 or whatever persistence layer that could cause these files to accumulate).

Oct 11 2017, 8:34 PM