amckinley (Austin McKinley)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (390 w, 5 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

amckinley created P2109 (An Untitled Masterwork).
Fri, Aug 17, 8:07 PM
amckinley added inline comments to D19587: Migrate DiffusionBlameController to use repo identities.
Fri, Aug 17, 7:58 PM
amckinley updated the diff for D19587: Migrate DiffusionBlameController to use repo identities.

Fix a problem with truncated tooltips by setting size to auto.

Fri, Aug 17, 7:41 PM
amckinley committed rP5c4c593af325: Update DiffusionLastModifiedController to use identities (authored by amckinley).
Update DiffusionLastModifiedController to use identities
Fri, Aug 17, 7:24 PM
amckinley added a commit to T12164: Put an indirection layer between author/committer strings and user accounts: rP5c4c593af325: Update DiffusionLastModifiedController to use identities.
Fri, Aug 17, 7:24 PM · Customer Impact, Diffusion (v3)
amckinley closed D19580: Update DiffusionLastModifiedController to use identities.
Fri, Aug 17, 7:24 PM
amckinley updated the summary of D19587: Migrate DiffusionBlameController to use repo identities.
Fri, Aug 17, 7:20 PM
amckinley updated the diff for D19587: Migrate DiffusionBlameController to use repo identities.

Use avatar.png as a default image for identities.

Fri, Aug 17, 7:17 PM
amckinley added a comment to D19580: Update DiffusionLastModifiedController to use identities.

Or possibly the renderName() logic can just move to Commit entirely, depending on how many callsites we're left with after converting things.

Fri, Aug 17, 6:58 PM
amckinley updated the diff for D19580: Update DiffusionLastModifiedController to use identities.
  • Migrate DiffusionBlameController to use repo identities
Fri, Aug 17, 6:58 PM
amckinley accepted D19595: Add more accessibility labels for screen readers.
Fri, Aug 17, 6:50 PM
amckinley accepted D19586: Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default.

Looks good other than minor inlines.

Fri, Aug 17, 5:38 PM
amckinley accepted D19594: Add some missing aural button labels for accessibility.
Fri, Aug 17, 5:20 PM

Thu, Aug 16

amckinley accepted D19593: Remove obsolete setup check call to Maniphest "Can Edit <X>" field checks.
Thu, Aug 16, 8:31 PM
amckinley accepted D19592: Give PhabricatorAuthPassword a formal CAN_EDIT policy.
Thu, Aug 16, 6:50 PM

Wed, Aug 15

amckinley accepted D19591: Fix Filesytem::walkToRoot() on Windows with default ("/") root.

Wed, Aug 15, 6:59 PM

Tue, Aug 14

amckinley accepted D19585: Move the "Can Lock Projects" check from requireCapabilities() to transaction validation.
Tue, Aug 14, 11:50 PM
amckinley requested review of D19587: Migrate DiffusionBlameController to use repo identities.
Tue, Aug 14, 11:47 PM
amckinley accepted D19584: Move the hierarchical edit policy check in Phriction from requireCapabilities() to validateTransactions().
Tue, Aug 14, 11:39 PM
amckinley accepted D19583: Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor.
Tue, Aug 14, 10:08 PM
amckinley accepted D19582: Remove pointless requireCapabilities() method from PhabricatorProjectColumnTransactionEditor.
Tue, Aug 14, 8:30 PM
amckinley accepted D19581: Remove deprecated Maniphest "Can Edit <Specific Property>" capabilities.

Hooray for red diffs!

Tue, Aug 14, 6:01 PM
amckinley added a comment to D19580: Update DiffusionLastModifiedController to use identities.

We could also consider just moving DiffusionView::renderName() into renderAuthor()/renderCommitter(), perhaps -- should be safe since the path which uses Identities definitely returns markup.

Tue, Aug 14, 5:55 PM
amckinley added a comment to D19580: Update DiffusionLastModifiedController to use identities.

I think the "Graph" tab may still use this, maybe check that?

Tue, Aug 14, 3:28 PM

Mon, Aug 13

amckinley requested review of D19580: Update DiffusionLastModifiedController to use identities.
Mon, Aug 13, 11:43 PM
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19580: Update DiffusionLastModifiedController to use identities.
Mon, Aug 13, 11:42 PM · Customer Impact, Diffusion (v3)
amckinley committed rPcc1def6ceaab: Remove some array typehints for passing around (authored by amckinley).
Remove some array typehints for passing around
Mon, Aug 13, 11:08 PM
amckinley closed D19578: Remove some array typehints for passing around.
Mon, Aug 13, 11:08 PM
amckinley accepted D19579: Allow "user.edit" to enable or disable users.
Mon, Aug 13, 10:52 PM
amckinley accepted D19577: Add a modern "user.edit" API method for users.
Mon, Aug 13, 10:47 PM
amckinley requested review of D19578: Remove some array typehints for passing around.
Mon, Aug 13, 10:39 PM
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19492: Start changing DiffusionCommitController to use identities.
Mon, Aug 13, 10:36 PM · Customer Impact, Diffusion (v3)
amckinley updated the summary of D19492: Start changing DiffusionCommitController to use identities.
Mon, Aug 13, 10:36 PM
amckinley added a comment to D19492: Start changing DiffusionCommitController to use identities.

The array typehint on $handles might eventually run into trouble because it might be a PhabricatorHandleList (an object which works like an array, but resolves lazily) sometimes. If you hit that, all you can do is remove the array typehint since there's no way to formally say array|PhabricatorHandleList.

Mon, Aug 13, 10:35 PM
epriestley awarded D19492: Start changing DiffusionCommitController to use identities a Piece of Eight token.
Mon, Aug 13, 10:35 PM
amckinley committed rP3b05e920e009: Start changing DiffusionCommitController to use identities (authored by amckinley).
Start changing DiffusionCommitController to use identities
Mon, Aug 13, 10:23 PM
amckinley closed D19492: Start changing DiffusionCommitController to use identities.
Mon, Aug 13, 10:23 PM
amckinley updated the diff for D19492: Start changing DiffusionCommitController to use identities.

Requested changes.

Mon, Aug 13, 10:20 PM
amckinley requested review of D19492: Start changing DiffusionCommitController to use identities.
Mon, Aug 13, 9:27 PM
amckinley accepted D19576: Move users to modular transactions.
Mon, Aug 13, 9:26 PM
amckinley closed T13185: AWS Reboots Part 2, Electric Boogaloo as Resolved.

Hahah you beat me to it!

Mon, Aug 13, 9:25 PM · Phacility, Ops
amckinley claimed T13183: AWS is rebooting instances in late August 2018.
Mon, Aug 13, 9:25 PM · Ops, Phacility
amckinley added a comment to T13185: AWS Reboots Part 2, Electric Boogaloo.

Same as T13183?

Mon, Aug 13, 9:24 PM · Phacility, Ops
amckinley updated the diff for D19492: Start changing DiffusionCommitController to use identities.

Try to isolate all the "if (hasIdentity)" logic in one place, and start using it.

Mon, Aug 13, 9:24 PM
amckinley accepted D19575: Remove 750ms timeout on owners path validation.
Mon, Aug 13, 7:48 PM
amckinley triaged T13185: AWS Reboots Part 2, Electric Boogaloo as Normal priority.
Mon, Aug 13, 7:47 PM · Phacility, Ops
amckinley accepted D19574: Make the Drydock repository operation page slightly richer.
Mon, Aug 13, 6:22 PM
amckinley accepted D19573: When cancelling addition of an Almanac interface, return to the Device page.
Mon, Aug 13, 6:20 PM
amckinley accepted D19572: Fix an issue with error handling when no mailers are available.
Mon, Aug 13, 6:20 PM
amckinley accepted D19571: In Differential standalone views, disable some keyboard shortcuts which don't work.
Mon, Aug 13, 3:51 PM

Fri, Aug 10

amckinley committed rPa6951a0a5aa0: Add migration to encourage rebuilding repository identities (authored by amckinley).
Add migration to encourage rebuilding repository identities
Fri, Aug 10, 8:48 PM
amckinley added a commit to T12164: Put an indirection layer between author/committer strings and user accounts: rPa6951a0a5aa0: Add migration to encourage rebuilding repository identities.
Fri, Aug 10, 8:47 PM · Customer Impact, Diffusion (v3)
amckinley closed D19497: Add migration to encourage rebuilding repository identities.
Fri, Aug 10, 8:47 PM
amckinley updated the diff for D19497: Add migration to encourage rebuilding repository identities.

Add limit.

Fri, Aug 10, 8:47 PM
epriestley awarded D19497: Add migration to encourage rebuilding repository identities a Hungry Hippo token.
Fri, Aug 10, 7:25 PM
amckinley updated the diff for D19497: Add migration to encourage rebuilding repository identities.

Switch bailout condition to look for commits, not users.

Fri, Aug 10, 7:23 PM
amckinley committed rP2951694c2737: Correctly spell 'committer' (authored by amckinley).
Correctly spell 'committer'
Fri, Aug 10, 12:54 AM
amckinley closed D19570: Correctly spell 'committer'.
Fri, Aug 10, 12:54 AM

Thu, Aug 9

epriestley awarded D19570: Correctly spell 'committer' a Pterodactyl token.
Thu, Aug 9, 8:33 PM
amckinley requested review of D19570: Correctly spell 'committer'.
Thu, Aug 9, 7:33 PM
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19497: Add migration to encourage rebuilding repository identities.
Thu, Aug 9, 7:32 PM · Customer Impact, Diffusion (v3)
amckinley updated the summary of D19497: Add migration to encourage rebuilding repository identities.
Thu, Aug 9, 7:32 PM
amckinley added a comment to D19497: Add migration to encourage rebuilding repository identities.

The setup issue message might be a little verbose? Let me know what you think.

Thu, Aug 9, 7:29 PM
amckinley retitled D19497: Add migration to encourage rebuilding repository identities from Add migration for creating repository identities to Add migration to encourage rebuilding repository identities.
Thu, Aug 9, 7:28 PM
amckinley updated the diff for D19497: Add migration to encourage rebuilding repository identities.

Rewrite migration to raise setup issue via manual activity.

Thu, Aug 9, 7:25 PM
amckinley created U41 Rebuild Repository Identities.
Thu, Aug 9, 7:05 PM
amckinley accepted D19568: In "bin/ssh-auth", cache a structure instead of a flat file because paths may change at runtime.
Thu, Aug 9, 3:22 PM
epriestley awarded T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018 a Party Time token.
Thu, Aug 9, 12:07 AM · Phacility, Ops
amckinley closed T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018 as Resolved.

This was more fun than expected. Notes for future historians:

Thu, Aug 9, 12:04 AM · Phacility, Ops

Wed, Aug 8

amckinley added a comment to T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018.

Doing this now.

Wed, Aug 8, 10:58 PM · Phacility, Ops
amckinley accepted D19569: Improve compatibility of "Config > Cache Status" across APCu versions.
Wed, Aug 8, 10:04 PM
amckinley accepted D19567: Fix truncation in "bin/storage probe" of tables larger than 100GB.
Wed, Aug 8, 4:42 PM
amckinley accepted D19566: Add an "--as" flag to "bin/conduit call ..." to improve flexibility and ease of profiling.
Wed, Aug 8, 4:41 PM
amckinley added a comment to T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018.

Sure, will do this afternoon.

Wed, Aug 8, 4:40 PM · Phacility, Ops

Fri, Aug 3

amckinley accepted D19565: In "--trace" output, print elapsed miliseconds for ballparking performance issues.
Fri, Aug 3, 10:56 PM
amckinley accepted D19564: Improve "--trace" behavior when output includes binary queries.
Fri, Aug 3, 10:53 PM
amckinley accepted D19563: Stop indexing the chunk data objects for large Files stored in multiple chunks.
Fri, Aug 3, 9:28 PM
amckinley accepted D19561: Consolidate redundant "should should" from some linter help strings in Arcanist.

Fri, Aug 3, 8:35 PM
amckinley accepted D19560: Add a "Last Edited" property to Wiki pages.
Fri, Aug 3, 8:34 PM
amckinley accepted D19562: Raise a tailored error when calling "transaction.search" with empty "phids" constraint.
Fri, Aug 3, 8:33 PM
amckinley added a comment to D19497: Add migration to encourage rebuilding repository identities.

I think the major downside is that we'll need to keep some if ($identity === null) { ... } cases in the frontend code for a while, but I think there isn't / won't be too much of this.

Fri, Aug 3, 6:52 PM
amckinley abandoned D19506: Add --quiet flag to rebuild-identities.

I tried to be clever and import the Linux git repo as a test case for this, but it took like a week on my laptop and almost exhausted my hard drive space.

Fri, Aug 3, 6:27 PM
amckinley created Image Macro "abandonship".
Fri, Aug 3, 6:26 PM

Thu, Aug 2

amckinley accepted D19559: Deprecate Conduit method "diffusion.getrecentcommitsbypath".
Thu, Aug 2, 11:58 PM
amckinley added inline comments to D19491: Attach identities to commits and users to identities.
Thu, Aug 2, 9:32 PM
amckinley added a comment to D19512: Add more detail when failing to fetch a huge repository.

Yeah I’m not wild about string matching. I was thinking about just adding an ‘exitStatus’ field to ‘CommandException’ and looking for the magic exit status, but that wasn’t obvious so I just kludged this together.

Thu, Aug 2, 9:30 PM

Wed, Aug 1

amckinley accepted D19557: Support querying Herald rules by monogram in typeahead datsources.
Wed, Aug 1, 10:54 PM
amckinley accepted D19556: Allow push events to be filtered by which Herald rule blocked the push.
Wed, Aug 1, 10:54 PM
amckinley accepted D19555: When a Herald rule blocks a push, show which rule fired in the push log UI.
Wed, Aug 1, 5:05 PM

Tue, Jul 31

amckinley accepted D19551: Put "Subprojects" on top of "Milestones" in the Project UI.
Tue, Jul 31, 5:57 PM
amckinley accepted D19554: Add Spaces information to the project list UI.
Tue, Jul 31, 4:46 PM
amckinley accepted D19553: Add Spaces support to Phriction.
Tue, Jul 31, 4:45 PM

Mon, Jul 30

amckinley accepted D19552: Add a more specific CSS rule to make Spaces headers in projects colored red.
Mon, Jul 30, 11:13 PM
amckinley accepted D19550: Improve Space behavior for subprojects and milestones.
Mon, Jul 30, 11:12 PM
amckinley accepted D19549: Add Spaces to Projects.
Mon, Jul 30, 11:10 PM
amckinley accepted D19547: Remove the execution time limit (if any) before sinking HTTP responses.
Mon, Jul 30, 5:53 PM

Sun, Jul 29

amckinley accepted D19546: Allow mailers to be explicitly marked as inbound or outbound.

What happens to an install that incorrectly configures these settings (all inbound disabled, all outbound disabled, etc)? Is it worth validating cluster.mailers and raising a setup issue?

Sun, Jul 29, 4:15 PM
amckinley accepted D19545: Count lines in build log slices more cheaply.

howneatisthat

Sun, Jul 29, 4:05 PM

Fri, Jul 27

amckinley accepted D19544: Make the "Is this JSON?" DocumentEngine heuristic a little tighter.
Fri, Jul 27, 6:43 PM
amckinley accepted D19543: Carry the "silent" transaction flag through inverse edge edits.
Fri, Jul 27, 6:41 PM