amckinley (Austin McKinley)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (378 w, 2 h)
Roles
Administrator
Availability
Busy Busy until May 28.

Recent Activity

Fri, May 18

amckinley accepted D19454: When database connection exceptions occur, raise them to the setup layer.
Fri, May 18, 1:14 AM

Wed, May 16

amckinley accepted D19453: When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines.

...it will only work when diffing diffs created after this goes live...

Wed, May 16, 5:33 PM
amckinley accepted D19452: Separate changeset analysis code from DifferentialDiff and provide a standalone `rebuild-changesets` workflow.

I only really looked at PhabricatorDifferentialRebuildChangesetsWorkflow, assuming that the other changes are just direct cut and pastes.

Wed, May 16, 5:26 PM
amckinley accepted D19451: Parse unusual Subversion protocol frames which contain extra whitespace.
Wed, May 16, 5:16 PM

Tue, May 15

amckinley added inline comments to D19446: Add workflow to create repository identities.
Tue, May 15, 5:42 PM
amckinley updated the diff for D19446: Add workflow to create repository identities.

Fix lint error, change help text.

Tue, May 15, 4:58 PM
amckinley retitled D19446: Add workflow to create repository identities from Big migration to attach identities to commit objects to Add workflow to create repository identities.
Tue, May 15, 4:55 PM
amckinley added inline comments to D19446: Add workflow to create repository identities.
Tue, May 15, 4:55 PM
amckinley updated the diff for D19446: Add workflow to create repository identities.

Remove migration, replace with workflow.

Tue, May 15, 2:29 AM

Mon, May 14

amckinley added a comment to D19446: Add workflow to create repository identities.

when we do the migration, basically just have it run bin/repository rebuild-identities --all

Mon, May 14, 7:29 PM
amckinley updated the diff for D19446: Add workflow to create repository identities.

switch to using PhabricatorQueryIterator; remove progress bar because we don't have access to the number of query results any more

Mon, May 14, 6:06 PM
amckinley accepted D19449: Fix a fatal during breadcrumb construction when viewing a dashboard you don't have permission to view.
Mon, May 14, 5:13 PM
amckinley accepted D19448: Consistently require MFA on the actual user creation flow.
Mon, May 14, 5:12 PM
amckinley accepted D19450: Add PhabricatorQueryIterator, for buffered iteration over a CursorPagedPolicyAwareQuery.

Cool, I'll update D19446.

Mon, May 14, 5:12 PM

Fri, May 11

amckinley added inline comments to D19446: Add workflow to create repository identities.
Fri, May 11, 5:47 PM
amckinley requested review of D19446: Add workflow to create repository identities.
Fri, May 11, 1:47 AM
amckinley added a dependent revision for D19443: Assign RepositoryIdentity objects to commits: D19446: Add workflow to create repository identities.
Fri, May 11, 1:46 AM
amckinley updated the diff for D19443: Assign RepositoryIdentity objects to commits.

Requested changes, fix formatting for transactions involving the "Explicitly Unassigned" state.

Fri, May 11, 1:37 AM

Thu, May 10

amckinley accepted D19445: Apply the new patch byte size limit to mail patch generation in Differential.
Thu, May 10, 7:21 PM
amckinley accepted D19444: Allow diff generation via ArcanistBundle to be limited to an approximate maximum byte size.
Thu, May 10, 7:20 PM
amckinley updated the diff for D19443: Assign RepositoryIdentity objects to commits.

whoops, wrong base revision

Thu, May 10, 5:37 AM
amckinley updated the diff for D19443: Assign RepositoryIdentity objects to commits.

fix search bug

Thu, May 10, 2:05 AM
amckinley updated the diff for D19443: Assign RepositoryIdentity objects to commits.

remove extra code

Thu, May 10, 1:55 AM
amckinley added inline comments to D19443: Assign RepositoryIdentity objects to commits.
Thu, May 10, 1:54 AM
amckinley requested review of D19443: Assign RepositoryIdentity objects to commits.
Thu, May 10, 1:46 AM
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19443: Assign RepositoryIdentity objects to commits.
Thu, May 10, 1:45 AM · Customer Impact, Diffusion (v3)
amckinley added a dependent revision for D19423: Begin building out RepositoryIdentity indirection layer: D19443: Assign RepositoryIdentity objects to commits.
Thu, May 10, 1:45 AM
amckinley added a dependent revision for D19429: Add controllers/search/edit engine functionality to RepositoryIdentity: D19443: Assign RepositoryIdentity objects to commits.
Thu, May 10, 1:45 AM
amckinley updated the diff for D19429: Add controllers/search/edit engine functionality to RepositoryIdentity.

remove ferret implementation

Thu, May 10, 1:02 AM

Wed, May 9

amckinley committed rP8ada2bc4fe74: (stable) Fix "Any Owner" and "No Owners" searches in Maniphest (authored by epriestley).
(stable) Fix "Any Owner" and "No Owners" searches in Maniphest
Wed, May 9, 10:08 PM
amckinley accepted D19442: Raise the intraline diff hard limit from 80 to 100 characters.
Wed, May 9, 8:37 PM
amckinley accepted D19440: Fix "Any Owner" and "No Owners" searches in Maniphest.
Wed, May 9, 8:23 PM
amckinley accepted D19438: Allow navigation breadcrumbs to be marked as "always visible" so they show up on phones.
Wed, May 9, 8:13 PM
amckinley accepted D19437: Fix "arc paste" to stop creating pastes with an empty string ("") as the "language".
Wed, May 9, 8:04 PM

Tue, May 8

amckinley accepted D19434: Export task point values as double, not int.
Tue, May 8, 6:50 PM

Mon, May 7

amckinley accepted D19433: Improve UI and documentation for "Ignore Attributes" in Owners slightly.
Mon, May 7, 11:26 PM
amckinley accepted D19432: Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hidden.
Mon, May 7, 11:24 PM
amckinley accepted D19431: Support an "Ancestors Of: ..." constraint in commit queries.
Mon, May 7, 11:24 PM

Sun, May 6

amckinley accepted D19430: Mention the "inline comments" rule in the callout for "Large" diffs.
Sun, May 6, 5:50 PM

Sat, May 5

amckinley requested review of D19429: Add controllers/search/edit engine functionality to RepositoryIdentity.
Sat, May 5, 3:25 AM
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19429: Add controllers/search/edit engine functionality to RepositoryIdentity.
Sat, May 5, 3:24 AM · Customer Impact, Diffusion (v3)
amckinley added a dependent revision for D19423: Begin building out RepositoryIdentity indirection layer: D19429: Add controllers/search/edit engine functionality to RepositoryIdentity.
Sat, May 5, 3:23 AM
amckinley accepted D19426: Prepare to support an "Ignore generated files" flag in Owners.
Sat, May 5, 2:22 AM
amckinley accepted D19428: Allow Owners packages to be configured to ignore generated paths in Differential.
Sat, May 5, 2:18 AM
amckinley accepted D19425: Classify changesets as "generated" at creation time, in addition to display time.
Sat, May 5, 2:13 AM
amckinley accepted D19427: Remove explicit "mailKey" from Owners packages.
Sat, May 5, 2:03 AM

Fri, May 4

amckinley accepted D19424: Omit "type" attribute from "<source />" tags in "<video>" to trick Chrome into playing them.

iiam

Fri, May 4, 4:27 PM

Tue, May 1

amckinley added inline comments to D19423: Begin building out RepositoryIdentity indirection layer.
Tue, May 1, 9:24 PM
amckinley added inline comments to D19423: Begin building out RepositoryIdentity indirection layer.
Tue, May 1, 9:19 PM
amckinley added inline comments to D19423: Begin building out RepositoryIdentity indirection layer.
Tue, May 1, 9:18 PM
amckinley requested review of D19423: Begin building out RepositoryIdentity indirection layer.
Tue, May 1, 8:37 PM
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19423: Begin building out RepositoryIdentity indirection layer.
Tue, May 1, 8:36 PM · Customer Impact, Diffusion (v3)
amckinley accepted D19420: Fix an issue where entering the same Owners path for two repositories would incorrectly de-dupe the path.
Tue, May 1, 4:26 PM
amckinley accepted D19421: Restore support for using "arc download" to fetch files with no "security.alternate-file-domain".
Tue, May 1, 4:26 PM
amckinley accepted D19419: Pass full Harbormaster URIs to Buildkite.
Tue, May 1, 1:01 AM
amckinley created P2102 migration.sql.
Tue, May 1, 12:27 AM
amckinley created P2101 (An Untitled Masterwork).
Tue, May 1, 12:26 AM
amckinley created P2100 (An Untitled Masterwork).
Tue, May 1, 12:03 AM

Mon, Apr 30

amckinley accepted D19416: Hide the "large" diff warning on "very large" diffs.
Mon, Apr 30, 7:28 PM
amckinley accepted D19414: Add a view option to disable blame in Diffusion and fix some view transition bugs.
Mon, Apr 30, 7:25 PM
amckinley accepted D19418: Stop computing ownership for changed paths for Very Large revisions.
Mon, Apr 30, 7:23 PM
amckinley committed rPdd6e82698aeb: More-robust search for task assignees (authored by amckinley).
More-robust search for task assignees
Mon, Apr 30, 7:18 PM
amckinley closed D19417: More-robust search for task assignees.
Mon, Apr 30, 7:18 PM
amckinley requested review of D19417: More-robust search for task assignees.
Mon, Apr 30, 7:13 PM
amckinley accepted D19413: Add a "Rule Detail" link to Herald email.
Mon, Apr 30, 12:47 AM

Fri, Apr 27

amckinley committed rP9a0dd55442d7: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults (authored by amckinley).
Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults
Fri, Apr 27, 11:56 PM
amckinley closed D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Fri, Apr 27, 11:56 PM
amckinley closed T13128: Phriction document header doesn't render policy strength variations as Resolved by committing rP9a0dd55442d7: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Fri, Apr 27, 11:56 PM · Policy, PHUI, Phriction
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

The other tests all look good. I'm going to land this soon unless you can think of anything else to test.

Fri, Apr 27, 11:53 PM
amckinley updated the diff for D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Change access modifier to avoid crashing.

Fri, Apr 27, 11:52 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Maybe destroy the Phriction root document with bin/remove destroy and see if that breaks anything? But I think you can't get there normally (we require /x/ exist before we'll let you create /x/y/) so whatever you hit might be pre-existing.

Fri, Apr 27, 11:51 PM
amckinley updated the diff for D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Remove unused CSS class.

Fri, Apr 27, 11:39 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

This change might be too big; I'm happy to refactor if you think so.

Fri, Apr 27, 11:36 PM
amckinley updated the diff for D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Migrate describeAutomaticCapability() to `getPolicySpecialRuleDescription().
Fix several bugs.
Refactor PhrictionDocumentPolicyCodex.
Add more explanatory text to policy explainer.

Fri, Apr 27, 11:36 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Can you give me some ideas for more stuff to test before landing this? Phriction and otherwise.

Fri, Apr 27, 9:22 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

I'd think I'd like to get rid of describeAutomaticCapability() eventually and make everything that wants to explain things implement a Codex instead

Fri, Apr 27, 7:47 PM
amckinley accepted D19412: Stop build target start times from being overwritten on reentry.
Fri, Apr 27, 7:25 PM
amckinley accepted D19411: Fix an issue where the Herald test console doesn't work with "Content source" rules.
Fri, Apr 27, 7:23 PM
amckinley added inline comments to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Fri, Apr 27, 7:17 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

However, I'm not sure users are actually confused by this today -- at least, not very often -- even though it seems like it should be kind of confusing?

Fri, Apr 27, 7:13 PM
amckinley updated the diff for D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Updates PhabricatorPolicyExplainController to use the same logic. Hacks some more stuff into PhabricatorPolicyCodex to avoid breaking the explain controller. Switch hard-coded strings to constants.

Fri, Apr 27, 7:07 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

Is it guaranteed that the root document is always first in this list, or should I check the slug too?

Fri, Apr 27, 6:26 PM
amckinley added a comment to D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.

...but the current logic gives us a grey tag, I think. A red tag seems better, since you're in a "private area" of the wiki.

Fri, Apr 27, 6:25 PM
amckinley accepted D19410: Fix an issue in the new Harbormaster build log view where clicking the "^" icon doesn't work right.
Fri, Apr 27, 6:05 PM

Thu, Apr 26

amckinley requested review of D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Thu, Apr 26, 12:07 AM
amckinley added a revision to T13128: Phriction document header doesn't render policy strength variations: D19409: Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults.
Thu, Apr 26, 12:06 AM · Policy, PHUI, Phriction

Wed, Apr 25

amckinley accepted D19408: Slightly improve base85 performance for 64-bit systems.

As opposed to going too deep down this rabbit hole, maybe we should check if this extension is installed and just use that if available? AFAIK we don't depend on any other extensions that can't be installed via PECL, but at least it would help this one customer.

Wed, Apr 25, 5:12 PM
amckinley accepted D19407: Restructure base85 unit tests to support inlining and multiple encoding pathways.

Why do all the lines in the expect files start with z now?

Wed, Apr 25, 4:58 PM
amckinley accepted D19406: Recover more gracefully when favicon configuration points at a corrupt/damaged file.
Wed, Apr 25, 4:39 PM
amckinley accepted D19405: Remove unusual unicode marks in Differential action dropdown.

Farewell, checkmark!

Wed, Apr 25, 4:35 PM
amckinley accepted D19403: Add "Content type" and "Rule type" fields to Herald rules for Herald rules.
Wed, Apr 25, 3:05 AM

Tue, Apr 24

amckinley resigned from D18283: Improve Amazon SES code error handling behavior further.
Tue, Apr 24, 4:40 PM

Mon, Apr 23

amckinley accepted D19400: Support Herald rules for Herald rules.

Looks good except for cruft.

Mon, Apr 23, 9:45 PM
amckinley accepted D19399: Manage object mailKeys automatically in Mail instead of storing them on objects.
Mon, Apr 23, 9:39 PM
amckinley added a comment to T13065: Move storage for `mailKey` to the Mail application.

There should be a very small number of readers (2-3?) of this field, so it should be possible to blind them safely like this:

Mon, Apr 23, 9:16 PM · Mail
amckinley accepted D19398: In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft".
Mon, Apr 23, 5:38 PM

Sat, Apr 21

amckinley accepted D19396: Fix excessively severe CSP URI error during first-time setup.
Sat, Apr 21, 4:41 PM
amckinley added inline comments to D19394: Update install_ubuntu.sh to the new age.
Sat, Apr 21, 2:08 PM

Apr 20 2018

amckinley added a commit to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Restricted Diffusion Commit.
Apr 20 2018, 9:08 PM · Plans, Ops, Infrastructure, Phacility
amckinley added a commit to T12857: Temporary directory fullness can cause daemon issues?: Restricted Diffusion Commit.
Apr 20 2018, 9:08 PM · Diffusion, Ops, Daemons, Phacility