- User Since
- Feb 20 2011, 8:41 PM (378 w, 2 h)
- Busy Busy until May 28.
Fri, May 18
Wed, May 16
...it will only work when diffing diffs created after this goes live...
I only really looked at PhabricatorDifferentialRebuildChangesetsWorkflow, assuming that the other changes are just direct cut and pastes.
Tue, May 15
Fix lint error, change help text.
Remove migration, replace with workflow.
Mon, May 14
when we do the migration, basically just have it run bin/repository rebuild-identities --all
switch to using PhabricatorQueryIterator; remove progress bar because we don't have access to the number of query results any more
Cool, I'll update D19446.
Fri, May 11
Requested changes, fix formatting for transactions involving the "Explicitly Unassigned" state.
Thu, May 10
whoops, wrong base revision
fix search bug
remove extra code
remove ferret implementation
Wed, May 9
Tue, May 8
Mon, May 7
Sun, May 6
Sat, May 5
Fri, May 4
Tue, May 1
Mon, Apr 30
Fri, Apr 27
The other tests all look good. I'm going to land this soon unless you can think of anything else to test.
Change access modifier to avoid crashing.
Maybe destroy the Phriction root document with bin/remove destroy and see if that breaks anything? But I think you can't get there normally (we require /x/ exist before we'll let you create /x/y/) so whatever you hit might be pre-existing.
Remove unused CSS class.
This change might be too big; I'm happy to refactor if you think so.
Migrate describeAutomaticCapability() to `getPolicySpecialRuleDescription().
Fix several bugs.
Add more explanatory text to policy explainer.
Can you give me some ideas for more stuff to test before landing this? Phriction and otherwise.
I'd think I'd like to get rid of describeAutomaticCapability() eventually and make everything that wants to explain things implement a Codex instead
However, I'm not sure users are actually confused by this today -- at least, not very often -- even though it seems like it should be kind of confusing?
Updates PhabricatorPolicyExplainController to use the same logic. Hacks some more stuff into PhabricatorPolicyCodex to avoid breaking the explain controller. Switch hard-coded strings to constants.
Is it guaranteed that the root document is always first in this list, or should I check the slug too?
...but the current logic gives us a grey tag, I think. A red tag seems better, since you're in a "private area" of the wiki.
Thu, Apr 26
Wed, Apr 25
As opposed to going too deep down this rabbit hole, maybe we should check if this extension is installed and just use that if available? AFAIK we don't depend on any other extensions that can't be installed via PECL, but at least it would help this one customer.
Why do all the lines in the expect files start with z now?
Tue, Apr 24
Mon, Apr 23
Looks good except for cruft.
There should be a very small number of readers (2-3?) of this field, so it should be possible to blind them safely like this: