- User Since
- Feb 20 2011, 8:41 PM (412 w, 4 d)
Wed, Jan 16
I'm still marking this as accepted; just put it back in "Changes Planned" if either of my issues resonates with you.
I claim with only limited reservations that I totally understand this change.
This all probably falls into "Couple of things not covered here:", so feel free to say "yep yep that's all coming in a subsequent diff" instead of typing it out again, but...
Two actual typos; feel free to ignore the rest if you disagree with the language changes.
Used this test script to send myself some text messages...
Aha, this is what triggered my deja vu: D19959.
When I was messing around with SMS sending last week, I put a rough cut of this together that is capable of sending an SMS using SNS, which has almost the same API as SES: D19982. I can tackle this unless you're already in the middle of it.
I definitely reviewed almost this exact same code, but I have completely lost it in the stack of email-related changes recently. If I recall, I complained about the unused variable, checking for truthiness instead of using strlen for all the fields that PHPMailer wants, and the base64 attachment encoding thing. The truthiness checks make sense now that all those properties are objects instead of bare strings.
This was pretty exhausting to review because I had to give up on figuring out what was just moved and what was actually new, so I just read all of everything and spot checked that a few things like the must encrypt implementation got moved faithfully.
Mon, Jan 14
Sat, Jan 12
Fix weird indentation.
Fri, Jan 11
This could also be rewritten as if ($no_cluster_mailers_configured && $some_deprecated_mailer_configured) to target this message more narrowly.
Thu, Jan 10
Sat, Jan 5
Fri, Jan 4
This doesn't help if you're committed to that Apache life, but FWIW I'm using nginx 1.15.8 via Homebrew on Mojave without any issues.
Thu, Jan 3
This is a Good Thing regardless of how we go forward, but FWIW, AWS also supports sending SMS via SNS: https://aws.amazon.com/sns/sms-pricing/
Wed, Jan 2
Does anyone have experience with an existing Push Notifications As A Service provider? I would naively suggest AWS SNS, because we already depend on other AWS services and it's free for the first 1m pushes, and then $0.50/1m pushes after that. It also wouldn't raise any new data privacy issues for Phacility customers since we wouldn't have to deliver pushes outside of our existing VPC infrastructure. List of supported push targets: