Page MenuHomePhabricator

amckinley (Austin McKinley)Administrator


  • Clear sailing ahead.


  • Clear sailing ahead.


  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (403 w, 4 d)

Recent Activity


amckinley accepted D19806: Add a `bin/herald test ...` for doing test runs via the CLI.
Thu, Nov 15, 10:20 PM
amckinley accepted D19805: Replace the primary "Disabled/Enabled" Herald Rule filter with "Active/Inactive", considering author status.
Thu, Nov 15, 8:12 PM
amckinley accepted D19803: Modernize the Herald rule search engine.
Thu, Nov 15, 8:09 PM
amckinley accepted D19801: Fix all query warnings in "arc unit --everything".
Thu, Nov 15, 3:33 AM
amckinley accepted D19802: Improve performance of two recent commit migrations.
Thu, Nov 15, 3:28 AM
amckinley accepted D19800: Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf().
Thu, Nov 15, 3:26 AM
amckinley accepted D19790: Continue making application fixes to Phabricator for changes to %Q semantics.
Thu, Nov 15, 3:19 AM
amckinley accepted D19789: Update many Phabricator queries for new %Q query semantics.
Thu, Nov 15, 3:12 AM


amckinley accepted D19785: Make SELECT construction in PolicyAwareQuery safer.
Wed, Nov 14, 7:24 PM

Fri, Nov 9

amckinley added inline comments to D19793: Make "bin/repository thaw" workflow more clear when devices are disabled.
Fri, Nov 9, 8:05 PM
amckinley accepted D19799: Add a basic web UI for intracluster sync logs.
Fri, Nov 9, 7:27 PM
amckinley accepted D19798: Put push log "hookWait" to data export and add all wait values to UI.
Fri, Nov 9, 6:58 PM
amckinley accepted D19793: Make "bin/repository thaw" workflow more clear when devices are disabled.
Fri, Nov 9, 6:36 PM

Thu, Nov 8

amckinley accepted D19797: Use phutil_microseconds_since(...) to simplify some timing arithmetic.

Grepped for 1000000 to find these.

Thu, Nov 8, 8:21 PM
amckinley accepted D19796: Add a convenience function for computing elapsed microtime deltas.
Thu, Nov 8, 7:53 PM
amckinley accepted D19788: Make "%LO" and "%LA" more readable when there is only one subclause.
Thu, Nov 8, 12:05 AM
amckinley accepted D19787: Make %LO, %LA, %LQ and %LJ more lax in what they accept (warnings instead of exceptions).
Thu, Nov 8, 12:04 AM
amckinley accepted D19786: Add %LJ (joined with spaces) to qsprintf() for merging JOIN clauses.
Thu, Nov 8, 12:03 AM

Wed, Nov 7

amckinley accepted D19791: Correct a missing parameter in "Outbound Mail" documentation.
Wed, Nov 7, 9:34 PM
amckinley accepted D19784: Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics.
Wed, Nov 7, 9:12 PM
amckinley accepted D19783: Support %LA (AND), %LO (OR) and %LQ (comma) conversions for qsprintf() to improve safety.
Wed, Nov 7, 8:57 PM
amckinley accepted D19782: Support %P (Password or Secret) in qsprintf().
Wed, Nov 7, 8:54 PM
amckinley accepted D19781: Make qsprintf() return an object, not a string, to support %P and hardening of %Q.
Wed, Nov 7, 8:27 PM
amckinley accepted D19780: Add timing information for commit hooks to push logs.
Wed, Nov 7, 8:11 PM
amckinley accepted D19792: Use 160-bit TOTP keys rather than 80-bit TOTP keys.
Wed, Nov 7, 7:02 PM
amckinley accepted D19779: Add an intracluster synchronization log for cluster repositories.
Wed, Nov 7, 6:22 PM
amckinley accepted D19778: Clean up the workflow for some post-push logging code.
Wed, Nov 7, 6:11 PM

Tue, Nov 6

amckinley accepted D19776: Prevent users from selecting excessively bad passwords based on their username or email address.
Tue, Nov 6, 5:52 PM
amckinley accepted D19777: When `{meme ...}` embed has no text, just use the raw file data unmodified.
Tue, Nov 6, 5:39 PM
amckinley awarded D19775: Improve aesthetics of commit hook rejection message a Mountain of Wealth token.
Tue, Nov 6, 4:27 PM
amckinley accepted D19775: Improve aesthetics of commit hook rejection message.
Tue, Nov 6, 4:26 PM
amckinley accepted D19774: Prevent users from voting for invalid Slowvote options.
Tue, Nov 6, 4:22 PM
amckinley accepted D19773: Remove nonfunctional AJAX embed behavior for Slowvote.
Tue, Nov 6, 4:20 PM

Mon, Nov 5

amckinley accepted D19772: Fix an errant "switch ... continue".
Mon, Nov 5, 3:32 PM

Fri, Nov 2

amckinley accepted D19771: Replace magical "branch" behavior in "diffusion.branchquery" with an explicit "patterns".
Fri, Nov 2, 6:28 PM
amckinley accepted D19765: Add test coverage for "%R" in qsprintf() and convert LiskDAO to support it.
Fri, Nov 2, 6:26 PM

Wed, Oct 31

amckinley accepted D19764: Support "%R" (Database + Table Ref) in qsprintf(...).
Wed, Oct 31, 7:10 PM
amckinley accepted D19762: Allow Drydock Blueprints to control "supplemental allocation" behavior so all hosts in an Almanac pool get used.
Wed, Oct 31, 6:37 PM

Fri, Oct 26

amckinley accepted D19763: Further refine the Java syntax lexer for escaped strings.


Fri, Oct 26, 9:33 PM
amckinley created Image Macro "workseverytime".
Fri, Oct 26, 9:33 PM
amckinley accepted D19761: When a Drydock host based on an Almanac blueprint has its binding disabled, stop handing out leases.
Fri, Oct 26, 9:30 PM
amckinley accepted D19760: Expose Audit actions for "" in a basic way.
Fri, Oct 26, 9:27 PM
amckinley accepted D19759: Remove unicode marks for "Accept/Raise Concern" in Audit.
Fri, Oct 26, 9:27 PM
amckinley accepted D19758: Work around a Windows escaping issue and security conecern in "hg cat --output ...".
Fri, Oct 26, 1:57 AM
amckinley accepted D19756: Provide users a hint that "KILL <process>" is a possible source of connection loss.
Fri, Oct 26, 1:55 AM
amckinley accepted D19755: Correct a mangled translation string in "bin/phd log --id X".
Fri, Oct 26, 1:54 AM
amckinley accepted D19754: When a lease triggers a resource allocation for a resource which must activate, awaken the lease task after the resource activates.
Fri, Oct 26, 1:51 AM
amckinley accepted D19753: After a Drydock lease triggers a resource to be reclaimed, stop it from triggering another reclaim until the first one completes.
Fri, Oct 26, 1:49 AM
amckinley accepted D19752: When a Drydock lease schedules a resource to be reclaimed, awaken the lease update task when the reclaim completes.
Fri, Oct 26, 1:46 AM
amckinley accepted D19751: In "bin/drydock lease", take a JSON "--attributes" so we can accept complex values.
Fri, Oct 26, 1:44 AM
amckinley accepted D16594: Expose Drydock leases via Conduit.
Fri, Oct 26, 1:43 AM

Wed, Oct 24

amckinley accepted D19750: When leasing a Working Copy in Drydock, just "git reset --hard" so empty repositories work.
Wed, Oct 24, 3:03 PM

Fri, Oct 19

amckinley accepted D19748: Skip copied code detection for changes that are too large for it to be useful.
Fri, Oct 19, 9:27 PM
amckinley accepted D19747: Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource".
Fri, Oct 19, 7:15 PM

Oct 16 2018

amckinley accepted D19735: Explicitly shuffle nodes before selecting one for cluster sync.
Oct 16 2018, 10:38 PM

Oct 15 2018

amckinley accepted D19734: Try to route cluster writes to nodes which won't need to synchronize first.
Oct 15 2018, 9:37 PM

Oct 11 2018

amckinley accepted D19742: Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline".
Oct 11 2018, 8:42 PM
amckinley accepted D19743: Support export of revisions to Excel/CSV/JSON/etc.
Oct 11 2018, 8:31 PM
amckinley accepted D19744: In "bin/bulk export", require "--output <path>" by default.
Oct 11 2018, 8:29 PM

Oct 9 2018

amckinley accepted D19739: When using "bin/bulk export --overwrite", actually overwrite the file.
Oct 9 2018, 8:44 PM
amckinley accepted D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags.
Oct 9 2018, 8:43 PM

Oct 5 2018

amckinley accepted D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 8:08 PM
amckinley accepted D19732: Allow revisions to be filtered by created date.
Oct 5 2018, 6:17 PM
amckinley accepted D19731: Fix two issues with the Java syntax highlighter lexer.
Oct 5 2018, 6:11 PM

Oct 2 2018

amckinley accepted D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 2 2018, 10:47 PM
amckinley accepted D19728: [Wilds] Stop writing temporary files for linter tests.
Oct 2 2018, 7:56 PM
amckinley accepted D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 2 2018, 7:34 PM
amckinley accepted D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 2 2018, 7:20 PM
amckinley accepted D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows.
Oct 2 2018, 7:18 PM
amckinley accepted D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.


Oct 2 2018, 7:00 PM

Oct 1 2018

amckinley accepted D19723: Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll.
Oct 1 2018, 7:38 PM
amckinley accepted D19722: Add 'autocomplete="off"' to MFA TOTP inputs.

While you're here, it always bugs me that the 2FA page doesn't automatically put the cursor in the input box. Is that a one-line change?

Oct 1 2018, 7:37 PM
amckinley accepted D19721: Use the changeset parse cache when rendering inline comments in mail.
Oct 1 2018, 7:36 PM
amckinley accepted D19720: Add setHint/getHint to PhutilLockException for recent lock changes.
Oct 1 2018, 5:17 PM

Sep 29 2018

amckinley committed rPdbf2302b6c67: Fix self-cancelling typo (authored by amckinley).
Fix self-cancelling typo
Sep 29 2018, 12:44 AM
amckinley closed D19718: Fix self-cancelling typo.
Sep 29 2018, 12:44 AM

Sep 28 2018

amckinley requested review of D19718: Fix self-cancelling typo.
Sep 28 2018, 8:43 PM

Sep 27 2018

amckinley accepted D19717: [Wilds] Remove all linters and test cases not used by Arcanist.

I looked at ArcanistJSONLinterTestCase.php and confirmed that everything else was moved or deleted.

Sep 27 2018, 10:24 PM
amckinley accepted D19716: [Wilds] Make "arc" survive all tests with no failures.
Sep 27 2018, 10:22 PM
amckinley accepted D19715: [Wilds] Fix the last set of failing non-linter test cases.
Sep 27 2018, 8:22 PM
amckinley accepted D19714: [Wilds] Make more test cases (mostly related to the phutil -> arcanist move) pass.
Sep 27 2018, 8:22 PM
amckinley accepted D19713: [Wilds] Make "Bundle" test cases pass.
Sep 27 2018, 8:19 PM
amckinley accepted D19712: [Wilds] Make "Base Commit" parser test cases pass.
Sep 27 2018, 8:18 PM

Sep 26 2018

amckinley committed rP8065433ee8dc: Migrate DiffusionBlameController to use repo identities (authored by amckinley).
Migrate DiffusionBlameController to use repo identities
Sep 26 2018, 9:46 PM
amckinley closed D19587: Migrate DiffusionBlameController to use repo identities.
Sep 26 2018, 9:46 PM
amckinley accepted D19711: [Wilds] Rename "formatters" to "sinks" and restore the console output sufficiently to see which tests are failing.
Sep 26 2018, 9:35 PM
amckinley accepted D19710: [Wilds] Make "arc unit" run again, with many caveats.
Sep 26 2018, 9:28 PM
amckinley accepted D19709: [Wilds] Tailor the behavior of some unit tests which `print_r($the_entire_world, true)`.
Sep 26 2018, 6:08 PM
amckinley accepted D19708: [Wilds] Fix some minor classtree issues identified by unit tests.
Sep 26 2018, 6:04 PM
amckinley accepted D19707: [Wilds] Refine the working copy selection algorithm for Subversion vs Git/Mercurial.
Sep 26 2018, 6:04 PM
amckinley accepted D19703: [Wilds] Handle SIGINT (^C) in ArcanistRuntime in a more formal way.

AFAIK, these are the only signals that you can send from the keyboard:

Sep 26 2018, 5:59 PM
amckinley accepted D19706: [Wilds] Provide a skeleton for prompt behaviors.
Sep 26 2018, 5:09 PM

Sep 25 2018

amckinley added inline comments to D19703: [Wilds] Handle SIGINT (^C) in ArcanistRuntime in a more formal way.
Sep 25 2018, 10:32 PM
amckinley accepted D19705: [Wilds] Shell complete files with spaces in them correctly.

I definitely exhaustively tested this code and 100% understand it completely.

Sep 25 2018, 7:56 PM
amckinley added inline comments to D19703: [Wilds] Handle SIGINT (^C) in ArcanistRuntime in a more formal way.
Sep 25 2018, 7:36 PM
amckinley accepted D19697: [Wilds] Continue toward a generalized "arc alias" workflow.

Upshot: unless you have a better idea, can I give you an IOU for test coverage on T13098 until arc unit runs again?

Sep 25 2018, 7:18 PM
amckinley resigned from D19704: [DO NOT COMMIT] Test workflow.
Sep 25 2018, 6:43 PM

Sep 24 2018

amckinley added inline comments to D19702: When we fail to acquire a repository lock, try to provide a hint about why.
Sep 24 2018, 5:40 PM
amckinley accepted D19702: When we fail to acquire a repository lock, try to provide a hint about why.
Sep 24 2018, 5:27 PM
amckinley accepted D19701: Parameterize the repository read and write locks.
Sep 24 2018, 5:22 PM