amckinley (Austin McKinley)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (326 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

amckinley added a comment to T12751: Long-lived Conpherence tabs occasionally cause "invalid CSRF token" errors.

This will also fix the important use case where someone is running their browser inside a VM that they frequently suspend.

Wed, May 24, 5:35 PM · Bug Report
amckinley created T12751: Long-lived Conpherence tabs occasionally cause "invalid CSRF token" errors.
Wed, May 24, 5:30 PM · Bug Report
amckinley accepted D17985: Add slugs to project manage page.

Looks good unless you want to move this function.

Wed, May 24, 4:44 PM
amckinley added a comment to D17985: Add slugs to project manage page.

ohai

Wed, May 24, 4:43 PM

Yesterday

amckinley committed rP774fba3ce925: Migrate Project workboard to modular transactions (authored by amckinley).
Migrate Project workboard to modular transactions
Tue, May 23, 7:38 PM
amckinley closed D18004: Migrate Project workboard to modular transactions by committing rP774fba3ce925: Migrate Project workboard to modular transactions.
Tue, May 23, 7:38 PM
amckinley created D18004: Migrate Project workboard to modular transactions.
Tue, May 23, 7:07 PM
amckinley committed rPcd136a6af86a: Migrate Project parent and milestone to modular transactions (authored by amckinley).
Migrate Project parent and milestone to modular transactions
Tue, May 23, 6:20 PM
amckinley closed D17999: Migrate Project parent and milestone to modular transactions by committing rPcd136a6af86a: Migrate Project parent and milestone to modular transactions.
Tue, May 23, 6:20 PM
amckinley updated the diff for D17999: Migrate Project parent and milestone to modular transactions.
  • requested changes
Tue, May 23, 6:19 PM
amckinley added inline comments to D17999: Migrate Project parent and milestone to modular transactions.
Tue, May 23, 12:16 AM
amckinley added inline comments to D17999: Migrate Project parent and milestone to modular transactions.
Tue, May 23, 12:15 AM
amckinley updated the diff for D17999: Migrate Project parent and milestone to modular transactions.
  • dangling comment
Tue, May 23, 12:14 AM
amckinley created D17999: Migrate Project parent and milestone to modular transactions.
Tue, May 23, 12:11 AM

Sun, May 21

amckinley committed rP179d80dd57f8: Migrate Project lock to modular transactions (authored by amckinley).
Migrate Project lock to modular transactions
Sun, May 21, 6:37 PM
amckinley closed D17986: Migrate Project lock to modular transactions by committing rP179d80dd57f8: Migrate Project lock to modular transactions.
Sun, May 21, 6:36 PM

Sat, May 20

amckinley created D17986: Migrate Project lock to modular transactions.
Sat, May 20, 10:41 PM

Fri, May 19

amckinley added a comment to D17967: Make editing project images redirect to "Manage" more consistently.

Yeah, +F hits nothing.

We could probably detect this in lint, it just doesn't come up too terribly often.

Fri, May 19, 8:59 PM
amckinley accepted D17967: Make editing project images redirect to "Manage" more consistently.
Fri, May 19, 8:55 PM
amckinley added a comment to D17966: Make Project slug/hashtag transactions render a little more nicely.
In D17966#217662, @chad wrote:

Can we put an actual # there too?

Fri, May 19, 8:53 PM
amckinley accepted D17966: Make Project slug/hashtag transactions render a little more nicely.

Slugworth approves.

Fri, May 19, 8:50 PM

Thu, May 18

amckinley committed rP7e46d7ab6a6b: Migrate Project color to modular transactions (authored by amckinley).
Migrate Project color to modular transactions
Thu, May 18, 11:46 PM
amckinley closed D17958: Migrate Project color to modular transactions by committing rP7e46d7ab6a6b: Migrate Project color to modular transactions.
Thu, May 18, 11:46 PM
amckinley created D17958: Migrate Project color to modular transactions.
Thu, May 18, 11:40 PM
amckinley committed rP1bff5309e667: Migrate Project icons to modular transactions (authored by amckinley).
Migrate Project icons to modular transactions
Thu, May 18, 11:26 PM
amckinley closed D17956: Migrate Project icons to modular transactions by committing rP1bff5309e667: Migrate Project icons to modular transactions.
Thu, May 18, 11:26 PM
amckinley created D17956: Migrate Project icons to modular transactions.
Thu, May 18, 11:23 PM
amckinley committed rPeb84bf98a413: Migrate Project image to modular transactions (authored by amckinley).
Migrate Project image to modular transactions
Thu, May 18, 11:08 PM
amckinley closed D17954: Migrate Project image to modular transactions by committing rPeb84bf98a413: Migrate Project image to modular transactions.
Thu, May 18, 11:08 PM
amckinley updated the diff for D17954: Migrate Project image to modular transactions.
  • add attachToObject logic to prevent subtle permissions issues with project images
Thu, May 18, 10:21 PM
amckinley added a comment to D17954: Migrate Project image to modular transactions.

If I hard-code an image I can't see, the file attaches successfully, then redirects to /project/view/<id>/. Then, that page throws a policy error while trying to load the project because I can't see the project's profile image.

Thu, May 18, 10:08 PM
amckinley updated the diff for D17954: Migrate Project image to modular transactions.
  • remove test code
Thu, May 18, 9:55 PM
amckinley updated the diff for D17954: Migrate Project image to modular transactions.
  • add validation of project image viewability, remove accidental dangling break statement
Thu, May 18, 9:54 PM
amckinley added a comment to D17954: Migrate Project image to modular transactions.

Hmm, show me the code? I have no clue what's doing the extra validation offhand.

Thu, May 18, 9:22 PM
amckinley created P2052 (An Untitled Masterwork).
Thu, May 18, 9:19 PM
amckinley added a comment to D17954: Migrate Project image to modular transactions.

Any suggestions on how to test the file validation? I went and edited PhabricatorProjectEditPictureController to hardcode the PHID of a restricted image into setNewValue(). That's throwing a "You Shall Not Pass" permissions errors, but it's not coming from my validateTransactions() code, so it looks like something is kicking me out before we get far enough through applyTransactions() to trigger my validation code.

Thu, May 18, 9:16 PM
amckinley added inline comments to D17954: Migrate Project image to modular transactions.
Thu, May 18, 8:14 PM
amckinley created D17954: Migrate Project image to modular transactions.
Thu, May 18, 8:06 PM
amckinley committed rPf92059d84c6a: Migrate Project status to modular transactions (authored by amckinley).
Migrate Project status to modular transactions
Thu, May 18, 6:36 PM
amckinley closed D17953: Migrate Project status to modular transactions by committing rPf92059d84c6a: Migrate Project status to modular transactions.
Thu, May 18, 6:36 PM
amckinley created D17953: Migrate Project status to modular transactions.
Thu, May 18, 6:32 PM
amckinley committed rP91eb22cb3a8b: Migrate Project slugs to modular transactions (authored by amckinley).
Migrate Project slugs to modular transactions
Thu, May 18, 6:15 PM
amckinley closed D17952: Migrate Project slugs to modular transactions by committing rP91eb22cb3a8b: Migrate Project slugs to modular transactions.
Thu, May 18, 6:15 PM
amckinley created D17952: Migrate Project slugs to modular transactions.
Thu, May 18, 6:12 PM
amckinley committed rP1e3c8df1c89d: Migrate Project names to modular transactions (authored by amckinley).
Migrate Project names to modular transactions
Thu, May 18, 12:12 AM
amckinley closed D17947: Migrate Project names to modular transactions by committing rP1e3c8df1c89d: Migrate Project names to modular transactions.
Thu, May 18, 12:12 AM
amckinley created D17947: Migrate Project names to modular transactions.
Thu, May 18, 12:01 AM
amckinley added a revision to T12673: Update Projects for Modular Transactions: D17947: Migrate Project names to modular transactions.
Thu, May 18, 12:01 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Wed, May 17

amckinley committed rPd12be0fc2190: Change Pholio editor access modifier (authored by amckinley).
Change Pholio editor access modifier
Wed, May 17, 11:24 PM
amckinley closed D17946: Change Pholio editor access modifier by committing rPd12be0fc2190: Change Pholio editor access modifier.
Wed, May 17, 11:24 PM
amckinley created T12723: A failure to upload a file in the Pholio Mock editor doesn't dismiss the "Uploading..." UI.
Wed, May 17, 11:20 PM · Pholio, Bug Report
amckinley created D17946: Change Pholio editor access modifier.
Wed, May 17, 11:16 PM

Tue, May 16

amckinley updated the task description for T10448: Modularize mail tags.
Tue, May 16, 7:23 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley committed rP6888472b567e: Migrate Pholio inline comments to modular transactions (authored by amckinley).
Migrate Pholio inline comments to modular transactions
Tue, May 16, 7:22 PM
amckinley closed T12626: Update Pholio for Modular Transactions, a subtask of T10448: Modularize mail tags, as Resolved.
Tue, May 16, 7:22 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley closed T12626: Update Pholio for Modular Transactions as Resolved by committing rP6888472b567e: Migrate Pholio inline comments to modular transactions.
Tue, May 16, 7:22 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley closed D17914: Migrate Pholio inline comments to modular transactions by committing rP6888472b567e: Migrate Pholio inline comments to modular transactions.
Tue, May 16, 7:22 PM
amckinley added inline comments to D17914: Migrate Pholio inline comments to modular transactions.
Tue, May 16, 7:21 PM
amckinley created D17914: Migrate Pholio inline comments to modular transactions.
Tue, May 16, 7:12 PM
amckinley added a revision to T12626: Update Pholio for Modular Transactions: D17914: Migrate Pholio inline comments to modular transactions.
Tue, May 16, 7:12 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Mon, May 15

amckinley committed rP545d6347dd8f: Convert remaining Pholio image transactions to modular transaction framework (authored by amckinley).
Convert remaining Pholio image transactions to modular transaction framework
Mon, May 15, 11:25 PM
amckinley closed D17892: Convert remaining Pholio image transactions to modular transaction framework by committing rP545d6347dd8f: Convert remaining Pholio image transactions to modular transaction framework.
Mon, May 15, 11:25 PM
amckinley created D17892: Convert remaining Pholio image transactions to modular transaction framework.
Mon, May 15, 11:05 PM
amckinley committed rP78544334cd69: Fix breakage of Pholio (authored by amckinley).
Fix breakage of Pholio
Mon, May 15, 8:30 PM
amckinley closed D17889: Fix breakage of Pholio by committing rP78544334cd69: Fix breakage of Pholio.
Mon, May 15, 8:30 PM
amckinley created D17889: Fix breakage of Pholio.
Mon, May 15, 8:25 PM

Fri, May 12

amckinley committed rP74d86f09023c: Migrate Pholio image description and mock status to modular transactions (authored by amckinley).
Migrate Pholio image description and mock status to modular transactions
Fri, May 12, 11:07 PM
amckinley closed D17868: Migrate Pholio image description and mock status to modular transactions by committing rP74d86f09023c: Migrate Pholio image description and mock status to modular transactions.
Fri, May 12, 11:07 PM
amckinley updated the diff for D17868: Migrate Pholio image description and mock status to modular transactions.
  • switch to just using head
Fri, May 12, 11:03 PM

Thu, May 11

amckinley created D17868: Migrate Pholio image description and mock status to modular transactions.
Thu, May 11, 12:05 AM

Wed, May 10

amckinley committed rPfcf64953f093: Migate more of Pholio to Modular Transaction (authored by amckinley).
Migate more of Pholio to Modular Transaction
Wed, May 10, 10:14 PM
amckinley closed D17865: Migate more of Pholio to Modular Transaction by committing rPfcf64953f093: Migate more of Pholio to Modular Transaction.
Wed, May 10, 10:13 PM
amckinley updated the diff for D17865: Migate more of Pholio to Modular Transaction.
  • requested changes. also adds validation for image names
Wed, May 10, 10:13 PM
amckinley updated the diff for D17865: Migate more of Pholio to Modular Transaction.

diff just got bigger

Wed, May 10, 9:28 PM
amckinley updated the diff for D17865: Migate more of Pholio to Modular Transaction.
  • adding image name transaction
Wed, May 10, 9:24 PM
amckinley updated the diff for D17865: Migate more of Pholio to Modular Transaction.
  • add more classes with better names
Wed, May 10, 8:52 PM
amckinley added a comment to D17865: Migate more of Pholio to Modular Transaction.
In D17865#216039, @chad wrote:

I'd probably recommend these move to PholioMockXXXXTransaction for future expansion.

Wed, May 10, 8:01 PM
amckinley updated the diff for D17865: Migate more of Pholio to Modular Transaction.
  • no quotes
Wed, May 10, 8:01 PM
amckinley created D17865: Migate more of Pholio to Modular Transaction.
Wed, May 10, 7:56 PM
amckinley committed rPd39758ca7cac: Migrate Pholio to Frankenstein transactions (authored by amckinley).
Migrate Pholio to Frankenstein transactions
Wed, May 10, 7:39 PM
amckinley closed D17864: Migrate Pholio to Frankenstein transactions by committing rPd39758ca7cac: Migrate Pholio to Frankenstein transactions.
Wed, May 10, 7:38 PM
amckinley updated the diff for D17864: Migrate Pholio to Frankenstein transactions.
  • removing getImageForXaction until needed
Wed, May 10, 7:37 PM
epriestley awarded D17864: Migrate Pholio to Frankenstein transactions a Pterodactyl token.
Wed, May 10, 7:11 PM
chad awarded D17864: Migrate Pholio to Frankenstein transactions a Pirate Logo token.
Wed, May 10, 6:58 PM
amckinley created D17864: Migrate Pholio to Frankenstein transactions.
Wed, May 10, 6:41 PM

Sat, May 6

amckinley accepted D17836: Fix file attach bug in Macro.
Sat, May 6, 2:46 AM

Fri, May 5

amckinley committed rP0dc90b891a7c: Reimplement Slowvote transactions using modular transactions (authored by amckinley).
Reimplement Slowvote transactions using modular transactions
Fri, May 5, 3:20 AM
amckinley closed T12623: Update Slowvote for Modular Transactions, a subtask of T10448: Modularize mail tags, as Resolved.
Fri, May 5, 3:20 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley closed D17830: Reimplement Slowvote transactions using modular transactions by committing rP0dc90b891a7c: Reimplement Slowvote transactions using modular transactions.
Fri, May 5, 3:20 AM
amckinley closed T12623: Update Slowvote for Modular Transactions as Resolved by committing rP0dc90b891a7c: Reimplement Slowvote transactions using modular transactions.
Fri, May 5, 3:20 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley updated the diff for D17830: Reimplement Slowvote transactions using modular transactions.
  • removing bogus null check
Fri, May 5, 3:18 AM
amckinley updated the diff for D17830: Reimplement Slowvote transactions using modular transactions.
  • requested changes
Fri, May 5, 2:43 AM
amckinley claimed T12673: Update Projects for Modular Transactions.
Fri, May 5, 1:51 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley claimed T12626: Update Pholio for Modular Transactions.
Fri, May 5, 1:22 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
amckinley accepted D17831: Explicitly quote "From" name part when submitting mail to the Mailgun API.
Fri, May 5, 12:02 AM

Thu, May 4

amckinley updated the test plan for D17830: Reimplement Slowvote transactions using modular transactions.
Thu, May 4, 11:50 PM
amckinley updated the test plan for D17830: Reimplement Slowvote transactions using modular transactions.
Thu, May 4, 11:50 PM
amckinley updated the diff for D17830: Reimplement Slowvote transactions using modular transactions.
  • forgot to save
Thu, May 4, 11:48 PM
amckinley created D17830: Reimplement Slowvote transactions using modular transactions.
Thu, May 4, 11:45 PM
amckinley added a revision to T12623: Update Slowvote for Modular Transactions: D17830: Reimplement Slowvote transactions using modular transactions.
Thu, May 4, 11:45 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request