amckinley (Austin McKinley)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (321 w, 6 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

amckinley accepted D17758: Update rate limiting for APCu and X-Forwarded-For.
Sat, Apr 22, 3:12 AM
amckinley requested changes to D17758: Update rate limiting for APCu and X-Forwarded-For.

Obligatory "but how much traffic can the rate-limiting infrastructure handle before that itself triggers a DoS condition?" comment, even though I'm sure APCu can handle it.

Sat, Apr 22, 3:03 AM

Fri, Apr 21

amckinley added a comment to D17756: Remove all "Phabricator Bot" code.

Fri, Apr 21, 7:51 PM
amckinley planned changes to D17757: Implement modular transactions for application policy changes.

This only exists to move the code from old to new laptop.

Fri, Apr 21, 7:46 PM
amckinley added a revision to T11476: Record transaction histories when users edit application capabilities: D17757: Implement modular transactions for application policy changes.
Fri, Apr 21, 7:46 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
amckinley created D17757: Implement modular transactions for application policy changes.
Fri, Apr 21, 7:46 PM

Thu, Apr 20

amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

This is also prrrrobably an awful idea, but in theory we could put, say, HAProxy on each host in front of Apache and have it queue connections while Apache was restarting. That feels like we're building a really flimsy house of cards, but it's something computers could technically do.

Thu, Apr 20, 10:55 PM · Phacility
amckinley created T12610: Audit behavior of LB healthchecks against *.phacility.com and secure.phabricator.com.
Thu, Apr 20, 8:50 PM · Ops, Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

I'll file a task for "unfuck status check".

Thu, Apr 20, 8:48 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

I think you might need to send a Host header to trigger the RedirectMatch... but the LB certainly isn't; it just knows IP/port/path. ¯\_(ツ)_/¯

Thu, Apr 20, 8:48 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.
Thu, Apr 20, 8:39 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

Another possible question here is: how long does it take to pull a node out of an ELB with the AWS API? If it's very fast, maybe worthwhile to pursue actively managing nodes in the LB. But I'm guessing it's at least similar to the ~10s health check stuff.

Thu, Apr 20, 8:36 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

There's also a discussion to be had about generally increasing the robustness of the healthcheck: that endpoint could attempt a DB connection, look for a full disk, check that ntp status is reasonable, etc, etc. This has tradeoffs as far as creating extra CPU load, false negatives, etc, etc, but there's probably a happy medium between "Apache doing RedirectMatch 200 "^/status/$"" and generating a full page.

Thu, Apr 20, 8:28 PM · Phacility
amckinley updated subscribers of T12607: Decrease pain and suffering caused by deploy/upgrade process.
Thu, Apr 20, 8:21 PM · Phacility
amckinley created T12607: Decrease pain and suffering caused by deploy/upgrade process.
Thu, Apr 20, 8:21 PM · Phacility
amckinley added a comment to T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.

What would the appropriate query be? "Number of uploaded files with size greater than X as a percentage of all files/file bytes"?

Thu, Apr 20, 7:57 PM · Phacility, Files
amckinley created T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.
Thu, Apr 20, 7:34 PM · Phacility, Files

Wed, Apr 19

amckinley accepted D17739: Make "Locate File" trigger when data loads if the user typed/pasted real fast.

👍

Wed, Apr 19, 11:13 PM
amckinley accepted D17738: Make Applications extend LiskDAO.
Wed, Apr 19, 11:02 PM
amckinley committed rPd58b808f04e6: Fixing copy/paste mistake (authored by amckinley).
Fixing copy/paste mistake
Wed, Apr 19, 10:49 PM
amckinley closed D17737: Fixing copy/paste mistake by committing rPd58b808f04e6: Fixing copy/paste mistake.
Wed, Apr 19, 10:49 PM
amckinley created D17737: Fixing copy/paste mistake.
Wed, Apr 19, 10:47 PM
amckinley committed rPfebd68039fdc: Add initial infrastructure for adding ModularTransaction support to Application… (authored by amckinley).
Add initial infrastructure for adding ModularTransaction support to Application…
Wed, Apr 19, 10:45 PM
amckinley closed D17736: Add initial infrastructure for adding ModularTransaction support to Application config changes by committing rPfebd68039fdc: Add initial infrastructure for adding ModularTransaction support to Application….
Wed, Apr 19, 10:45 PM
amckinley created T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.
Wed, Apr 19, 10:31 PM · Diffusion
amckinley created D17736: Add initial infrastructure for adding ModularTransaction support to Application config changes.
Wed, Apr 19, 10:21 PM
amckinley added a revision to T11476: Record transaction histories when users edit application capabilities: D17736: Add initial infrastructure for adding ModularTransaction support to Application config changes.
Wed, Apr 19, 10:21 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
amckinley committed rP305966e748ba: Fixing of the typos (authored by amckinley).
Fixing of the typos
Wed, Apr 19, 6:39 PM
amckinley closed D17727: Fixing of the typos by committing rP305966e748ba: Fixing of the typos.
Wed, Apr 19, 6:39 PM
amckinley updated the diff for D17727: Fixing of the typos.
  • again
Wed, Apr 19, 6:37 PM
amckinley updated the diff for D17727: Fixing of the typos.
  • a few more
Wed, Apr 19, 3:52 PM
amckinley added inline comments to D17727: Fixing of the typos.
Wed, Apr 19, 3:50 PM
amckinley updated the diff for D17727: Fixing of the typos.
  • another
Wed, Apr 19, 3:36 PM
amckinley created D17727: Fixing of the typos.
Wed, Apr 19, 3:32 PM

Tue, Apr 18

amckinley added a comment to T12589: Add yourself to corporate website /about/.

Yeah, I was surprised neither of you jumped on "phounder". Where does that content live? I can't seem to find it in any of the repos I already have checked out.

Tue, Apr 18, 10:26 PM · Public & Media Relations
amckinley added a comment to T12589: Add yourself to corporate website /about/.

Only if I get a cool title.

Tue, Apr 18, 10:13 PM · Public & Media Relations
amckinley created Image Macro "hackerman".
Tue, Apr 18, 10:13 PM
amckinley claimed T11476: Record transaction histories when users edit application capabilities.
Tue, Apr 18, 9:30 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
amckinley committed rPece9579d258d: Switch File deletion to use ModularTransactions (authored by amckinley).
Switch File deletion to use ModularTransactions
Tue, Apr 18, 8:02 PM
amckinley closed T12587: Migrate file deletion to modular transactions as "Resolved" by committing rPece9579d258d: Switch File deletion to use ModularTransactions.
Tue, Apr 18, 8:01 PM · Files
amckinley closed D17723: Switch File deletion to use ModularTransactions by committing rPece9579d258d: Switch File deletion to use ModularTransactions.
Tue, Apr 18, 8:01 PM
amckinley updated the diff for D17723: Switch File deletion to use ModularTransactions.
  • requested changes
Tue, Apr 18, 7:49 PM
amckinley added inline comments to D17723: Switch File deletion to use ModularTransactions.
Tue, Apr 18, 7:33 PM
amckinley created D17723: Switch File deletion to use ModularTransactions.
Tue, Apr 18, 7:23 PM
amckinley added a revision to T12587: Migrate file deletion to modular transactions: D17723: Switch File deletion to use ModularTransactions.
Tue, Apr 18, 7:23 PM · Files
amckinley added a comment to T12587: Migrate file deletion to modular transactions.

@epriestley should it be possible to un-delete a File, the same way it's possible to archive and then un-archive a Paste? The only benefit I can see is that in an emergency where someone accidentally kicked off a delete for a bunch of files they didn't intend to, someone could stop the daemons and perform an undelete operation before restarting the daemons (instead of flushing the worker queue). I actually mostly coded it this way already by following along with PhabricatorPasteStatusTransaction.

Tue, Apr 18, 6:47 PM · Files
amckinley edited the description of T12587: Migrate file deletion to modular transactions.
Tue, Apr 18, 6:10 PM · Files
amckinley created T12587: Migrate file deletion to modular transactions.
Tue, Apr 18, 6:10 PM · Files
amckinley committed rPbe00264ae74b: Make daemons perform file deletion (authored by amckinley).
Make daemons perform file deletion
Tue, Apr 18, 6:09 PM
amckinley closed T10828: File deletion should be queued up and run by daemons as "Resolved" by committing rPbe00264ae74b: Make daemons perform file deletion.
Tue, Apr 18, 6:09 PM · Contributor Onboarding, Daemons, Files, Bug Report
amckinley closed D15743: Make daemons perform file deletion by committing rPbe00264ae74b: Make daemons perform file deletion.
Tue, Apr 18, 6:09 PM
amckinley updated the diff for D15743: Make daemons perform file deletion.
  • requested changes
Tue, Apr 18, 6:07 PM
amckinley removed a reviewer for D15743: Make daemons perform file deletion: thoughtpolice.
Tue, Apr 18, 5:56 PM
amckinley updated the diff for D15743: Make daemons perform file deletion.
  • Add an isDeleted column and update important controllers to check for it
Tue, Apr 18, 5:49 PM
amckinley created P2040 (An Untitled Masterwork).
Tue, Apr 18, 5:20 PM
amckinley commandeered D15743: Make daemons perform file deletion.
Tue, Apr 18, 3:47 PM
amckinley committed rPb54adc6161c2: Kick off indexing for File objects on creation (authored by amckinley).
Kick off indexing for File objects on creation
Tue, Apr 18, 3:38 PM
amckinley closed T8788: Allow querying for files by name as "Resolved" by committing rPb54adc6161c2: Kick off indexing for File objects on creation.
Tue, Apr 18, 3:38 PM · Contributor Onboarding, Files
amckinley closed D17718: Kick off indexing for File objects on creation by committing rPb54adc6161c2: Kick off indexing for File objects on creation.
Tue, Apr 18, 3:38 PM
amckinley updated the diff for D17718: Kick off indexing for File objects on creation.

fixes T8788.

Tue, Apr 18, 3:29 PM
amckinley created D17718: Kick off indexing for File objects on creation.
Tue, Apr 18, 3:24 PM
amckinley added a revision to T8788: Allow querying for files by name: D17718: Kick off indexing for File objects on creation.
Tue, Apr 18, 3:24 PM · Contributor Onboarding, Files
amckinley added a comment to T8788: Allow querying for files by name.

@epriestley I just landed D17702, without really tackling the problem of files being created in non-standard code paths. I searched the codebase for PhabricatorFile::initializeNewFile() and didn't find anything scary-looking; do you have any specific examples that might need updating?

Tue, Apr 18, 12:41 AM · Contributor Onboarding, Files
amckinley committed rP976fbee877c9: Implement ngram search for File objects (authored by amckinley).
Implement ngram search for File objects
Tue, Apr 18, 12:37 AM
amckinley closed D17702: Implement ngram search for File objects by committing rP976fbee877c9: Implement ngram search for File objects.
Tue, Apr 18, 12:37 AM
amckinley added a revision to T8788: Allow querying for files by name: D17702: Implement ngram search for File objects.
Tue, Apr 18, 12:37 AM · Contributor Onboarding, Files
amckinley added a task to D17702: Implement ngram search for File objects: T8788: Allow querying for files by name.
Tue, Apr 18, 12:37 AM
amckinley updated the diff for D17702: Implement ngram search for File objects.
  • removing FileFulltextEngine
  • removing migration to force file reindex
  • update File deletion logic to use DestructionEngine
Tue, Apr 18, 12:30 AM
amckinley created P2039 (An Untitled Masterwork).
Tue, Apr 18, 12:30 AM

Mon, Apr 17

amckinley accepted D17704: Extend "fulltext" and "ngrams" interfaces from "indexable" interface.
Mon, Apr 17, 7:55 PM
amckinley claimed T10828: File deletion should be queued up and run by daemons.
Mon, Apr 17, 7:26 PM · Contributor Onboarding, Daemons, Files, Bug Report
amckinley planned changes to D17702: Implement ngram search for File objects.
Mon, Apr 17, 7:24 PM
amckinley added a comment to D17702: Implement ngram search for File objects.

Note that this also doesn't clean up ngrams once files are deleted (unless that happens automagically).

Mon, Apr 17, 7:22 PM
amckinley added inline comments to D17702: Implement ngram search for File objects.
Mon, Apr 17, 7:16 PM
amckinley created D17702: Implement ngram search for File objects.
Mon, Apr 17, 7:14 PM
amckinley claimed T8788: Allow querying for files by name.
Mon, Apr 17, 6:06 PM · Contributor Onboarding, Files
amckinley closed T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting as "Resolved".
Mon, Apr 17, 5:53 PM · Contributor Onboarding, Modernization
amckinley created T12576: Quoting timeline objects without calling setQuoteRef() results in strings like "In null, <user> wrote".
Mon, Apr 17, 5:28 PM · Maniphest
amckinley committed rPf801c7ae29ba: Change PhabricatorPhurlURLViewController to use EditEngine for commenting (authored by amckinley).
Change PhabricatorPhurlURLViewController to use EditEngine for commenting
Mon, Apr 17, 5:19 PM
amckinley closed D17686: Change PhabricatorPhurlURLViewController to use EditEngine for commenting by committing rPf801c7ae29ba: Change PhabricatorPhurlURLViewController to use EditEngine for commenting.
Mon, Apr 17, 5:19 PM
amckinley updated the diff for D17686: Change PhabricatorPhurlURLViewController to use EditEngine for commenting.
  • requested changes
Mon, Apr 17, 5:15 PM

Thu, Apr 13

amckinley added a revision to T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting: D17686: Change PhabricatorPhurlURLViewController to use EditEngine for commenting.
Thu, Apr 13, 11:36 PM · Contributor Onboarding, Modernization
amckinley created D17686: Change PhabricatorPhurlURLViewController to use EditEngine for commenting.
Thu, Apr 13, 11:36 PM
amckinley claimed T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting.
Thu, Apr 13, 11:25 PM · Contributor Onboarding, Modernization
cinek awarded T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations a Baby Tequila token.
Thu, Apr 13, 10:39 PM · Contributor Onboarding, Bug Report
amckinley added a comment to E1469: Austin on vacation.

We're going to Calistoga, so that seems likely!

Thu, Apr 13, 9:05 PM · Phacility
epriestley awarded E1469: Austin on vacation a Evil Spooky Haunted Tree token.
Thu, Apr 13, 9:04 PM · Phacility
amckinley created E1469: Austin on vacation.
Thu, Apr 13, 9:01 PM · Phacility
amckinley closed T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations as "Resolved".
Thu, Apr 13, 8:57 PM · Contributor Onboarding, Bug Report
amckinley closed T12532: `syntax.filemap` does not validate input as "Resolved".
Thu, Apr 13, 8:57 PM · Contributor Onboarding, Config, Bug Report
amckinley committed rP980d6cb70b94: Add validation for config settings of type regex (authored by amckinley).
Add validation for config settings of type regex
Thu, Apr 13, 8:57 PM
amckinley closed D17684: Add validation for config settings of type regex by committing rP980d6cb70b94: Add validation for config settings of type regex.
Thu, Apr 13, 8:57 PM
amckinley committed rPbfffd807d645: Change syntax highlighting for custom phabricator dot configs (authored by amckinley).
Change syntax highlighting for custom phabricator dot configs
Thu, Apr 13, 8:55 PM
amckinley closed D17682: Change syntax highlighting for custom phabricator dot configs by committing rPbfffd807d645: Change syntax highlighting for custom phabricator dot configs.
Thu, Apr 13, 8:55 PM
amckinley created D17684: Add validation for config settings of type regex.
Thu, Apr 13, 8:52 PM
amckinley added a revision to T12532: `syntax.filemap` does not validate input: D17684: Add validation for config settings of type regex.
Thu, Apr 13, 8:52 PM · Contributor Onboarding, Config, Bug Report
amckinley claimed T12532: `syntax.filemap` does not validate input.
Thu, Apr 13, 8:25 PM · Contributor Onboarding, Config, Bug Report
amckinley added a revision to T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations: D17682: Change syntax highlighting for custom phabricator dot configs.
Thu, Apr 13, 8:23 PM · Contributor Onboarding, Bug Report
amckinley created D17682: Change syntax highlighting for custom phabricator dot configs.
Thu, Apr 13, 8:23 PM
epriestley awarded T12524: Modernize Countdown a Mountain of Wealth token.
Thu, Apr 13, 8:19 PM · Countdown