Page MenuHomePhabricator

amckinley (Austin McKinley)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (412 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

amckinley accepted D19976: Update `bin/auth` MFA commands for the new "MFA Provider" indirection layer.

itsallcomingtogether

Fri, Jan 18, 5:56 PM

Yesterday

amckinley accepted D19993: Remove "metamta.*.subject-prefix" options.
Thu, Jan 17, 9:53 PM
amckinley accepted D19991: Allow administrators to provide custom welcome text when welcoming users on the profile workflow.
Thu, Jan 17, 9:47 PM
amckinley accepted D19990: When password auth is not enabled, don't tell users to set a password in welcome email.
Thu, Jan 17, 9:44 PM
amckinley accepted D19989: Move "Welcome" mail generation out of PhabricatorUser.
Thu, Jan 17, 9:43 PM
amckinley accepted D19987: Don't bounce mail messages if any recipient was reserved.
Thu, Jan 17, 9:39 PM
amckinley accepted D19979: Allow Phortune accounts to customize their billing address and name.
Thu, Jan 17, 12:07 AM
amckinley accepted D19978: Fix an issue where "Import Columns" could fail on a board for a project with milestones.
Thu, Jan 17, 12:03 AM

Wed, Jan 16

amckinley accepted D19976: Update `bin/auth` MFA commands for the new "MFA Provider" indirection layer.

I'm still marking this as accepted; just put it back in "Changes Planned" if either of my issues resonates with you.

Wed, Jan 16, 11:53 PM
amckinley accepted D19969: Apply inverse edge edits after committing primary object edits.

I claim with only limited reservations that I totally understand this change.

Wed, Jan 16, 11:29 PM
amckinley accepted D19986: Wordsmith inbound mail documentation more thoroughly.
Wed, Jan 16, 10:31 PM
amckinley accepted D19975: Convert user MFA factors to point at configurable "MFA Providers", not raw "MFA Factors".

This all probably falls into "Couple of things not covered here:", so feel free to say "yep yep that's all coming in a subsequent diff" instead of typing it out again, but...

Wed, Jan 16, 10:00 PM
amckinley accepted D19973: Update inbound and outbound email documentation.

Two actual typos; feel free to ignore the rest if you disagree with the language changes.

Wed, Jan 16, 9:45 PM
amckinley accepted D19985: Harden "Filesystem::readRandomInteger()" against misuse and builtin failure.
Wed, Jan 16, 8:53 PM
amckinley accepted D19984: Add "command" vs "flag" corrector modes and refuse to correct "--start" into "restart".
Wed, Jan 16, 8:17 PM
amckinley committed rPb98d46ce7d28: Resurrect setup check for cluster.mailers (authored by amckinley).
Resurrect setup check for cluster.mailers
Wed, Jan 16, 8:14 PM
amckinley closed D19964: Resurrect setup check for cluster.mailers.
Wed, Jan 16, 8:14 PM
amckinley added inline comments to D19955: Refactor mail to produce an intermediate "bag of strings" object in preparation for SMS.
Wed, Jan 16, 7:34 PM
amckinley added a comment to D19971: Add a Twilio SMS message adapter.

Used this test script to send myself some text messages...

Wed, Jan 16, 7:26 PM
amckinley added a comment to D19965: Update the "SES" and "sendmail" mailers for the new API; remove "encoding".

Aha, this is what triggered my deja vu: D19959.

Wed, Jan 16, 7:16 PM
amckinley added inline comments to D19956: Update Postmark adapter for multiple mail media.
Wed, Jan 16, 7:15 PM
amckinley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

When I was messing around with SMS sending last week, I put a rough cut of this together that is capable of sending an SMS using SNS, which has almost the same API as SES: D19982. I can tackle this unless you're already in the middle of it.

Wed, Jan 16, 7:11 PM · Mail
amckinley planned changes to D19982: Add infrastructure for sending SMS via AWS SNS.
Wed, Jan 16, 7:11 PM
amckinley requested review of D19982: Add infrastructure for sending SMS via AWS SNS.
Wed, Jan 16, 7:11 PM
amckinley added a revision to T920: Provide SMS Support: D19982: Add infrastructure for sending SMS via AWS SNS.
Wed, Jan 16, 7:09 PM · Restricted Project, Herald
amckinley added a revision to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: D19982: Add infrastructure for sending SMS via AWS SNS.
Wed, Jan 16, 7:09 PM · Mail
amckinley accepted D19965: Update the "SES" and "sendmail" mailers for the new API; remove "encoding".

I definitely reviewed almost this exact same code, but I have completely lost it in the stack of email-related changes recently. If I recall, I complained about the unused variable, checking for truthiness instead of using strlen for all the fields that PHPMailer wants, and the base64 attachment encoding thing. The truthiness checks make sense now that all those properties are objects instead of bare strings.

Wed, Jan 16, 6:59 PM
amckinley accepted D19955: Refactor mail to produce an intermediate "bag of strings" object in preparation for SMS.

This was pretty exhausting to review because I had to give up on figuring out what was just moved and what was actually new, so I just read all of everything and spot checked that a few things like the must encrypt implementation got moved faithfully.

Wed, Jan 16, 6:52 PM
amckinley accepted D19981: Use "random_bytes()" under newer PHP, and introduce "Filesystem::readRandomInteger()".
Wed, Jan 16, 6:00 PM
amckinley accepted D19977: Don't require "CAN_EDIT" to watch/unwatch a project.
Wed, Jan 16, 5:49 PM
amckinley accepted D19980: Add timeout support to the Postmark future.
Wed, Jan 16, 5:48 PM
amckinley accepted D19970: Fix an issue where "CC"-only email improperly wiped CC addresses.
Wed, Jan 16, 2:15 AM
amckinley accepted D19972: Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject.
Wed, Jan 16, 2:13 AM
amckinley accepted D19968: Fix an issue where transactions in mail were always rendered as text.
Wed, Jan 16, 2:10 AM
amckinley accepted D19974: Prevent application email addresses from shadowing user email addresses.
Wed, Jan 16, 2:09 AM
amckinley accepted D19971: Add a Twilio SMS message adapter.
Wed, Jan 16, 2:08 AM
amckinley accepted D19967: Correct a zero-based month tooltip on burnup charts.
Wed, Jan 16, 2:00 AM

Mon, Jan 14

amckinley accepted D19966: Fix bad "SMTP" and "cluster.mailers" default value.
Mon, Jan 14, 8:07 PM

Sat, Jan 12

amckinley updated the diff for D19964: Resurrect setup check for cluster.mailers.

Fix weird indentation.

Sat, Jan 12, 1:35 AM

Fri, Jan 11

amckinley added a comment to D19964: Resurrect setup check for cluster.mailers.

This could also be rewritten as if ($no_cluster_mailers_configured && $some_deprecated_mailer_configured) to target this message more narrowly.

Fri, Jan 11, 10:59 PM
amckinley requested review of D19964: Resurrect setup check for cluster.mailers.
Fri, Jan 11, 10:28 PM
amckinley created U43 Configuring Outbound Email.
Fri, Jan 11, 10:18 PM
amckinley committed rPe8069dfe31c8: Remove dead symlink (authored by amckinley).
Remove dead symlink
Fri, Jan 11, 12:28 AM
amckinley closed D19963: Remove dead symlink.
Fri, Jan 11, 12:27 AM

Thu, Jan 10

amckinley accepted D19961: Update the SMTP (PHPMailer) adapter for the new mail API; remove "encoding" and "mailer".
Thu, Jan 10, 4:58 PM
amckinley accepted D19960: Upgrade Sendgrid to the modern mailer API; removes "api-user" option.
Thu, Jan 10, 4:52 PM
amckinley accepted D19959: Update Mailgun adapter for the new mail adapter API.
Thu, Jan 10, 4:32 PM
amckinley requested review of D19963: Remove dead symlink.
Thu, Jan 10, 4:01 PM

Sat, Jan 5

amckinley accepted D19957: Update Mail test adapter for the newer adapter API and make all tests pass.
Sat, Jan 5, 12:06 AM
amckinley accepted D19956: Update Postmark adapter for multiple mail media.
Sat, Jan 5, 12:03 AM

Fri, Jan 4

amckinley accepted D19954: Rename "MetaMTA" mail attachments and add more mail message objects.
Fri, Jan 4, 10:29 PM
amckinley accepted D19953: Prevent inbound processing of the "void/placeholder" address and other reserved addresses.
Fri, Jan 4, 10:25 PM
amckinley accepted D19958: Make blame UI recover gracefully if Identities haven't been built yet for a commit.
Fri, Jan 4, 10:21 PM
amckinley accepted D19952: Allow multiple mail receivers to react to an individual email.
Fri, Jan 4, 9:59 PM
amckinley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

This doesn't help if you're committed to that Apache life, but FWIW I'm using nginx 1.15.8 via Homebrew on Mojave without any issues.

Fri, Jan 4, 9:04 PM · Infrastructure
amckinley accepted D19950: Consolidate some application email receiver code in preparation for API changes.
Fri, Jan 4, 12:01 AM

Thu, Jan 3

amckinley accepted D19949: Remove "metamta.insecure-auth-with-reply-to" Config option.
Thu, Jan 3, 11:32 PM
amckinley accepted D19948: Extract some email address utility code from the receiver stack.
Thu, Jan 3, 11:26 PM
amckinley accepted D19947: Drop empty inbound mail at the beginning of the receive workflow, not inside object handlers.
Thu, Jan 3, 8:35 PM
amckinley accepted D19946: Remove "phabricator.csrf-key" and upgrade CSRF hashing to SHA256.
Thu, Jan 3, 8:18 PM
amckinley accepted D19945: Upgrade object reply addresses to SHA256 and remove "phabricator.mail-key".
Thu, Jan 3, 7:42 PM
amckinley accepted D19943: Pass timeline view data to comment previews, restoring Differential comment previews.
Thu, Jan 3, 7:41 PM
amckinley accepted D19941: Remove an old digest in Celerity code and some obsolete configuration options.
Thu, Jan 3, 7:36 PM
amckinley committed rP65e89c239e7e: Add status to PhabricatorProjectQuery->getPagingValueMap() (authored by amckinley).
Add status to PhabricatorProjectQuery->getPagingValueMap()
Thu, Jan 3, 7:34 PM
amckinley closed D19951: Add status to PhabricatorProjectQuery->getPagingValueMap().
Thu, Jan 3, 7:34 PM
amckinley requested review of D19951: Add status to PhabricatorProjectQuery->getPagingValueMap().
Thu, Jan 3, 7:28 PM
amckinley committed rP05a9474138cb: Raise warning when accidentally submitting Conduit parameters as a JSON-encoded… (authored by amckinley).
Raise warning when accidentally submitting Conduit parameters as a JSON-encoded…
Thu, Jan 3, 1:31 AM
amckinley closed D19944: Raise warning when accidentally submitting Conduit parameters as a JSON-encoded body.
Thu, Jan 3, 1:31 AM
amckinley accepted D19942: Remove "metamta.domain" and "metamta.placeholder-to-recipient" config options.
Thu, Jan 3, 1:29 AM
amckinley requested review of D19944: Raise warning when accidentally submitting Conduit parameters as a JSON-encoded body.
Thu, Jan 3, 1:28 AM
amckinley added a comment to D19937: Add a parameterized Future for Twilio API calls.

I was looking around for a second provider but didn't realize SNS supported it. "Plivo" seems like another one, do you know of any more? I'd ideally like to aim for ~3 reasonably sensible providers so we can do fallback. Googling hits a lot of stuff but I've never heard of any of it.

Thu, Jan 3, 12:42 AM
amckinley accepted D19939: Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach.
Thu, Jan 3, 12:32 AM
amckinley accepted D19940: Remove all legacy configuration options for mailers.
Thu, Jan 3, 12:32 AM
amckinley accepted D19938: Remove Twilio-PHP API external.

killitwithfire

Thu, Jan 3, 12:24 AM
amckinley accepted D19937: Add a parameterized Future for Twilio API calls.

This is a Good Thing regardless of how we go forward, but FWIW, AWS also supports sending SMS via SNS: https://aws.amazon.com/sns/sms-pricing/

Thu, Jan 3, 12:21 AM
amckinley accepted D19935: Add a skeleton for configurable MFA provider types.
Thu, Jan 3, 12:18 AM

Wed, Jan 2

amckinley added a comment to T13230: Native Applications.

Does anyone have experience with an existing Push Notifications As A Service provider? I would naively suggest AWS SNS, because we already depend on other AWS services and it's free for the first 1m pushes, and then $0.50/1m pushes after that. It also wouldn't raise any new data privacy issues for Phacility customers since we wouldn't have to deliver pushes outside of our existing VPC infrastructure. List of supported push targets:

Wed, Jan 2, 8:25 PM · Phacility
amckinley created P2113 (An Untitled Masterwork).
Wed, Jan 2, 8:10 PM
amckinley accepted D19936: Fix a qsprintf() issue in mail queries.
Wed, Jan 2, 7:46 PM

Mon, Dec 24

amckinley accepted D19934: Restore a Mock key to Pholio Images.
Mon, Dec 24, 10:48 PM
amckinley accepted D19929: In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode".
Mon, Dec 24, 10:43 PM
amckinley accepted D19928: Implement "@{config:...}" as a real Remarkup rule.
Mon, Dec 24, 10:16 PM
amckinley accepted D19927: Remove old Phrequent propery rendering code and show "Time Spent" in higher precision.
Mon, Dec 24, 10:14 PM
amckinley accepted D19931: Statically detect "continue" inside "switch".
Mon, Dec 24, 9:25 PM
amckinley accepted D19932: Fix the last remaining (?) continue inside switch.
Mon, Dec 24, 9:20 PM
amckinley accepted D19926: Implement Pholio file add/remove transactions without "applyInitialEffects".
Mon, Dec 24, 9:17 PM
amckinley accepted D19924: Implement "replace" transactions in Pholio without "applyInitialEffects".
Mon, Dec 24, 9:14 PM

Thu, Dec 20

amckinley accepted D19923: Reduce the amount of weird "static" and "cache" behavior in Pholio query classes.
Thu, Dec 20, 10:42 PM
amckinley accepted D19922: Remove the onboard "mailKey" from Pholio Mocks.
Thu, Dec 20, 10:21 PM
amckinley committed rP2de632d4fe98: Update continue/break for php 7.3 (authored by amckinley).
Update continue/break for php 7.3
Thu, Dec 20, 10:12 PM
amckinley closed D19925: Update continue/break for php 7.3.
Thu, Dec 20, 10:12 PM
amckinley accepted D19921: Make the Pholio Mock "getImages" / "getAllImages" API more clear.
Thu, Dec 20, 10:00 PM
amckinley requested review of D19925: Update continue/break for php 7.3.
Thu, Dec 20, 9:55 PM
amckinley accepted D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.
Thu, Dec 20, 9:08 PM
amckinley accepted D19919: Remove obsolete, no-op implementations of "willRenderTimeline()".

https://en.wikipedia.org/wiki/Semantic_satiation

Thu, Dec 20, 8:29 PM
amckinley accepted D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface.
Thu, Dec 20, 8:25 PM
amckinley committed rPc72d29f401e2: Cleanup some clustering rough edges (authored by amckinley).
Cleanup some clustering rough edges
Thu, Dec 20, 7:19 PM
amckinley closed D19917: Cleanup some clustering rough edges.
Thu, Dec 20, 7:19 PM
amckinley requested review of D19917: Cleanup some clustering rough edges.
Thu, Dec 20, 12:28 AM
amckinley edited the content of Developer Setup.
Thu, Dec 20, 12:15 AM