amckinley (Austin McKinley)Administrator
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2011, 8:41 PM (347 w, 3 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

amckinley accepted D18712: Clarify acceptable values for `--threshold` in `search ngrams`.

moof

Tue, Oct 17, 9:30 PM
amckinley accepted D18711: Make "line" and "char" strictly optional in ArcanistLintMessage.
Tue, Oct 17, 9:24 PM
amckinley accepted D18710: Parameterize the common ngrams threshold.
Tue, Oct 17, 9:08 PM

Sat, Oct 14

amckinley accepted D18708: Tweak rate limiting point counts for omnipotent users.
Sat, Oct 14, 4:41 PM

Fri, Oct 13

amckinley accepted D18707: Make `bin/storage dump` insert CREATE DATABASE and USE statements.
Fri, Oct 13, 9:28 PM
amckinley accepted D18703: Modularize rate/connection limits in Phabricator.
Fri, Oct 13, 7:50 PM
amckinley accepted D18702: Allow Phabricator to run with "enable_post_data_reading" disabled.
Fri, Oct 13, 7:43 PM
amckinley accepted D18706: Allow duplicates and merged-in tasks to be queried with `edge.search`.
Fri, Oct 13, 7:25 PM

Thu, Oct 12

amckinley accepted D18704: Fix a bug which prevented Conduit futures from having parallelism limited effectively.
Thu, Oct 12, 7:25 PM

Wed, Oct 11

amckinley accepted D18701: Stream "multipart/form-data" file uploads to disk.

Do we currently write uploads to disk temporarily? I guess rate limiting will prevent this, but I'm worried this opens ourselves up to a DoS by filling disks (especially if there's a problem with S3 or whatever persistence layer that could cause these files to accumulate).

Wed, Oct 11, 8:34 PM

Tue, Oct 10

amckinley accepted D18700: Add a rough "multipart/form-data" stream parser.

lgtm

Tue, Oct 10, 9:04 PM
amckinley accepted D18699: Add a rough HTTP header value parser.
Tue, Oct 10, 8:29 PM
amckinley accepted D18696: For backup persitsence, mark the "common ngrams" table as a data table, not an index table.
Tue, Oct 10, 7:00 PM

Mon, Oct 9

amckinley created Image Macro "hawkward".
Mon, Oct 9, 7:00 PM

Fri, Oct 6

amckinley accepted D18692: Bail out of PhabricatorRepositoryGraphCache more aggressively after cache fills.
Fri, Oct 6, 8:31 PM
amckinley accepted D18690: Add "bin/search query" for debugging query execution.
Fri, Oct 6, 3:33 PM

Thu, Oct 5

amckinley accepted D18687: Add a garbage collector for common ngrams.
Thu, Oct 5, 6:01 PM

Wed, Oct 4

amckinley accepted D18682: Add "persistence" types (data, cache, or index) to tables, and tweak what "storage dump" dumps.
Wed, Oct 4, 7:06 PM
amckinley accepted D18679: Dump tables one at a time, rather than all at once.

howneatisthat

Wed, Oct 4, 6:59 PM
amckinley accepted D18681: Enable hovercards for the "Task Graph" UI in Maniphest.
Wed, Oct 4, 6:04 PM
amckinley added a comment to D18679: Dump tables one at a time, rather than all at once.

This presumably affects the restore workflow as well, right? This looks good, but I don't think we should land it until the corresponding diff for restore is ready.

Wed, Oct 4, 5:59 PM
amckinley edited the content of Developer Setup.
Wed, Oct 4, 5:53 PM
amckinley closed T12991: Enable notifications for admin.phacility.com as Resolved.
Wed, Oct 4, 5:49 PM
amckinley added a revision to T12991: Enable notifications for admin.phacility.com: Unknown Object (Differential Revision).
Wed, Oct 4, 5:49 PM
amckinley created T13002: "Connecting..." UI for unreachable notifications server is slightly broken.
Wed, Oct 4, 4:33 PM
amckinley accepted D18678: Fix parsing of Git branches with common and useful name "0".
Wed, Oct 4, 3:29 PM
amckinley accepted D18677: Fix a fatal on user email settings when `account.editable` is disabled.
Wed, Oct 4, 3:26 PM

Tue, Oct 3

amckinley committed rPbc9de7eceef0: Typo fix (authored by amckinley).
Typo fix
Tue, Oct 3, 10:10 PM
amckinley closed D18674: Typo fix.
Tue, Oct 3, 10:10 PM
amckinley accepted D18676: Add a "/source/..." URI for Diffusion commits which redirects.

Just out of curiosity, what happens if a commit identifier collides with more than one commit hash?

Tue, Oct 3, 8:05 PM
amckinley added a comment to T12991: Enable notifications for admin.phacility.com.

I realized I don't really understand the architecture of the notifications system or our deployment of it. Tell me what I got right:

Tue, Oct 3, 8:00 PM
amckinley created D18674: Typo fix.
Tue, Oct 3, 7:20 PM
amckinley accepted D18672: Allow the Ferret engine to remove "common" ngrams from the index.
Tue, Oct 3, 4:45 PM
amckinley accepted D18673: Add a workflow for populating (or depopulating) the common ngrams table.
Tue, Oct 3, 4:39 PM
amckinley added a comment to D18672: Allow the Ferret engine to remove "common" ngrams from the index.

Do we we need distinct, per-app tables for tracking common ngrams? I'm sure there's some variance between which ngrams are "common", but I'm not sure I can see the distribution affecting search result quality.

Tue, Oct 3, 4:34 PM

Mon, Oct 2

amckinley accepted D18669: Properly cache terminal width and dirty on SIGWINCH.
Mon, Oct 2, 7:51 PM
amckinley accepted D18668: In "Move Tasks to Column...", show only visible columns.
Mon, Oct 2, 6:40 PM
amckinley accepted D18667: Fix transaction queries using withComments() for transactions with no comments.
Mon, Oct 2, 3:31 PM
amckinley accepted D18666: Fix an exception in the hyperlink remarkup rule for unparseable URIs.
Mon, Oct 2, 3:25 PM

Sat, Sep 30

amckinley closed T12998: Image macros not working in Differential as Resolved.

Ahhh, so you can't have multiple adjacent macros on the same line; that was my problem. I guess that could be special-cased, which would be linear with the number of "tokens that are macros coming before a non-macro" appearing on a line, but I'm probably the only one clamoring for multiple horizontally aligned parrots.

Sat, Sep 30, 1:00 AM · Differential, Macros
amckinley created T12998: Image macros not working in Differential.
Sat, Sep 30, 12:32 AM · Differential, Macros
amckinley accepted D18665: Rough cut of "Move tasks to column...".

Whoooo this is going to blow people's MINDS.

Sat, Sep 30, 12:28 AM

Fri, Sep 29

amckinley accepted D18663: Mark Owners package reviewers which own nothing in the current diff.

Looks good for a rough cut. I like the idea of a "collapse all files I don't have package authority over" button.

Fri, Sep 29, 9:56 PM
amckinley accepted D18664: Correct bad context path when doing pattern search inside a repository.
Fri, Sep 29, 9:51 PM
amckinley accepted D18661: Fix fatal when searching for "r matey prepare to be boarded".

yarrrr

Fri, Sep 29, 4:41 PM

Thu, Sep 28

amckinley accepted D18660: Allow the fulltext index to select only transactions with comments.
Thu, Sep 28, 7:54 PM
amckinley accepted D18657: When we purge the request cache, also force PHP to collect cycles.

frowncat

Thu, Sep 28, 6:53 PM

Wed, Sep 27

amckinley accepted D18654: Support automatic "Depends On" detection in Mercurial.
Wed, Sep 27, 5:31 PM
amckinley accepted D18649: Improve performance of Ferret engine ngram extraction, particularly for large input strings.

I've spent a lot of time staring at this and I'm pretty convinced it works. Maybe add a few more unit tests for strings of length {0,1,2}?

Wed, Sep 27, 5:28 PM
amckinley accepted D18651: Make "arc diff" sort of detect dependent revisions.
Wed, Sep 27, 5:25 PM
amckinley accepted D18648: Improve search stemmer performance for large inputs.
Wed, Sep 27, 5:15 PM
amckinley accepted D18645: Modularize "arc lint" renderers.
Wed, Sep 27, 5:14 PM

Tue, Sep 26

amckinley accepted D18647: Improve Ferret engine indexing performance for large blocks of text.
Tue, Sep 26, 2:22 AM
amckinley accepted D18646: Provide ConsoleView classes for "[ OKAY ] Good things happened." console lines.

https://xkcd.com/927/

Tue, Sep 26, 2:19 AM

Mon, Sep 25

amckinley closed T12989: Phacility Deployment: 2017 Week 38 as Resolved.
Mon, Sep 25, 7:57 PM · Ops, Phacility
amckinley accepted D18644: Remove "arc lint --only-changed".
Mon, Sep 25, 7:56 PM
amckinley accepted D18641: Remove "async lint" from `arc lint`.
Mon, Sep 25, 6:31 PM
amckinley accepted D18642: Remove "arc lint --only-new".
Mon, Sep 25, 6:31 PM
amckinley accepted D18643: Remove "arc lint --cache".
Mon, Sep 25, 6:30 PM
amckinley accepted D18640: Remove "arc diff --no-diff".

Red diffs are best diffs.

Mon, Sep 25, 6:30 PM

Sat, Sep 23

amckinley added a comment to T12989: Phacility Deployment: 2017 Week 38.

We had to write some code to make phage work with exec and fix the phd stop flow to use --force, but this deploy completed successfully.

Sat, Sep 23, 6:14 PM · Ops, Phacility
amckinley edited the content of Phacility Cluster Documentation.
Sat, Sep 23, 3:55 PM
amckinley created Deploy Process.
Sat, Sep 23, 3:54 PM

Fri, Sep 22

amckinley accepted D18635: Improve search highlighting for CJK and substring queries.

Looks good (minus nit), assuming lint is a false positive.

Fri, Sep 22, 6:08 PM
amckinley accepted D18634: Default CJK query terms to "substring" mode, not "term" mode.
Fri, Sep 22, 4:59 PM

Wed, Sep 20

amckinley accepted D18633: Update an old SSH redirect URI when editing a bot's SSH keys.
Wed, Sep 20, 9:46 PM
amckinley accepted D18631: Correct lint rendering when patching trailing whitespace in files.
Wed, Sep 20, 7:04 PM
amckinley created T12991: Enable notifications for admin.phacility.com.
Wed, Sep 20, 6:27 PM
amckinley accepted D18630: More completely explain why we're refusing to send reset mail to an unverified address.
Wed, Sep 20, 5:41 PM

Tue, Sep 19

amckinley accepted D18629: Fix an error in Diffusion when the Owners application is uninstalled.
Tue, Sep 19, 4:40 PM

Mon, Sep 18

amckinley accepted D18626: Align most revision actions to the new "Draft" state.
Mon, Sep 18, 11:55 PM
amckinley accepted D18627: Prepare revision mail for the "Draft" status.
Mon, Sep 18, 11:52 PM
amckinley accepted D18628: Create revisions into "Draft", publish them when builds finish.
Mon, Sep 18, 11:51 PM

Sep 18 2017

amckinley accepted D18623: Guarantee the `key_position` key is created properly.
Sep 18 2017, 8:00 PM
amckinley accepted D18624: Fix an issue where "bin/differential migrate-hunk" could decompress data.
Sep 18 2017, 7:59 PM
amckinley accepted D18625: Add a "Draft" state for revisions, and action bucket support.
Sep 18 2017, 7:58 PM
amckinley accepted D18622: Spell "Relevance" correctly.
Sep 18 2017, 4:36 PM

Sep 16 2017

amckinley accepted D18619: Fix "Author's projects" Herald rules for revisions and diffs.
Sep 16 2017, 12:53 AM

Sep 15 2017

amckinley accepted D18616: Swap "-R" and "serve" argument order for Mercurial.
Sep 15 2017, 7:42 PM
amckinley accepted D18615: Update utility "bin/repository parents" workflow to work with RefPosition.
Sep 15 2017, 4:30 PM
amckinley accepted D18614: Update major RefCursor callsites to work properly with RefPosition.

I only vaguely understand what this accomplishes, but I trust that we'll break secure before it goes out everywhere.

Sep 15 2017, 4:28 PM
amckinley added a comment to D18613: Remove obsolete columns from RefCursor table.

Yeah, I wasn't particularly worried about the race itself, more that if someone did hit it, they'd be kind of screwed since re-running the migration that fails (this one) wouldn't fix the problem. They'd have to figure out how to manually re-run 20170915.ref.01.migrate.php. At least if the drop dupes/add constraint work happened in the same migration, a user could just attempt bin/storage upgrade again and just not get incredibly unlucky twice in a row.

Sep 15 2017, 4:06 PM
amckinley accepted D18611: Provide an explicit "-R" flag to "hg serve".
Sep 15 2017, 3:40 PM
amckinley accepted D18613: Remove obsolete columns from RefCursor table.
Sep 15 2017, 3:39 PM
amckinley accepted D18610: Pass HGPLAIN in the environment when testing "hg" version.
Sep 15 2017, 3:35 PM
amckinley accepted D18609: Fix an outdated HTML anchor link in Diffusion table of contents.
Sep 15 2017, 3:34 PM
amckinley accepted D18612: Migrate RefCursor data to RefPosition table.
Sep 15 2017, 3:32 PM

Sep 14 2017

amckinley committed rPc71cb944a428: Add edit methods for Almanac services and devices (authored by amckinley).
Add edit methods for Almanac services and devices
Sep 14 2017, 9:33 PM
amckinley closed D18605: Add edit methods for Almanac services and devices.
Sep 14 2017, 9:33 PM
amckinley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

What's the best way to add API endpoints for resources like bindings? Call it almanac.create_binding and have it take a service and an interface as arguments?

Sep 14 2017, 8:23 PM · Conduit, Almanac, Ops, Phacility
amckinley created D18605: Add edit methods for Almanac services and devices.
Sep 14 2017, 8:22 PM
amckinley committed rARCdf81d79d77f8: Add explicit limits to unit test/lint error names (authored by amckinley).
Add explicit limits to unit test/lint error names
Sep 14 2017, 7:12 PM
amckinley added a commit to T12981: Explicitly limit lint and unit test names to 255 characters: rARCdf81d79d77f8: Add explicit limits to unit test/lint error names.
Sep 14 2017, 7:12 PM · Harbormaster, Conduit
amckinley added a comment to D18603: Add explicit limits to unit test/lint error names.

Also, I landed this onto experimental. Do we want this on master as well? If so, what's the best way to accomplish that? arc land --revision D18603 --onto master?

Sep 14 2017, 6:43 PM
amckinley committed rARC14150123acae: Add explicit limits to unit test/lint error names (authored by amckinley).
Add explicit limits to unit test/lint error names
Sep 14 2017, 6:42 PM
amckinley closed D18603: Add explicit limits to unit test/lint error names.
Sep 14 2017, 6:42 PM
amckinley closed T12981: Explicitly limit lint and unit test names to 255 characters as Resolved by committing rARC14150123acae: Add explicit limits to unit test/lint error names.
Sep 14 2017, 6:42 PM · Harbormaster, Conduit
amckinley added a comment to D18603: Add explicit limits to unit test/lint error names.

Do you still want me to add the same checks to HarbormasterBuildUnitMessage->newFromDictionary()? AFAICT, that would just move the error message from save time to creation time.

Sep 14 2017, 6:41 PM
amckinley added a revision to T12981: Explicitly limit lint and unit test names to 255 characters: D18603: Add explicit limits to unit test/lint error names.
Sep 14 2017, 6:28 PM · Harbormaster, Conduit
amckinley created D18603: Add explicit limits to unit test/lint error names.
Sep 14 2017, 6:28 PM