Page MenuHomePhabricator

Enrich "draft", "summary", and "testPlan" transactions from Differential in ""

Authored by epriestley on May 9 2019, 4:09 PM.



See PHI1232, which describes a reasonable use case for wanting information about the "draft" ("Hold as Draft / Do Not Auto-Promote") flag.

Also, flesh out "testPlan" and "summary". It's possible these "blob of remarkup" fields might have metadata some day (e.g., a rendered version or a list of PHIDs or something), but we could add more keys, and we already have some other transactions which work like this.

Test Plan

Used "" to fetch these transaction types, saw type information and metadata.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 9 2019, 4:09 PM
epriestley requested review of this revision.May 9 2019, 4:10 PM
amckinley accepted this revision.May 16 2019, 12:59 PM
amckinley added inline comments.

Does this (and the change in DifferentialRevisionUpdateTransaction) reflect an API change that happened at some point, or were these arguments just named incorrectly from the beginning?

This revision is now accepted and ready to land.May 16 2019, 12:59 PM

I only blamed around a little bit, but I'm nearly certain they were named incorrectly from the beginning.

I think they got introduced at the same time as ConduitResultInterface, which looks somewhat similar but does have an $object parameter, and a transaction is technically an $object so this just escaped notice.

In either case, not an API change, just a nomenclature change.