Page MenuHomePhabricator

Fix a potential double-prompt in "arc land" when landing with ongoing builds
ClosedPublic

Authored by epriestley on May 3 2019, 5:16 PM.
Tags
None
Referenced Files
F14810035: D20494.id.diff
Sun, Jan 26, 9:36 PM
Unknown Object (File)
Sat, Jan 25, 5:00 AM
Unknown Object (File)
Sat, Jan 25, 5:00 AM
Unknown Object (File)
Wed, Jan 22, 7:35 PM
Unknown Object (File)
Sun, Jan 19, 11:37 AM
Unknown Object (File)
Fri, Jan 17, 3:51 PM
Unknown Object (File)
Fri, Jan 3, 7:10 PM
Unknown Object (File)
Tue, Dec 31, 7:54 PM
Subscribers
None

Details

Reviewers
amckinley
Summary

The recently-added, build-plan-behavior-aware check here does all of its own prompting, so we should skip the other prompting if it doesn't throw.

Test Plan

Will arc land something sketchy sooner or later.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable