Page MenuHomePhabricator

Fix a potential double-prompt in "arc land" when landing with ongoing builds
ClosedPublic

Authored by epriestley on May 3 2019, 5:16 PM.

Details

Reviewers
amckinley
Summary

The recently-added, build-plan-behavior-aware check here does all of its own prompting, so we should skip the other prompting if it doesn't throw.

Test Plan

Will arc land something sketchy sooner or later.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 3 2019, 5:16 PM
epriestley requested review of this revision.May 3 2019, 5:17 PM
amckinley accepted this revision.May 14 2019, 2:38 PM
This revision is now accepted and ready to land.May 14 2019, 2:38 PM