Page MenuHomePhabricator

Remove WePay support from Phortune, and Restful/Httpful dependencies
ClosedPublic

Authored by epriestley on May 13 2019, 7:06 PM.

Details

Reviewers
amckinley
Summary

Ref PHI1166. I'm documenting our dependencies, and we have approximately 5,000 lines of external code to support WePay as a Phortune provider. We don't use it, I'm almost certain it doesn't work, and we have no plans to use it in the near future. If we did pursue it, I'd probably just wrap the API in a 100-line WePayFuture anyway since 5K lines of dependencies to make a couple method calls is ridiculous.

Test Plan

Grepped for wepay, httpful, restful.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 13 2019, 7:06 PM
epriestley requested review of this revision.May 13 2019, 7:08 PM
This revision is now accepted and ready to land.May 14 2019, 2:48 PM