Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
F18825800: D20459.diff
Fri, Oct 24, 12:22 AM
F18774421: D20459.diff
Fri, Oct 10, 7:24 AM
F18736825: D20459.id48834.diff
Wed, Oct 1, 7:55 AM
F18735739: D20459.id48813.diff
Wed, Oct 1, 3:09 AM
F18735401: D20459.diff
Wed, Oct 1, 1:13 AM
F18672179: D20459.id48813.diff
Thu, Sep 25, 6:55 AM
F18657096: D20459.diff
Sep 23 2025, 12:28 AM
F18610642: D20459.id.diff
Sep 14 2025, 5:16 AM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable