Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
F14077137: D20459.diff
Thu, Nov 21, 9:42 PM
Unknown Object (File)
Wed, Nov 20, 8:52 PM
Unknown Object (File)
Mon, Nov 18, 5:28 PM
Unknown Object (File)
Fri, Nov 15, 3:11 AM
Unknown Object (File)
Sun, Nov 10, 8:47 PM
Unknown Object (File)
Wed, Nov 6, 10:59 PM
Unknown Object (File)
Sun, Oct 27, 6:58 AM
Unknown Object (File)
Oct 22 2024, 2:19 AM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable