Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 11:16 AM
Unknown Object (File)
Fri, Jan 17, 11:02 PM
Unknown Object (File)
Sat, Jan 4, 11:35 AM
Unknown Object (File)
Thu, Jan 2, 4:07 AM
Unknown Object (File)
Dec 18 2024, 12:35 AM
Unknown Object (File)
Dec 9 2024, 10:21 AM
Unknown Object (File)
Nov 27 2024, 9:09 AM
Unknown Object (File)
Nov 26 2024, 6:32 AM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable