Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
F18082269: D20459.id48834.diff
Tue, Aug 5, 4:51 AM
F17817464: D20459.id.diff
Fri, Jul 25, 11:35 PM
F17799706: D20459.diff
Fri, Jul 25, 5:23 AM
F17765267: D20459.diff
Wed, Jul 23, 1:42 AM
F17635039: D20459.diff
Fri, Jul 11, 12:46 AM
Unknown Object (File)
Jun 29 2025, 7:02 AM
Unknown Object (File)
Jun 28 2025, 5:46 PM
Unknown Object (File)
Jun 26 2025, 8:35 PM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable