Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
F19542708: D20459.diff
Jan 22 2026, 11:50 AM
F19542655: D20459.diff
Jan 22 2026, 11:30 AM
F19540510: D20459.id.diff
Jan 21 2026, 10:52 PM
F19540416: D20459.diff
Jan 21 2026, 10:27 PM
F19510451: D20459.diff
Jan 11 2026, 9:42 AM
F19063168: D20459.id.diff
Nov 29 2025, 5:58 PM
F19057895: D20459.diff
Nov 29 2025, 12:21 AM
F18828781: D20459.id.diff
Oct 24 2025, 6:11 PM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable