Page MenuHomePhabricator

Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field

Authored by epriestley on Apr 15 2019, 4:48 PM.



Depends on D20426. Ref T13277. The new behavior is to fire Herald only once a commit becomes reachable from a permanent ref (previously, an "Autoclose" branch).

That means that every "Commit" Herald rule implicitly has this field as a condition, and it no longer does anything.

Test Plan

Wrote a Herald rule, saw this as an option in the "Deprecated" section.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 15 2019, 4:48 PM
epriestley requested review of this revision.Apr 15 2019, 4:49 PM
amckinley accepted this revision.Apr 17 2019, 8:08 PM

I guess it's not worth cleaning this up and removing the class + DB rows since it's just a no-op now and shouldn't bother anyone.

This revision is now accepted and ready to land.Apr 17 2019, 8:08 PM

I think it's probably worth cleaning up at some point -- there's another similar rule in T13041, too, that could do with cleanup at the same time. But it's low/no-cost to just leave it around for a while and let users mostly migrate away from it on their own, hopefully.

This revision was automatically updated to reflect the committed changes.