Page MenuHomePhabricator
Differential D20472

Restore "Limit" to dashboard Query panels
ClosedPublic
Actions

Authored by epriestley on Apr 25 2019, 5:34 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Summary

See PHI1220. Ref T13272. I accidentally left the ability to set a query limit behind when updating this.

Test Plan

Edited a query panel, set/removed the limit, tried to set an invalid limit.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 25 2019, 5:34 PM
Harbormaster completed remote builds in B22719: Diff 48844.Apr 25 2019, 5:35 PM
epriestley requested review of this revision.Apr 25 2019, 5:35 PM
epriestley added a child revision: D20473: Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel.Apr 25 2019, 5:38 PM
amckinley accepted this revision.May 1 2019, 2:29 PM
amckinley retitled this revision from Resore "Limit" to dashboard Query panels to Restore "Limit" to dashboard Query panels.
This revision is now accepted and ready to land.May 1 2019, 2:29 PM
Closed by commit rP45f01dc716ee: Restore "Limit" to dashboard Query panels (authored by epriestley). · Explain WhyMay 1 2019, 3:41 PM
This revision was automatically updated to reflect the committed changes.
epriestley added an edge: rP45f01dc716ee: Restore "Limit" to dashboard Query panels.
epriestley mentioned this in T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.May 1 2019, 3:45 PM

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
paneltype/
8 lines
xaction/
panel/
43 lines
transactions/
editfield/
4 lines

Diff 48872

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelLimitTransaction.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorIntEditField.php

Loading...
Phabricator · Built by Phacility