Page MenuHomePhabricator

Add support for custom "Wait for Approval" instructions

Authored by epriestley on May 3 2019, 3:29 PM.



See PHI1229. An install has a somewhat duct-taped registration flow which can dump users on the "Wait for Approval" screen without clear guidance. The desired guidance is something like "this is totally normal, just wait a bit for a bot to approve you".

Adding guidance here is generally reasonable and consistent with the intent of this feature.

Test Plan

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 3 2019, 3:29 PM
epriestley requested review of this revision.May 3 2019, 3:31 PM

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

kylec awarded a token.May 3 2019, 5:08 PM
kylec added a subscriber: kylec.May 14 2019, 5:02 PM
amckinley accepted this revision.May 16 2019, 1:01 PM
This revision is now accepted and ready to land.May 16 2019, 1:01 PM