Page MenuHomePhabricator

Add support for custom "Wait for Approval" instructions
ClosedPublic

Authored by epriestley on May 3 2019, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 6, 2:32 AM
Unknown Object (File)
Thu, Aug 4, 6:32 AM
Unknown Object (File)
Fri, Jul 29, 7:55 PM
Unknown Object (File)
Thu, Jul 28, 12:04 AM
Unknown Object (File)
Mon, Jul 25, 5:22 PM
Unknown Object (File)
Sun, Jul 24, 12:47 PM
Unknown Object (File)
Sun, Jul 24, 10:17 AM
Unknown Object (File)
Sun, Jul 24, 9:36 AM
Subscribers
Tokens
"Love" token, awarded by kylec.

Details

Reviewers
amckinley
Summary

See PHI1229. An install has a somewhat duct-taped registration flow which can dump users on the "Wait for Approval" screen without clear guidance. The desired guidance is something like "this is totally normal, just wait a bit for a bot to approve you".

Adding guidance here is generally reasonable and consistent with the intent of this feature.

Test Plan

Screen Shot 2019-05-03 at 8.26.17 AM.png (765×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

This revision is now accepted and ready to land.May 16 2019, 1:01 PM