Page MenuHomePhabricator

Add support for custom "Wait for Approval" instructions
ClosedPublic

Authored by epriestley on Fri, May 3, 3:29 PM.

Details

Reviewers
amckinley
Summary

See PHI1229. An install has a somewhat duct-taped registration flow which can dump users on the "Wait for Approval" screen without clear guidance. The desired guidance is something like "this is totally normal, just wait a bit for a bot to approve you".

Adding guidance here is generally reasonable and consistent with the intent of this feature.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 3, 3:29 PM
epriestley requested review of this revision.Fri, May 3, 3:31 PM

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

kylec awarded a token.Fri, May 3, 5:08 PM
kylec added a subscriber: kylec.Tue, May 14, 5:02 PM
amckinley accepted this revision.Thu, May 16, 1:01 PM
This revision is now accepted and ready to land.Thu, May 16, 1:01 PM