Page MenuHomePhabricator

Add support for custom "Wait for Approval" instructions
ClosedPublic

Authored by epriestley on May 3 2019, 3:29 PM.
Tags
None
Referenced Files
F18330128: D20492.id.diff
Mon, Aug 25, 1:00 AM
F18268019: D20492.diff
Fri, Aug 22, 1:44 PM
F18100484: D20492.diff
Sat, Aug 9, 11:55 AM
F17937363: D20492.diff
Jul 31 2025, 1:09 AM
Unknown Object (File)
Jun 20 2025, 1:14 PM
Unknown Object (File)
Jun 19 2025, 10:41 AM
Unknown Object (File)
Jun 18 2025, 2:45 PM
Unknown Object (File)
Jun 1 2025, 9:49 AM
Subscribers
Tokens
"Love" token, awarded by kylec.

Details

Reviewers
amckinley
Summary

See PHI1229. An install has a somewhat duct-taped registration flow which can dump users on the "Wait for Approval" screen without clear guidance. The desired guidance is something like "this is totally normal, just wait a bit for a bot to approve you".

Adding guidance here is generally reasonable and consistent with the intent of this feature.

Test Plan

Screen Shot 2019-05-03 at 8.26.17 AM.png (765×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

This revision is now accepted and ready to land.May 16 2019, 1:01 PM