Page MenuHomePhabricator

Rename most user-facing "Autoclose" strings to "Permanent Refs"
ClosedPublic

Authored by epriestley on Sun, Apr 14, 8:27 PM.

Details

Summary

Depends on D20422. Ref T13277. Currently, "track only", "publish", and "autoclose" are three separate ideas. I'd like to generally merge them into a more natural idea called "permanent refs".

Since "Autoclose" effectively now controls both "autoclose" and "publish", rename it.

This doesn't rename all the methods or internals, and the documentation needs an update, but it renames most of the UI-facing stuff.

(You also can only specify branches as "Permanent Refs" today, but we may let you specify tags and other arbitrary refs in the future.)

Test Plan

Grepped, poked around the UI, saw UI show "Permanent" / "Permanent Refs" more often and "Autoclose" less.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sun, Apr 14, 8:27 PM
amckinley accepted this revision.Wed, Apr 17, 7:43 PM
amckinley added inline comments.
src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
397–400

This kinda implies that something nefarious might happen to refs that you mark as "non permanent": are they removed from disk? Sent to the shadow realm? Maybe "only these refs are considered as permanent"?

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
112

These variables are named inconsistently now (and variables elsewhere), which I'm guessing will get cleaned up later, but I'm also not too worried about anyway.

204

Should be "is unavailable"?

This revision is now accepted and ready to land.Wed, Apr 17, 7:43 PM
  • Fix "in/is unavailable" typo.
  • Clarify that we aren't going to banish other refs to the shadow realm.
This revision was automatically updated to reflect the committed changes.