Differential D20423

Rename most user-facing "Autoclose" strings to "Permanent Refs"
ClosedPublic
Actions

Authored by epriestley on Apr 14 2019, 8:27 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"

Commits

rPc7b2553ca084: Rename most user-facing "Autoclose" strings to "Permanent Refs"

Summary

Depends on D20422. Ref T13277. Currently, "track only", "publish", and "autoclose" are three separate ideas. I'd like to generally merge them into a more natural idea called "permanent refs".

Since "Autoclose" effectively now controls both "autoclose" and "publish", rename it.

This doesn't rename all the methods or internals, and the documentation needs an update, but it renames most of the UI-facing stuff.

(You also can only specify branches as "Permanent Refs" today, but we may let you specify tags and other arbitrary refs in the future.)

Test Plan

Grepped, poked around the UI, saw UI show "Permanent" / "Permanent Refs" more often and "Autoclose" less.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2019, 8:27 PM

epriestley requested review of this revision.Apr 14 2019, 8:50 PM

epriestley added a child revision: D20424: In repository settings, fold "Autoclose On/Off" into "Publishing On/Off".

amckinley accepted this revision.Apr 17 2019, 7:43 PM

amckinley added inline comments.

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
397–400	This kinda implies that something nefarious might happen to refs that you mark as "non permanent": are they removed from disk? Sent to the shadow realm? Maybe "only these refs are considered as permanent"?
src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
112	These variables are named inconsistently now (and variables elsewhere), which I'm guessing will get cleaned up later, but I'm also not too worried about anyway.
204	Should be "is unavailable"?