Page MenuHomePhabricator

Improve the performance of tab replacement in common cases
ClosedPublic

Authored by epriestley on Apr 25 2019, 9:38 PM.
Tags
None
Referenced Files
F20588024: D20477.diff
Fri, Jun 19, 8:46 PM
Unknown Object (File)
Wed, Jun 10, 10:21 AM
Unknown Object (File)
Mar 9 2026, 6:07 AM
Unknown Object (File)
Mar 7 2026, 6:21 PM
Unknown Object (File)
Mar 5 2026, 4:13 AM
Unknown Object (File)
Feb 8 2026, 11:22 AM
Unknown Object (File)
Jan 18 2026, 1:18 PM
Unknown Object (File)
Jan 15 2026, 5:23 AM
Subscribers
None

Details

Summary

See PHI1210. For certain large inputs, we spend more time than we need to replacing tabs with spaces. Add some fast paths:

  • When a line only has tabs at the beginning of the line, we don't need to do as much work parsing the rest of the line.
  • When a line has no unicode characters, we don't need to vectorize it to get the right result.
Test Plan
  • Added test coverage.
  • Profiled this, got a ~60x performance increase on a 36,000 line 3MB text file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable