Page MenuHomePhabricator

Move BlameController away from ancient "TABLE_COMMIT"
ClosedPublic

Authored by epriestley on Apr 22 2019, 6:47 PM.

Details

Summary

Ref T13276. Differential has a pre-edge "TABLE_COMMIT" with about a half-dozen weird callers I'd like to get rid of.

Move blame to use edges instead. (Bonus: this makes blame respect edge edits in the UI.)

Since there are some more callers to clean up this code may move into some "RelatedObjectQueryThing" class or something, but I'm taking it one step at a time for now.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 22 2019, 6:47 PM
epriestley requested review of this revision.Apr 22 2019, 6:49 PM
amckinley accepted this revision.Apr 23 2019, 4:30 PM
This revision is now accepted and ready to land.Apr 23 2019, 4:30 PM
This revision was automatically updated to reflect the committed changes.