Page MenuHomePhabricator
Differential D20529

Support timeouts in OAuth1Future
ClosedPublic
Actions

Authored by epriestley on Mon, May 20, 6:39 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13285: Service failures in JIRA can cascade into service failures in Phabricator
T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion
Commits
rPHU07e92da74e9a: Support timeouts in OAuth1Future
Summary

Ref T13291. Ref T13285. Add "setTimeout()" to OAuth1Future to support adding timeouts to Doorkeeper OAuth requests, so we're less likely to cascade into explosive failure if a linked JIRA instance dies.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 20, 6:39 PM
epriestley requested review of this revision.Mon, May 20, 6:39 PM
epriestley updated this revision to Diff 48958.Mon, May 20, 6:45 PM
  • Also add support to the "AsanaFuture", which is a separate future.
amckinley accepted this revision.Tue, May 21, 5:44 PM
This revision is now accepted and ready to land.Tue, May 21, 5:44 PM
epriestley added a commit: rPHU07e92da74e9a: Support timeouts in OAuth1Future.Tue, May 21, 7:13 PM
Closed by commit rPHU07e92da74e9a: Support timeouts in OAuth1Future (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48973

View Options

src/future/asana/PhutilAsanaFuture.php

Loading...
View Options

src/future/oauth/PhutilOAuth1Future.php

Loading...
Phabricator · Built by Phacility