Page MenuHomePhabricator

Support timeouts in OAuth1Future
ClosedPublic

Authored by epriestley on May 20 2019, 6:39 PM.
Tags
None
Referenced Files
F12841330: D20529.diff
Thu, Mar 28, 9:08 PM
F12837502: D20529.id48958.diff
Thu, Mar 28, 5:06 PM
Unknown Object (File)
Sat, Mar 23, 12:51 AM
Unknown Object (File)
Sat, Mar 23, 12:51 AM
Unknown Object (File)
Sat, Mar 23, 12:51 AM
Unknown Object (File)
Sat, Mar 23, 12:51 AM
Unknown Object (File)
Sat, Mar 23, 12:51 AM
Unknown Object (File)
Sun, Mar 17, 5:06 PM
Subscribers
None

Details

Summary

Ref T13291. Ref T13285. Add "setTimeout()" to OAuth1Future to support adding timeouts to Doorkeeper OAuth requests, so we're less likely to cascade into explosive failure if a linked JIRA instance dies.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Also add support to the "AsanaFuture", which is a separate future.
This revision is now accepted and ready to land.May 21 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.