Page MenuHomePhabricator

Support timeouts in OAuth1Future
ClosedPublic

Authored by epriestley on May 20 2019, 6:39 PM.
Tags
None
Referenced Files
F14008392: D20529.diff
Tue, Oct 29, 8:29 PM
F14007392: D20529.id48973.diff
Tue, Oct 29, 4:58 AM
F14005871: D20529.id.diff
Sun, Oct 27, 9:11 PM
F13977334: D20529.diff
Fri, Oct 18, 6:08 PM
F13959819: D20529.diff
Mon, Oct 14, 8:51 PM
F13959404: D20529.id48958.diff
Mon, Oct 14, 7:16 PM
Unknown Object (File)
Oct 3 2024, 6:40 PM
Unknown Object (File)
Sep 30 2024, 12:56 AM
Subscribers
None

Details

Summary

Ref T13291. Ref T13285. Add "setTimeout()" to OAuth1Future to support adding timeouts to Doorkeeper OAuth requests, so we're less likely to cascade into explosive failure if a linked JIRA instance dies.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Also add support to the "AsanaFuture", which is a separate future.
This revision is now accepted and ready to land.May 21 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.