Page MenuHomePhabricator
Differential D20456

Fix "before/after" cursor paging for API call "feed.query"
ClosedPublic
Actions

Authored by epriestley on Apr 22 2019, 5:42 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13266: Upgrading: Minor Changes to Query Paging / Cursors
Commits
rP2ffc4be4e7df: (stable) Fix "before/after" cursor paging for API call "feed.query"
rPb0b8926c7564: Fix "before/after" cursor paging for API call "feed.query"
Summary

Ref T13266. See https://discourse.phabricator-community.org/t/undefined-method-setafterid-when-calling-feed-query/2653.

This older API call needs an update to the newer paging/cursor API.

Test Plan

Called feed.query with an "after" parameter.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 22 2019, 5:42 PM
epriestley requested review of this revision.Apr 22 2019, 5:43 PM
Itms added a subscriber: Itms.Apr 22 2019, 9:39 PM
amckinley accepted this revision.Apr 23 2019, 4:29 PM
This revision is now accepted and ready to land.Apr 23 2019, 4:29 PM
Closed by commit rPb0b8926c7564: Fix "before/after" cursor paging for API call "feed.query" (authored by epriestley). · Explain WhyApr 23 2019, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48826

View Options

src/applications/feed/conduit/FeedQueryConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility