Page MenuHomePhabricator

Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:06 PM.

Details

Summary

Depends on D20457. Ref T13276. Kill all remaining callers to this method and delete it.

Test Plan
  • Grepped for loadIDsByCommitPHIDs.
  • Viewed blame again to make sure I didn't break it.
  • Viewed "History" view for commits with revisions.
  • Viewed "Graph" view for commits with revisions.
  • Viewed "Merged Commits" table for commits with revisions.
  • Viewed "Compare" table for commits with revisions.
  • Viewed "Repository" main page history table for commits with revisions.
  • Grepped for linkRevision.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 22 2019, 7:06 PM
epriestley requested review of this revision.Apr 22 2019, 7:08 PM
amckinley accepted this revision.Apr 23 2019, 5:14 PM
This revision is now accepted and ready to land.Apr 23 2019, 5:14 PM
amckinley added inline comments.Apr 23 2019, 5:18 PM
src/applications/diffusion/query/DiffusionCommitRevisionQuery.php
9

assert_instances_of?

  • Typechecking.
This revision was automatically updated to reflect the committed changes.