Page MenuHomePhabricator

Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:06 PM.
Tags
None
Referenced Files
F17803703: D20458.diff
Fri, Jul 25, 10:30 AM
Unknown Object (File)
Jun 25 2025, 7:08 PM
Unknown Object (File)
Jun 17 2025, 6:36 AM
Unknown Object (File)
Jun 5 2025, 4:21 PM
Unknown Object (File)
May 19 2025, 1:28 PM
Unknown Object (File)
May 18 2025, 1:52 PM
Unknown Object (File)
May 10 2025, 12:00 AM
Unknown Object (File)
May 7 2025, 3:11 PM
Subscribers
None

Details

Summary

Depends on D20457. Ref T13276. Kill all remaining callers to this method and delete it.

Test Plan
  • Grepped for loadIDsByCommitPHIDs.
  • Viewed blame again to make sure I didn't break it.
  • Viewed "History" view for commits with revisions.
  • Viewed "Graph" view for commits with revisions.
  • Viewed "Merged Commits" table for commits with revisions.
  • Viewed "Compare" table for commits with revisions.
  • Viewed "Repository" main page history table for commits with revisions.
  • Grepped for linkRevision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable