Page MenuHomePhabricator

Support "none()" in Differential to find revisions with no (un-resigned) reviewers

Authored by epriestley on May 21 2019, 2:26 PM.



Ref T13289. In Maniphest, you can currently search for "Owner: none()" to find tasks with no owner, but there's no way to search for "Reviewers: none()" in Differential right now.

Add support for this, since it's consistent and reasonable and doesn't seem too weird or niche.

Test Plan

Searched for "Reviewers: none()", found revisions with no reviewers. Searched for "Reviewers: alice, none()", "Reviewers: alice", and "Reviewers: <no constraint>" and got sensible results.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 21 2019, 2:26 PM
epriestley requested review of this revision.May 21 2019, 2:27 PM
amckinley edited the summary of this revision. (Show Details)May 21 2019, 5:07 PM
amckinley accepted this revision.May 21 2019, 6:44 PM
This revision is now accepted and ready to land.May 21 2019, 6:44 PM