Page MenuHomePhabricator
Feed Advanced Search

Feb 17 2023

epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
Feb 17 2023, 6:35 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:30 PM · Remarkup

Oct 26 2022

epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
  • Inline Comments: See PHI2217. See PHI2206. Inline comments don't currently attach images.
  • Destroying Edges: See PHI2201. See PHI2217. Destroying files that have old edge types may raise warnings. The destruction still works, although it doesn't hit the edges.
  • Destroying Files: See PHI2217. Destroying an object doesn't destroy corresponding FileAttachment objects, so you can end up with ghosts in the UI.
Oct 26 2022, 8:08 PM · Remarkup

May 28 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21849: Improve remarkup metadata robustness against debris in the database.
May 28 2022, 1:29 PM · Remarkup

May 27 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21848: Update Slowvote poll status to use sensible string constants.
May 27 2022, 5:14 PM · Remarkup

May 26 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21847: Separate Slowvote poll status onto a dedicated object.
May 26 2022, 5:46 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21846: Update Slowvote voting methods to use sensible string constants.
May 26 2022, 5:24 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21845: Move Slowvote vote types to a separate object.
May 26 2022, 5:09 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21844: Update Slowvote to use sensible string constants for response visibility.
May 26 2022, 4:58 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21843: Move Slowvote response visibility to a separate object.
May 26 2022, 4:40 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21842: Migrate "SlowvotePoll" to modern mailkey storage.
May 26 2022, 12:10 AM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21841: Update nonstandard PHID key on "SlowvotePoll".
May 26 2022, 12:00 AM · Remarkup

May 25 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21840: Update "Files" attachment table to show more attachment details and support detachment.
May 25 2022, 7:53 PM · Remarkup
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".

"PhabricatorApplicationTransactionCommentView->setDraft()" has exactly two callers: one in Slowvote...

May 25 2022, 5:33 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21839: Pass "object" to modular transaction methods explicitly.
May 25 2022, 5:18 PM · Remarkup

May 24 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".
May 24 2022, 5:08 PM · Remarkup
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
May 24 2022, 4:56 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
May 24 2022, 1:12 AM · Remarkup

May 23 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21836: Provide a rudimentary "Attached Files" curtain UI panel.
May 23 2022, 6:13 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21835: Give "FileAttachment" policy support and a query object.
May 23 2022, 5:24 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21834: Provide missing default attachment list for Files transactions.
May 23 2022, 4:24 PM · Remarkup

May 20 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21833: Don't consider file references inside quoted text blocks to grant "attachment intent".
May 20 2022, 6:23 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21832: Only attach files that are both referenced in Remarkup and attached by explicit metadata.
May 20 2022, 5:48 PM · Remarkup
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
May 20 2022, 5:24 PM · Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
May 20 2022, 5:12 PM · Remarkup

May 19 2022

epriestley triaged T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default" as Normal priority.
May 19 2022, 8:08 PM · Remarkup

May 9 2022

epriestley closed T13678: Remarkup objects may form rendering cycles when embedded as Resolved.
May 9 2022, 7:02 PM · Remarkup
epriestley added a revision to T13678: Remarkup objects may form rendering cycles when embedded: D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
May 9 2022, 6:20 PM · Remarkup
epriestley triaged T13678: Remarkup objects may form rendering cycles when embedded as Normal priority.
May 9 2022, 6:06 PM · Remarkup

Sep 28 2020

epriestley added a revision to T13564: Remarkup tables should show all content when printed to PDF: D21472: When printing, wrap all content in Remarkup tables more aggressively.
Sep 28 2020, 4:22 PM · Google Chrome, Remarkup

Aug 11 2020

epriestley added a comment to T13564: Remarkup tables should show all content when printed to PDF.

Adding overflow-wrap: anywhere appears to fix this without breaking anything.

Aug 11 2020, 5:35 PM · Google Chrome, Remarkup
epriestley triaged T13564: Remarkup tables should show all content when printed to PDF as Normal priority.
Aug 11 2020, 5:17 PM · Google Chrome, Remarkup

May 21 2020

epriestley closed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) as Resolved.

I think (?) this was pretty much resolved by the last round of changes. See T13291 for some followups.

May 21 2020, 4:03 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

May 3 2020

epriestley closed T13530: Unterminated remarkup literal blocks ("%%%") can trigger a parser error as Resolved by committing rP6f09edeb91e8: Fix an issue where the "%%%" parser could match too many lines in unterminated….
May 3 2020, 4:25 PM · Remarkup
epriestley added a revision to T13530: Unterminated remarkup literal blocks ("%%%") can trigger a parser error: D21208: Fix an issue where the "%%%" parser could match too many lines in unterminated blocks.
May 3 2020, 4:18 PM · Remarkup
epriestley triaged T13530: Unterminated remarkup literal blocks ("%%%") can trigger a parser error as Low priority.
May 3 2020, 4:16 PM · Remarkup

Feb 6 2020

epriestley closed T5427: Force a line break in a table cell as Resolved by committing rP2327578adc94: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 11:01 PM · Remarkup
epriestley added a revision to T5427: Force a line break in a table cell: D20971: Respect linebreaks in full HTML tables in Remarkup.
Feb 6 2020, 10:53 PM · Remarkup
epriestley added a comment to T5427: Force a line break in a table cell.

(See also T13160, and D20568 for additional rationale.)

Feb 6 2020, 10:50 PM · Remarkup
epriestley reopened T5427: Force a line break in a table cell as "Open".

See also PHI1630.

Feb 6 2020, 10:49 PM · Remarkup

Feb 4 2020

epriestley closed T13487: Improve performance of remarkup block splitting as Resolved by committing rPfdbe9ba149b6: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 11:07 PM · Remarkup
epriestley added a revision to T13487: Improve performance of remarkup block splitting: D20968: Improve Remarkup parsing performance for certain large input blocks.
Feb 4 2020, 10:37 PM · Remarkup
epriestley added a comment to T13487: Improve performance of remarkup block splitting.

To attempt to justify micro-optimizing this loop:

Feb 4 2020, 9:45 PM · Remarkup
epriestley triaged T13487: Improve performance of remarkup block splitting as Wishlist priority.
Feb 4 2020, 9:23 PM · Remarkup
epriestley closed T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Resolved by committing rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….
Feb 4 2020, 4:09 PM · Remarkup
epriestley added a revision to T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup: D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks.
Feb 4 2020, 4:05 PM · Remarkup

Jan 29 2020

epriestley updated the task description for T13482: Remove strikethru style from checked-off Remarkup list items.
Jan 29 2020, 5:21 PM · Remarkup
epriestley closed T12865: Strikethrough for icons in checked remarkup list items as Wontfix.

I removed the strikethrough in T13482, which mostly moots this.

Jan 29 2020, 5:21 PM · Remarkup, Feature Request
epriestley closed T13482: Remove strikethru style from checked-off Remarkup list items as Resolved by committing rP7a1681b8dae1: Don't use "line-through" style for completed items in remarkup checklists.
Jan 29 2020, 4:59 PM · Remarkup
epriestley added a revision to T13482: Remove strikethru style from checked-off Remarkup list items: D20954: Don't use "line-through" style for completed items in remarkup checklists.
Jan 29 2020, 4:53 PM · Remarkup
epriestley triaged T13482: Remove strikethru style from checked-off Remarkup list items as Wishlist priority.
Jan 29 2020, 4:52 PM · Remarkup

Nov 13 2019

epriestley closed T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Resolved by committing rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.
Nov 13 2019, 6:35 PM · Dashboards, Remarkup
epriestley added a revision to T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc): D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Nov 13 2019, 6:32 PM · Dashboards, Remarkup
epriestley triaged T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Low priority.
Nov 13 2019, 6:31 PM · Dashboards, Remarkup

Sep 24 2019

epriestley closed T4280: Embed anchor in remark up text and later link to it. as Resolved by committing rPb1d4d5c00ce1: Add an "{anchor #xyz}" rule to Remarkup.
Sep 24 2019, 6:04 PM · Remarkup
epriestley added a revision to T4280: Embed anchor in remark up text and later link to it. : D20825: Add an "{anchor #xyz}" rule to Remarkup.
Sep 24 2019, 5:26 PM · Remarkup

Sep 20 2019

epriestley triaged T13422: Remarkup previews with embedded video have flickery behavior as Wishlist priority.
Sep 20 2019, 3:46 PM · Remarkup

Sep 9 2019

epriestley added a parent task for T4280: Embed anchor in remark up text and later link to it. : T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Remarkup

Jul 10 2019

epriestley triaged T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Wishlist priority.
Jul 10 2019, 10:11 PM · Remarkup

Jun 25 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20619: Bump the remarkup cache version after JIRA/Asana rule changes.
Jun 25 2019, 7:55 PM · Remarkup, Diffusion

Jun 19 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Jun 19 2019, 5:46 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20591: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
Jun 19 2019, 5:44 PM · Remarkup, Diffusion
epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.

See PHI1312. The modified JIRA rules reportedly misfire on URIs with anchors or parameters. For now, the plan is to just skip these URIs. In the future, we might specialize URIs which (for example) link to comments on foreign objects.

Jun 19 2019, 5:33 PM · Remarkup, Diffusion
epriestley closed T9720: Provide a way to link to Diffusion files, a subtask of T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does), as Resolved.
Jun 19 2019, 5:32 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T9720: Provide a way to link to Diffusion files.

I'm going to close this in favor of T13291. Referencing files by full URI currently works, and relative references and other behavior is planned.

Jun 19 2019, 5:32 PM · Restricted Project, Remarkup
epriestley closed T9720: Provide a way to link to Diffusion files, a subtask of T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion, as Resolved.
Jun 19 2019, 5:32 PM · Remarkup, Diffusion
epriestley added a parent task for T9720: Provide a way to link to Diffusion files: T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
Jun 19 2019, 5:31 PM · Restricted Project, Remarkup
epriestley added a subtask for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: T9720: Provide a way to link to Diffusion files.
Jun 19 2019, 5:31 PM · Remarkup, Diffusion

Jun 4 2019

epriestley added a revision to T13160: Support <colgroup> in the verbose remarkup <table> syntax for specifying column widths: D20568: Parse remarkup tables with something like a real parser instead of regular expressions.
Jun 4 2019, 4:32 PM · Remarkup

May 23 2019

epriestley moved T6276: Cannot Create Named Link to URI with Brackets from Parser to Next on the Remarkup board.
May 23 2019, 2:49 PM · Remarkup
epriestley moved T12191: Remarkup autocomplete can remain open after keyboard form submission from Backlog to Next on the Remarkup board.
May 23 2019, 2:48 PM · Remarkup, PHUI
epriestley moved T7967: impossible to link string that contain ']' with remarkup syntax. from Backlog to Next on the Remarkup board.
May 23 2019, 2:47 PM · Remarkup
epriestley moved T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained from Backlog to Next on the Remarkup board.
May 23 2019, 2:46 PM · Documentation, Remarkup
epriestley moved T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion from Backlog to Next on the Remarkup board.
May 23 2019, 2:45 PM · Remarkup, Diffusion

May 22 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages.
May 22 2019, 9:15 PM · Remarkup, Diffusion
epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.

See also T13290. Now that full URIs count as mentions (D20527), the text "Differential Revision: ..." in commits is counting as a mention, and "mentioning" the associated revision.

May 22 2019, 11:51 AM · Remarkup, Diffusion

May 21 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.
May 21 2019, 7:01 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20538: Recognize self-URI links to Diffusion files and give them special rendering behavior.
May 21 2019, 4:46 PM · Remarkup, Diffusion

May 20 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20530: Add a 15-second timeout to external service calls to fill Doorkeeper link tags.
May 20 2019, 6:45 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20529: Support timeouts in OAuth1Future.
May 20 2019, 6:39 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20528: Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules.
May 20 2019, 6:23 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: D20527: When an object is referenced by URI, treat it like a mention.
May 20 2019, 4:59 PM · Remarkup, Diffusion
epriestley added revisions to T11229: Quotes breaks headings by default: D20327: In remarkup, strip one leading space from each line in a quoted block if possible, D20393: Make the "Reply" and "Quote" Remarkup rules more similar.
May 20 2019, 12:03 PM · Remarkup, Bug Report

May 19 2019

epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 19 2019, 8:48 PM · Remarkup, Diffusion

May 17 2019

epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 17 2019, 3:13 PM · Remarkup, Diffusion
epriestley triaged T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion as Normal priority.
May 17 2019, 2:22 PM · Remarkup, Diffusion

May 16 2019

epriestley triaged T13288: Add a "Download" / view raw option to code blocks in Remarkup as Low priority.
May 16 2019, 7:52 PM · Remarkup

May 10 2019

epriestley added a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T13285: Service failures in JIRA can cascade into service failures in Phabricator.
May 10 2019, 2:15 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

May 9 2019

epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20512: Specialize rendering of self-URIs in the form "/X123".
May 9 2019, 8:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20511: Provide an extension point for handling hyperlinks in remarkup in a special way.
May 9 2019, 7:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a subtask for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T9720: Provide a way to link to Diffusion files.
May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a parent task for T9720: Provide a way to link to Diffusion files: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:31 PM · Restricted Project, Remarkup
epriestley added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

PHI1224 describes a somewhat-adjacent situation: an install would like a way for external automated tooling to reference source files and generate editor links for them.

May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley claimed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley removed a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T7443: Include full link to Maniphest tasks in commit messages.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20510: When a user pastes a Phabricator URI into the search box, redirect to the URI.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.
May 9 2019, 6:21 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia

Apr 27 2019

epriestley moved T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) from Backlog to Next on the Remarkup board.
Apr 27 2019, 5:12 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T9720: Provide a way to link to Diffusion files from Backlog to Next on the Remarkup board.
Apr 27 2019, 5:12 PM · Restricted Project, Remarkup
epriestley closed T10571: Default quote action breaks text between lists as Resolved.

I believe this was resolved by D20327 / D20393.

Apr 27 2019, 5:11 PM · Remarkup, Wikimedia