Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
84fd5cd5bb4e
Actions

Description

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks

Summary: Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan: Added a test, made it pass. Previewed blocks in web UI.

Maniphest Tasks: T13335

Differential Revision: https://secure.phabricator.com/D20965

Details

Provenance

epriestley	Authored on Feb 4 2020, 4:03 PM
epriestley	Pushed on Feb 4 2020, 4:09 PM

Differential Revision

D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks

Parents

rP0f1acb6cef1d: Update GitHub API calls to use "Authorization" header instead of "access_token"…

Branches

Unknown

Tags

Unknown

Tasks

T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup

Build Status

Buildable 23782
Build 32704: Run Core Tests

Event Timeline

epriestley committed rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted… (authored by epriestley).Feb 4 2020, 4:09 PM

epriestley added a task: T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup.

epriestley added an edge: D20965: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks.

Harbormaster completed building B23782: rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….Feb 4 2020, 4:11 PM

Changes (3)

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

blockrule/

PhutilRemarkupQuotedBlockRule.php

remarkup/

__tests__/

remarkup/

quoted-paragraphs.txt

rP84fd5cd5bb4e

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

View Options

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

View Options

src/infrastructure/markup/remarkup/tests/remarkup/quoted-paragraphs.txt

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…84fd5cd5bb4eActions

Description

Details

Event Timeline

Changes (3)

rP84fd5cd5bb4e

src/infrastructure/markup/PhabricatorMarkupEngine.php

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
84fd5cd5bb4e
Actions

src/infrastructure/markup/remarkup/tests/remarkup/quoted-paragraphs.txt