Page MenuHomePhabricator

Prevent embedded remarkup content from cycling when it contains embedded self-references
ClosedPublic

Authored by epriestley on Mon, May 9, 6:20 PM.
Tags
None
Attached Files
F10758867: D21810.id51985.diff
Wed, May 25, 2:42 PM
F10758408: D21810.diff
Wed, May 25, 1:44 PM
Unknown Object (File)
Tue, May 24, 2:34 PM
Unknown Object (File)
Tue, May 24, 1:18 PM
F10698351: Screen Shot 2022-05-09 at 11.16.25 AM.png
Mon, May 9, 6:20 PM
Subscribers
None

Details

Summary

Ref T13678. When remarkup content embeds other remarkup content, detect and degrade if the references have nesting depth greater than 1. This is a coarse cycle detector, since rendering shallow (but technically non-cycling) trees doesn't seem valuable.

Test Plan

Created various objects with self-references, saw everything degrade properly (after one level of embedding) when embedded in itself and in other contexts. See attached screenshot.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 9, 6:21 PM
This revision was automatically updated to reflect the committed changes.