Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"
ClosedPublic

Authored by epriestley on May 20 2022, 6:23 PM.
Tags
None
Referenced Files
F15451901: D21833.id52043.diff
Sat, Mar 29, 12:27 AM
F15451892: D21833.id52034.diff
Sat, Mar 29, 12:24 AM
F15451885: D21833.id.diff
Sat, Mar 29, 12:21 AM
F15449411: D21833.id52043.diff
Fri, Mar 28, 10:01 AM
F15439197: D21833.diff
Wed, Mar 26, 6:18 AM
F15438019: D21833.id.diff
Tue, Mar 25, 10:49 PM
F15430344: D21833.id52034.diff
Mon, Mar 24, 7:12 AM
F15391536: D21833.id52043.diff
Sat, Mar 15, 10:24 AM
Subscribers
None

Details

Summary

Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.