Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"
ClosedPublic

Authored by epriestley on May 20 2022, 6:23 PM.
Tags
None
Referenced Files
F18106718: D21833.id.diff
Sun, Aug 10, 11:13 PM
F18053982: D21833.id.diff
Mon, Aug 4, 5:54 AM
F18045691: D21833.diff
Sun, Aug 3, 9:39 AM
F17945183: D21833.id52043.diff
Thu, Jul 31, 11:32 AM
F17759156: D21833.id52034.diff
Tue, Jul 22, 6:07 PM
F17740538: D21833.diff
Mon, Jul 21, 6:23 AM
F17674454: D21833.diff
Jul 13 2025, 7:17 AM
F17657343: D21833.diff
Jul 12 2025, 12:16 PM
Subscribers
None

Details

Summary

Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.