Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"

Authored by epriestley on May 20 2022, 6:23 PM.
Referenced Files
F13041378: D21833.diff
Tue, Apr 16, 8:12 PM
Unknown Object (File)
Mon, Apr 15, 9:33 PM
Unknown Object (File)
Sat, Apr 6, 9:44 PM
Unknown Object (File)
Mon, Apr 1, 11:01 PM
Unknown Object (File)
Sun, Mar 31, 8:02 AM
Unknown Object (File)
Sun, Mar 31, 7:13 AM
Unknown Object (File)
Sat, Mar 23, 7:04 PM
Unknown Object (File)
Tue, Mar 19, 5:29 PM



Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.