Page MenuHomePhabricator

Don't consider file references inside quoted text blocks to grant "attachment intent"
ClosedPublic

Authored by epriestley on May 20 2022, 6:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 18, 10:06 PM
Unknown Object (File)
Thu, Jun 16, 10:25 AM
Unknown Object (File)
Thu, Jun 16, 10:25 AM
Unknown Object (File)
Thu, Jun 16, 10:25 AM
Unknown Object (File)
Mon, Jun 13, 1:49 PM
Unknown Object (File)
Wed, Jun 8, 2:20 PM
Unknown Object (File)
Sun, Jun 5, 1:53 AM
Unknown Object (File)
Wed, Jun 1, 12:44 PM
Subscribers
None

Details

Summary

Ref T13682. This is a marginal case, but if you quote someone else's text and it has a file reference embedded in it, that isn't good enough to generate "attachment intent".

Since you need both a reference and an explicit attachment, this should never actually affect any user-visible behavior today, but makes the ruleset more thorough.

Test Plan

Dragged and dropped a file, referencing it in either a quoted or unquoted block. Saw it attach only for a quoted block.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 23 2022, 9:08 PM
This revision was automatically updated to reflect the committed changes.