Make the "Reply" and "Quote" Remarkup rules more similar
ClosedPublic
Actions

Authored by epriestley on Apr 10 2019, 8:07 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T11229: Quotes breaks headings by default

Commits

rPHU3e6a9946bcfc: (stable) Promote 2019 Week 16
rPHU639e4b9cae28: Make the "Reply" and "Quote" Remarkup rules more similar

Summary

Previously, see D20327. The "Reply" and "Quote" remarkup rules currently have some copy/pastey-feeling code, and the "Reply" rule wasn't touched by D20327.

The difference is that a reply starts with >>! In X, Y wrote:, although the attribution line is freeform text.

Make them both subclasses of a quoted-thing rule and push as much logic as possible up into the base class.

Test Plan

Added a unit test, made it pass. Existing tests all still pass, except for minor adjustments which look like improvements to me.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 10 2019, 8:07 PM

Harbormaster completed remote builds in B22540: Diff 48665.Apr 10 2019, 8:07 PM

epriestley requested review of this revision.Apr 10 2019, 8:07 PM

epriestley added inline comments.Apr 10 2019, 8:09 PM

src/markup/engine/__tests__/remarkup/quoted-lists.txt
21–23	Oh, this and the one above are also behavioral: no more trailing whitespace.
src/markup/engine/__tests__/remarkup/quoted-quote.txt
2–5	This is the thing I'm trying to fix. The version with no `>>!` was fixed by D20327, but this version didn't get touched because of the copy-pasteyness.
src/markup/engine/__tests__/remarkup/reply-basic.txt
12	Behavioral change: removal of extra empty newline. But seems like an improvement (more faithful to the input).
src/markup/engine/__tests__/remarkup/reply-nested.txt
44–48	Behavioral changes, but this output is more faithful to the input.