Page MenuHomePhabricator
Differential D20965

Fix an issue where intracontent empty lines were incorrectly trimmed in quoted blocks
ClosedPublic
Actions

Authored by epriestley on Feb 4 2020, 4:05 PM.
Tags
None
Referenced Files
F15503968: D20965.id49957.diff
Mon, Apr 14, 2:45 PM
F15491569: D20965.id49956.diff
Sat, Apr 12, 4:59 AM
F15485484: D20965.diff
Thu, Apr 10, 12:03 AM
F15484603: D20965.id49957.diff
Wed, Apr 9, 7:11 PM
F15479026: D20965.id.diff
Tue, Apr 8, 4:53 AM
F15476633: D20965.diff
Mon, Apr 7, 8:05 AM
F15458669: D20965.id49957.diff
Mon, Mar 31, 6:15 AM
F15428402: D20965.id49956.diff
Mar 23 2025, 8:07 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup
Commits
rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted…
Summary

Fixes T13335. When processing quoted blocks, we remove leading empty lines. This logic incorrectly continued after encountering a nonempty line.

Test Plan

Added a test, made it pass. Previewed blocks in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 4 2020, 4:05 PM
Harbormaster completed remote builds in B23781: Diff 49956.Feb 4 2020, 4:07 PM
epriestley requested review of this revision.Feb 4 2020, 4:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 4:09 PM
Closed by commit rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84fd5cd5bb4e: Fix an issue where intracontent empty lines were incorrectly trimmed in quoted….

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
2 lines
blockrule/
2 lines
remarkup/
__tests__/
remarkup/
11 lines

Diff 49957

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/blockrule/PhutilRemarkupQuotedBlockRule.php

Loading...
View Options

src/infrastructure/markup/remarkup/__tests__/remarkup/quoted-paragraphs.txt

Loading...
Phabricator · Built by Phacility