Page MenuHomePhabricator

Pass "object" to modular transaction methods explicitly
ClosedPublic

Authored by epriestley on May 25 2022, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 17, 11:30 AM
Unknown Object (File)
Thu, Jun 16, 10:27 AM
Unknown Object (File)
Thu, Jun 16, 10:27 AM
Unknown Object (File)
Thu, Jun 16, 10:27 AM
Unknown Object (File)
Mon, Jun 13, 1:51 PM
Unknown Object (File)
Mon, May 30, 4:33 PM
Unknown Object (File)
Mon, May 30, 4:33 PM
Unknown Object (File)
Mon, May 30, 4:32 PM
Subscribers
None

Details

Summary

Ref T13682. When editing a comment, the edit pathway may invoke file PHID extraction without first formalizing an object on the Editor.

Pass the "object" explicitly to generally improve the robustness of this pathway.

Test Plan

Edited a comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 5:25 PM
This revision was automatically updated to reflect the committed changes.